MIME-Version: 1.0
References: <CAA-aLv6nq=UeiyvM7_Mxgo9TVBzs2oh46b9vfyLzuyVEz3j1-g@mail.gmail.com>
In-Reply-To: <CAA-aLv6nq=UeiyvM7_Mxgo9TVBzs2oh46b9vfyLzuyVEz3j1-g@mail.gmail.com>
Reply-To: fabriziomello@gmail.com
From: =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com>
Date: Fri, 28 Feb 2025 13:54:13 -0300
Message-ID: <CAFcNs+qvagUy23M=DYwPa9jXFPFGz3L4-RfQysd_z_Ug=CQwXw@mail.gmail.com>
Subject: Re: Space missing from EXPLAIN output
To: Thom Brown <thom@linux.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000a3fea5062f36a82f"
Archived-At: <https://www.postgresql.org/message-id/CAFcNs%2BqvagUy23M%3DDYwPa9jXFPFGz3L4-RfQysd_z_Ug%3DCQwXw%40mail.gmail.com>
Precedence: bulk

--000000000000a3fea5062f36a82f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 28, 2025 at 1:38=E2=80=AFPM Thom Brown <thom@linux.com> wrote:

> Hi,
>
> Commit ddb17e387aa introduced fractional row counts, but the rejigging
> has introduced a formatting issue:
>
> Worker 0:  actual time=3D34.779..34.780rows=3D0 loops=3D1
>   Buffers: shared hit=3D1200
> Worker 1:  actual time=3D39.737..39.738rows=3D0 loops=3D1
>   Buffers: shared hit=3D1084
>
> A space is missing between the time values and the "rows" label.
>
>
Are you sure your main is updated? The current main
is 424ededc580b03e1bcf8aff18a735e519c80061f.

Because your patch is not applying:
main on =EE=82=A0 main [$]
=E2=9E=9C git apply /tmp/fix_explain_analyze_spacing.diff
error: patch failed: src/backend/commands/explain.c:2075
error: src/backend/commands/explain.c: patch does not apply

On the current main your change should be on line 2041 and not 2075
according to your patch.

Regards,

--=20
Fabr=C3=ADzio de Royes Mello

--000000000000a3fea5062f36a82f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote gmail=
_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Feb 28, 202=
5 at 1:38=E2=80=AFPM Thom Brown &lt;<a href=3D"mailto:thom@linux.com">thom@=
linux.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Hi,<br>
<br>
Commit ddb17e387aa introduced fractional row counts, but the rejigging<br>
has introduced a formatting issue:<br>
<br>
Worker 0:=C2=A0 actual time=3D34.779..34.780rows=3D0 loops=3D1<br>
=C2=A0 Buffers: shared hit=3D1200<br>
Worker 1:=C2=A0 actual time=3D39.737..39.738rows=3D0 loops=3D1<br>
=C2=A0 Buffers: shared hit=3D1084<br>
<br>
A space is missing between the time values and the &quot;rows&quot; label.<=
br>
<br></blockquote></div><div><br></div><div>Are you sure your main is update=
d? The current main is=C2=A0424ededc580b03e1bcf8aff18a735e519c80061f.</div>=
<div><br></div><div>Because your patch is not applying:</div><div>main on =
=EE=82=A0 main [$] <br>=E2=9E=9C git apply /tmp/fix_explain_analyze_spacing=
.diff =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>error: patch failed: src/backend/comma=
nds/explain.c:2075<br>error: src/backend/commands/explain.c: patch does not=
 apply<br></div><div><br></div><div>On the current main your change should =
be on line 2041 and not 2075 according to your patch.</div><div><br></div><=
div>Regards,</div><div><br></div><span class=3D"gmail_signature_prefix">-- =
</span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Fabr=
=C3=ADzio de Royes Mello</div></div></div>

--000000000000a3fea5062f36a82f--