MIME-Version: 1.0
References: <CAFh8B==xZ_qJNPtyajD5FSZbLKKXiOKv9Hoj08vcUHeo1rcoqw@mail.gmail.com>
 <35888.1702998819@sss.pgh.pa.us>
In-Reply-To: <35888.1702998819@sss.pgh.pa.us>
From: Alexander Kukushkin <cyberdemn@gmail.com>
Date: Wed, 20 Dec 2023 11:29:24 +0100
Message-ID: <CAFh8B=nXUp-bJenhfLzQ8LooXVmcNNfC=0CMYoBr=izqhJ5rDg@mail.gmail.com>
Subject: Re: Allow custom parameters with more than one dot in config files.
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000a5d69e060cee75bd"
Archived-At: <https://www.postgresql.org/message-id/CAFh8B%3DnXUp-bJenhfLzQ8LooXVmcNNfC%3D0CMYoBr%3DizqhJ5rDg%40mail.gmail.com>
Precedence: bulk

--000000000000a5d69e060cee75bd
Content-Type: text/plain; charset="UTF-8"

On Tue, 19 Dec 2023 at 16:13, Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
> I wonder if we wouldn't be better advised to require exactly one dot.
> This isn't a feature that we really encourage users to use, and the
> further we move the goalposts for it, the harder it will be to replace
> it.  In particular I doubt the long-stalled session-variables patch
> could support such names, since it needs the names to conform to
> normal SQL rules.
>

If I understand correctly, session variables don't even intersect with
custom parameters.
Also, they seems to work fine with FQDN:
postgres=# create database testdb;
CREATE DATABASE
postgres=# \c testdb
You are now connected to database "testdb" as user "akukushkin".
testdb=# create schema testschema;
CREATE SCHEMA
testdb=# create variable testdb.testschema.testvar int;
CREATE VARIABLE
testdb=# let testdb.testschema.testvar = 1;
LET
testdb=# select testdb.testschema.testvar;
 testvar
---------
       1
(1 row)

Regards,
--
Alexander Kukushkin

--000000000000a5d69e060cee75bd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, 19 Dec 2023 at 16:13, Tom Lan=
e &lt;<a href=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>&gt; wrote:=
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
I wonder if we wouldn&#39;t be better advised to require exactly one dot.<b=
r>
This isn&#39;t a feature that we really encourage users to use, and the<br>
further we move the goalposts for it, the harder it will be to replace<br>
it.=C2=A0 In particular I doubt the long-stalled session-variables patch<br=
>
could support such names, since it needs the names to conform to<br>
normal SQL rules.<br></blockquote><div><br></div><div>If I understand corre=
ctly, session variables don&#39;t even intersect with custom parameters.</d=
iv><div>Also, they seems to work fine with FQDN:</div><div>postgres=3D# cre=
ate database testdb;<br>CREATE DATABASE<br>postgres=3D# \c testdb <br>You a=
re now connected to database &quot;testdb&quot; as user &quot;akukushkin&qu=
ot;.<br>testdb=3D# create schema testschema;<br>CREATE SCHEMA<br>testdb=3D#=
 create variable testdb.testschema.testvar int;<br>CREATE VARIABLE<br>testd=
b=3D# let testdb.testschema.testvar =3D 1;<br>LET<br>testdb=3D# select test=
db.testschema.testvar;<br>=C2=A0testvar <br>---------<br>=C2=A0 =C2=A0 =C2=
=A0 =C2=A01<br>(1 row)<br></div><div>=C2=A0</div></div><div dir=3D"ltr" cla=
ss=3D"gmail_signature"><div dir=3D"ltr"><div>Regards,</div><div>--</div><di=
v>Alexander Kukushkin<br></div></div></div></div>

--000000000000a5d69e060cee75bd--