MIME-Version: 1.0
References: <20220401.144430.1701887207072649814.horikyota.ntt@gmail.com>
 <20220401.155316.930989254339879136.horikyota.ntt@gmail.com>
 <CAAWbhmgU9mW7djrZ5S27WULMsnmuamE0F5SvQxSQsMaSz0s8qg@mail.gmail.com>
 <20220719.115506.1518451006264600540.horikyota.ntt@gmail.com>
 <20220912215156.zi52zu6n7od3k3v3@awork3.anarazel.de>
In-Reply-To: <20220912215156.zi52zu6n7od3k3v3@awork3.anarazel.de>
From: Dilip Kumar <dilipbalaut@gmail.com>
Date: Tue, 13 Sep 2022 07:00:42 +0530
Message-ID: 
 <CAFiTN-sSbpHAvDg7gyaN5J2aaYEF4ycaSEAz0qfUJD_gM7n-eA@mail.gmail.com>
Subject: Re: Error "initial slot snapshot too large" in create replication
 slot
To: Andres Freund <andres@anarazel.de>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, jchampion@timescale.com,
	y.sokolov@postgrespro.ru, rjuju123@gmail.com,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFiTN-sSbpHAvDg7gyaN5J2aaYEF4ycaSEAz0qfUJD_gM7n-eA%40mail.gmail.com>
Precedence: bulk

On Tue, Sep 13, 2022 at 3:22 AM Andres Freund <andres@anarazel.de> wrote:

>
> It's not obvious to me that it's the right design (or even correct) to ask
> reorderbuffer about an xid being a subxid. Maybe I'm missing something, but
> why would reorderbuffer even be guaranteed to know about all these subxids?

Yeah, you are right, the reorderbuffer will only know about the
transaction for which changes got added to the reorder buffer.  So
this seems not to be the right design idea.

>
> I wonder if a better fix here wouldn't be to allow importing a snapshot with a
> larger ->xid array. Yes, we can't do that in CurrentSnapshotData, but IIRC we
> need to be in a transactional snapshot anyway, which is copied anyway?

Yeah when I first found this issue, I thought that should be the
solution.  But later it went in a different direction.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com