Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE4za-0003Ag-RK for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Jan 2023 08:55:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pE4zY-0004ZY-1z for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Jan 2023 08:55:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE4zX-0004ZO-Od for pgsql-hackers@lists.postgresql.org; Sat, 07 Jan 2023 08:55:51 +0000 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pE4zU-0006vl-U6 for pgsql-hackers@lists.postgresql.org; Sat, 07 Jan 2023 08:55:51 +0000 Received: by mail-yb1-xb34.google.com with SMTP id c124so4140162ybb.13 for ; Sat, 07 Jan 2023 00:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Wpx2bDzHFVeenpfnFU/XtolD0EXKinNm0HXyklnud9o=; b=nQaBxGwHCGEDn1kBUlrWYPLx2Aq3Z6NkDDe5BAxQBSB3f4Ujt6m+Ia0gjtHPO2HNDF 6Gf5J60Auv+9IuKc68lqGQmwzM+Q6dXAlron74mmBF1DsUFmk6kTX1h7DmtKKXV+8WEI K8qVw/ANsqr0Rc+gnQSS+IurZgXZ60EMujRHYo2tvz1S84kZKdusx83JBAwYfzjsNT14 W8TdBolXwfIou6QbkGAmPmaBEN7yD3Xr30SSJEihsP537yUHBYq0h+yH/AWES5YOrig0 r5NHVa2QmSoCxuIuDOJlnesOy1yCnGIwqqo8TDRtJ2ylHCx8Hbey36C9jDg7gNUtQ4pM +AHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Wpx2bDzHFVeenpfnFU/XtolD0EXKinNm0HXyklnud9o=; b=MDaiC+5JJGFYcHUifquVfew4WkZrH9nSqpK+z6WpFwHWse1B+ueNqQLWcjxGTALrUY 9wIpin5PnjX7V/UT6k6Kgiy9BzDkynPmm47JyITDz9piRiNEVOMsWYQL5CTqyMUWuw7X yRB/dyVkoYdAjK37WEbZRR1IAOuuxRvKbgPGsV9R2LL+yTdSWHK09TjIX1oT3C3Cejgl Kk/Vpyj5X3QJ8lKSoIXYr0gyBqPMsoX4mONC8GOo/gXcMV828yOaIi2sm2Wiv9s3a7Xz 4xOFcM+J7DLf76vMnlpwfjLV+PDf0lP2lXOBDC4NkkGpaAgyrGqzyBXWlb5CC3epLvNJ Bqzg== X-Gm-Message-State: AFqh2kr8Xy08MLXIVB48oiNWZD2rYuwVwAo2N5kU7lb5MiJLiAb1YVL5 u1PNRQ8xM/YiRdemMoUn+iQ/OeFGeHM/lP67u8Q= X-Google-Smtp-Source: AMrXdXvxuUi5vhrJM0gmCWiRyIse7nySkzA2zdHXwg0ny1mBJtuQCZuUFFuEmwwtggD7IfZKlrH7BwaOQTt9LlxmZrI= X-Received: by 2002:a25:30b:0:b0:7af:35b5:e409 with SMTP id 11-20020a25030b000000b007af35b5e409mr1677489ybd.77.1673081747410; Sat, 07 Jan 2023 00:55:47 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dilip Kumar Date: Sat, 7 Jan 2023 14:25:31 +0530 Message-ID: Subject: Re: Perform streaming logical transactions by background workers and parallel apply To: "houzj.fnst@fujitsu.com" Cc: Amit Kapila , Masahiko Sawada , "wangw.fnst@fujitsu.com" , Peter Smith , "shiy.fnst@fujitsu.com" , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Jan 7, 2023 at 11:13 AM houzj.fnst@fujitsu.com wrote: > > On Saturday, January 7, 2023 12:50 PM Dilip Kumar > > > > On Fri, Jan 6, 2023 at 3:38 PM houzj.fnst@fujitsu.com > > wrote: > > > > > > > Looks good, but I feel in pa_process_spooled_messages_if_required() > > function after getting the filestate the first check should be if (filestate== > > FS_EMPTY) return false. I mean why to process through all the states if it is > > empty and we can directly exit. It is not a big deal so if you prefer the way it is > > then I have no objection to it. > > I think your suggestion looks good, I have adjusted the code. > I also rebase the patch set due to the recent commit c6e1f6. > And here is the new version patch set. > LGTM -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com