MIME-Version: 1.0
From: Dilip Kumar <dilipbalaut@gmail.com>
Date: Fri, 8 Nov 2024 15:17:04 +0530
Message-ID: <CAFiTN-tLrc-f042EGUtYHxenOASc0LhEWt4s9EOddi_JCDJeEA@mail.gmail.com>
Subject: Fix small typo, use InvalidRelFileNumber instead of InvalidOid
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000038cfe9062663a385"
Archived-At: <https://www.postgresql.org/message-id/CAFiTN-tLrc-f042EGUtYHxenOASc0LhEWt4s9EOddi_JCDJeEA%40mail.gmail.com>
Precedence: bulk

--00000000000038cfe9062663a385
Content-Type: multipart/alternative; boundary="00000000000038cfe7062663a383"

--00000000000038cfe7062663a383
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

It appears that we are passing InvalidOid instead of InvalidRelFileNumber
when calling index_create(). While this isn=E2=80=99t technically a bug, si=
nce
InvalidRelFileNumber is defined as InvalidOid, it=E2=80=99s preferable to u=
se the
correct identifier for clarity and consistency.

--=20
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

--00000000000038cfe7062663a383
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">It appears that we are passing <code>InvalidOid</code> ins=
tead of <code>InvalidRelFileNumber</code> when calling index_create(). Whil=
e this isn=E2=80=99t technically a bug, since <code>InvalidRelFileNumber</c=
ode> is defined as <code>InvalidOid,=C2=A0</code>it=E2=80=99s preferable to=
 use the correct identifier for clarity and consistency.<br clear=3D"all"><=
div><br></div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=
=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div =
dir=3D"ltr"><span style=3D"color:rgb(80,0,80);font-size:12.8px">Regards,</s=
pan><br style=3D"color:rgb(80,0,80);font-size:12.8px"><span style=3D"color:=
rgb(80,0,80);font-size:12.8px">Dilip Kumar</span><br style=3D"color:rgb(80,=
0,80);font-size:12.8px"><span style=3D"color:rgb(80,0,80);font-size:12.8px"=
>EnterpriseDB:=C2=A0</span><a href=3D"http://www.enterprisedb.com/" style=
=3D"color:rgb(17,85,204);font-size:12.8px" target=3D"_blank">http://www.ent=
erprisedb.com</a><br></div></div></div>

--00000000000038cfe7062663a383--
--00000000000038cfe9062663a385
Content-Type: application/octet-stream; 
	name="0001-Fix-typo-use-InvalidRelFileNumber-instead-of-Invalid.patch"
Content-Disposition: attachment; 
	filename="0001-Fix-typo-use-InvalidRelFileNumber-instead-of-Invalid.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m38jt90b0>
X-Attachment-Id: f_m38jt90b0

RnJvbSBlZjg5MzM3OWQwMGI5OGNlYTc4Mzc5ZDEyMWJmMzkxY2NhZmVkOWFkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWxpcCBLdW1hciA8ZGlsaXAua3VtYXJAZW50ZXJwcmlzZWRi
LmNvbT4KRGF0ZTogRnJpLCA4IE5vdiAyMDI0IDE1OjA5OjU0ICswNTMwClN1YmplY3Q6IFtQQVRD
SF0gRml4IHR5cG8sIHVzZSBJbnZhbGlkUmVsRmlsZU51bWJlciBpbnN0ZWFkIG9mIEludmFsaWRP
aWQKIHdoaWxlIHBhc3NpbmcgaW5wdXQgZm9yIFJlbEZpbGVOdW1iZXIuCgotLS0KIHNyYy9iYWNr
ZW5kL2NhdGFsb2cvdG9hc3RpbmcuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv
bigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvdG9h
c3RpbmcuYyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvdG9hc3RpbmcuYwppbmRleCBhZDMwODJjNjJh
Li5iNmIxNmJjOWZlIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jYXRhbG9nL3RvYXN0aW5nLmMK
KysrIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy90b2FzdGluZy5jCkBAIC0zMTksNyArMzE5LDcgQEAg
Y3JlYXRlX3RvYXN0X3RhYmxlKFJlbGF0aW9uIHJlbCwgT2lkIHRvYXN0T2lkLCBPaWQgdG9hc3RJ
bmRleE9pZCwKIAljb2xvcHRpb25zWzFdID0gMDsKIAogCWluZGV4X2NyZWF0ZSh0b2FzdF9yZWws
IHRvYXN0X2lkeG5hbWUsIHRvYXN0SW5kZXhPaWQsIEludmFsaWRPaWQsCi0JCQkJIEludmFsaWRP
aWQsIEludmFsaWRPaWQsCisJCQkJIEludmFsaWRPaWQsIEludmFsaWRSZWxGaWxlTnVtYmVyLAog
CQkJCSBpbmRleEluZm8sCiAJCQkJIGxpc3RfbWFrZTIoImNodW5rX2lkIiwgImNodW5rX3NlcSIp
LAogCQkJCSBCVFJFRV9BTV9PSUQsCi0tIAoyLjM5LjIgKEFwcGxlIEdpdC0xNDMpCgo=
--00000000000038cfe9062663a385--