Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wdIvw-0041EY-1U for pgsql-hackers@arkaria.postgresql.org; Sat, 27 Jun 2026 02:38:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wdIvv-00E169-1O for pgsql-hackers@arkaria.postgresql.org; Sat, 27 Jun 2026 02:38:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wdIvv-00E15u-04 for pgsql-hackers@lists.postgresql.org; Sat, 27 Jun 2026 02:38:15 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wdIvt-00000000Q54-06IY for pgsql-hackers@lists.postgresql.org; Sat, 27 Jun 2026 02:38:13 +0000 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5aeabb70d06so190341e87.2 for ; Fri, 26 Jun 2026 19:38:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782527891; cv=none; d=google.com; s=arc-20260327; b=AmHXD+ys1yZLUte5g3jlER1cjai2Ul2sSxSBi7bICm5+CS7fEL9eBoIgXIrqo1EVAU hu/Q0N11jagYYNWGXu7zLB5yzOZ4S/vn4nk75GUPFyTISG5tDOL4H/EwqAj1ADC/n4AL nN25MJX/3h0pkUUKiobeOB+XWOTrhm/0d6bZ0Q7Gw6+/lsCOHFVZ5Kj5bCs4zGP/frCk VuvPIrFGW8udUoxx71vpR7iBkzuAtIQZAAFU4EKkbpQnGLPM4RuHluXHyp8VvXaBy364 /Z2CdJnUESbHSJ8lGYJJluhiCjRbFqbm7JAQbgn7uUuHu5ly8aj14MNe2OIGSNSzzecY qytQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=08xPAvnNLlk9rHmzFJ5lJfnkq0RHH5A27CBxub5H1GQ=; fh=SlXw3fFGQna6hmXgJfBvZCcjiQ0+8pHgElxzW0XmfIU=; b=o7Ting3iOpBdPf6VdNRERHyjyqDcVgUQc2ObhZ/cp2vzBZPs599Wj3q6Ys8yTv2H2I QczydfISDwLjEh7TU0Tu3dZA8mJscuiwOJXMiS0gq0myqID4VpBkw0dZmCNnamP/PmOY xCtr9E1sBMkpCnnWYUX2G07NBtS4HDT/ZT7cU/A3chv+aPP5qRZRF2BbSKYq7nLENTBF moVmgw4ZHwKh05p3YE9SGtqMiO52CvR55b8JbOyT7p9j0i2LFx7Toblab3snWXO0pXqQ NpVgDsShV1S3ua1MOhLiP7MKrYvdGoGYApNpUUd5hlyBf5qlpHqdBtRklusTBPbljhvJ hpsw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782527891; x=1783132691; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=08xPAvnNLlk9rHmzFJ5lJfnkq0RHH5A27CBxub5H1GQ=; b=aCRvq5h6QZ3wmv+Lhje2T5UCMfzzfQgt5CGidx7w/kaL+3hYj77dbBmSzcaLi4/HXC hQQ95AWma8yv2uAT13OwbbxCfMOx1tC4hdTYvGxb5Ow3fi27N7VPrDGL1d7K6nAEmST+ OOiTof75Ew8GGXOpkamhuR5jMoNEJQrEEY0du7Z0sOHIxgSOaBFlMW7sJ4qpvZHBiMV7 FUmzOqioUYy3ItiEHfF+i/949b0zg39A21n49M76UiYGQLoUVbP80aXWEr5M1ojS0CWE ydZbOY87/gvuxKdoa1cOhulUChJcmTNK5N1MCYRh0GkKy2DM075beexKYJJXdOT6QndX ALyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782527891; x=1783132691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=08xPAvnNLlk9rHmzFJ5lJfnkq0RHH5A27CBxub5H1GQ=; b=Z3QM38rod8UenJxA0gkw4vFdQs+WXe3o84L93VVlQqn8QjfQ1x8rCgAio3RWRNYK8H KL5UAC+l74Px2rMROMJCNYFgmAzcRKoLCtnJQCeixmwiO4aXrJkaTOrRrdjjgbP1n1co AVdRxu1KJlcK8foktKKyISCGB1xTT6Sogab9jjGhhiUwHXBSIb1U2oPJpCVEK1jnTuym h7TD6p4TahcURKQ15mK35614ym2lrrRsl6ad4Hh/+uiiQCAEzrJIt8w882x7EVeuA7cR hpu06Uxj3eh+RrkgQHd9qckK9SF0RBNu0Gt6wvQHx6Hbq1e0hmoHwpnpEuCPHNT07Fhp emig== X-Forwarded-Encrypted: i=1; AHgh+RrP1qD4QY2HoNyhRAM9M6BpoIiDThIpv/rb/W3s8bGqY+GJczIBm59AH2CegjlPCdhm1/stpMtFcq4yyeVp@lists.postgresql.org X-Gm-Message-State: AOJu0YyINxWe5oGBhq3pPIzewpCmq884OtvLpXIACdIUrwW9fH19PhUK Qc9+h1LodE0gaHloXNNSTGOlCG+Ctjn2iIWpiQ8UxbFUVajJ38HUCclZGVn3oQVK9Bc+OP0bIr7 QFZlNAoD17oaHiceJS5YfrYo1uIKTV6Y= X-Gm-Gg: AfdE7cmwDIlfIEYVJFcUtjFhyGBw892dt6sMyAQQT7Q03it280TWPrldcLMrmZY9xqr HYhxQYK6TCQAUb6vVIs5uUh+RbY9nbqXRajUgP0zj0HsNpV3Nrg0YwwnPo+kA1TvP1NuUdrqB8J wHjsdqB2dtSztc89chywmxdR9gL/kOB2BYMAMAfFfs4+zll4lkzR4g2R9lQERy74SIK7nXBVvYN MCvqiPACf38Fl63NbU40vMnNNHk95E83yhlvDj0cNSYqWX8evI3eLKGb5nLWHyPPeQkNrCp8cYJ 19ukCeKzyyneyTfVOMvinh0WB+uQ4g== X-Received: by 2002:a05:6512:2514:b0:5aa:780b:f341 with SMTP id 2adb3069b0e04-5aea1f51ed4mr2920725e87.35.1782527891283; Fri, 26 Jun 2026 19:38:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dilip Kumar Date: Sat, 27 Jun 2026 08:07:51 +0530 X-Gm-Features: AVVi8Cca8aGOiRgNvk3hv5NFOkjQ9kU0gfFPNHGUxMpdL3hCrH8zbIbBsDDe0HM Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Nisha Moond Cc: vignesh C , Amit Kapila , shveta malik , Peter Smith , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jun 25, 2026 at 8:01=E2=80=AFPM Nisha Moond wrote: > > On Wed, Jun 24, 2026 at 7:26=E2=80=AFPM Dilip Kumar wrote: > > > > Please find the updated patch set attached. > > Hi Dilip, > > I ran a code coverage report on v56-0001 and v56-0002 and found a few > cases not covered by existing tests. I added tests for the following: > > 1) check_publication_add_relation() =E2=80=93 verify that adding a confli= ct > table to a publication errors out > 2) execMain.c: CheckValidRowMarkRel() =E2=80=93 verify row locking on CLT= is > rejected for commands like SELECT ... FOR UPDATE > 3) The test scenario shared by Shveta at [1] > > Please consider the patch if you are okay with it. The patch applies > cleanly on top of latest v58-0002 patch, > > [1] https://www.postgresql.org/message-id/CAJpy0uC5x%2BZ%3Dfvurvz%3DK8EYQ= SCQ1SCouR2LqiHS27Hp_Tzi6qw%40mail.gmail.com Thanks Nisha. I have merged your changes. --=20 Regards, Dilip Kumar Google