MIME-Version: 1.0
References: <5DED17B4-D948-4C0B-9DE1-A915D0BFAA54@gmail.com>
In-Reply-To: <5DED17B4-D948-4C0B-9DE1-A915D0BFAA54@gmail.com>
From: Dilip Kumar <dilipbalaut@gmail.com>
Date: Thu, 5 Feb 2026 09:32:49 +0530
Message-ID: <CAFiTN-v2y0AV5YNeG5aTaupi_5+HKGw-gXtFuV3ixYpqSW_iwQ@mail.gmail.com>
Subject: Re: pg_upgrade: fix memory leak in SLRU I/O code
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAFiTN-v2y0AV5YNeG5aTaupi_5%2BHKGw-gXtFuV3ixYpqSW_iwQ%40mail.gmail.com>
Precedence: bulk

On Wed, Feb 4, 2026 at 2:51=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wro=
te:
>
> Hi Hackers,
>
> This comes from a previous review and has been on my to-do list for a whi=
le.
>
> Since src/bin/pg_upgrade/slru_io.c includes postgres_fe.h, it is frontend=
 code, so backend memory contexts are not used here.
>
> In the current code:
> ```
> void
> FreeSlruWrite(SlruSegState *state)
> {
>         Assert(state->writing);
>
>         SlruFlush(state);
>
>         if (state->fd !=3D -1)
>                 close(state->fd);
>         pg_free(state);
> }
> ```
>
> the SlruSegState itself is freed, but state->dir and state->fn are not, w=
hich results in a memory leak during pg_upgrade runs. More generally, I don=
=E2=80=99t see a reason to free an object itself without also freeing the m=
emory owned by its members.
>
> While looking at this, I also noticed that state->dir is allocated using =
pstrdup(). To better align with frontend conventions, the patch switches th=
is to pg_strdup() and introduces a common cleanup helper to free all resour=
ces associated with SlruSegState.
>
> See the attached patch.

The patch LGTM, just one suggestion, adds a one liner comment over the
new function[1] for consistency.

[1]
+static void
+FreeSlruSegState(SlruSegState *state)
+{
+ if (state->fd !=3D -1)
+ close(state->fd);
+
+ pg_free(state->fn);
+ pg_free(state->dir);
+ pg_free(state);
+}

--=20
Regards,
Dilip Kumar
Google