public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dilip Kumar <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Ryo Matsumura (Fujitsu) <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy
Date: Thu, 16 Feb 2023 12:31:54 +0530
Message-ID: <CAFiTN-vHa7RoAuk4yG_t=z+dnN4B64a0s-TCYBnM-LrbrE-QMg@mail.gmail.com> (raw)
In-Reply-To: <20230216064120.GA2016097@nathanxps13>
References: <TYCPR01MB6868677E499C9AD5123084B5E8A39@TYCPR01MB6868.jpnprd01.prod.outlook.com>
<20230216000659.GA1932550@nathanxps13>
<CAFiTN-tEAaq6csi_6TB8sz=5ZV=XjhneUB0x5icfK8b3TLn+Xw@mail.gmail.com>
<Y+2+n4FuE6K5/[email protected]>
<20230216064120.GA2016097@nathanxps13>
On Thu, Feb 16, 2023 at 12:11 PM Nathan Bossart
<[email protected]> wrote:
>
> On Thu, Feb 16, 2023 at 02:26:55PM +0900, Michael Paquier wrote:
> > So, if I am understanding this stuff right, this issue can create data
> > corruption once a DDL updates any pages of pg_class stored in a
> > template database that gets copied by this routine. In this case, the
> > patch sent makes sure that any page copied will get written once a
> > checkpoint kicks in. Shouldn't we have at least a regression test for
> > such a scenario? The issue can happen when updating a template
> > database after creating a database from it, which is less worrying
> > than the initial impression I got, still I'd like to think that we
> > should have some coverage as of the special logic this code path
> > relies on for pg_class when reading its buffers.
>
> I was able to quickly hack together a TAP test that seems to reliably fail
> before the fix and pass afterwards. There's probably a better place for
> it, though...
I think the below change is not relevant to this bug right?
diff --git a/src/test/recovery/meson.build b/src/test/recovery/meson.build
index 209118a639..6e9f8a7c7f 100644
--- a/src/test/recovery/meson.build
+++ b/src/test/recovery/meson.build
@@ -39,6 +39,7 @@ tests += {
't/031_recovery_conflict.pl',
't/032_relfilenode_reuse.pl',
't/033_replay_tsp_drops.pl',
+ 't/100_bugs.pl',
],
},
}
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
view thread (16+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy
In-Reply-To: <CAFiTN-vHa7RoAuk4yG_t=z+dnN4B64a0s-TCYBnM-LrbrE-QMg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox