MIME-Version: 1.0
References: 
 <CAJcOf-eciNBeRYMVVV1sbhjTQ-SXVnz1tdwkR3B24bAuBMpEZA@mail.gmail.com>
 <202107162135.m5ehijgcasjk@alvherre.pgsql>
 <CAA4eK1+79JVQ7dZqAE+0pc0f-AZn4J_F2X3nLdctGcAtcMp6Ew@mail.gmail.com>
 <CAFiTN-tZ6TT+hJt-MKwtumx62r1wnAVdDDuFyNNA==kLTsVgjQ@mail.gmail.com>
 <fb7a3099-1232-17d4-dd45-a2d42d780b1e@enterprisedb.com>
 <CAA4eK1+3=w++VOY5Z6VMeh1OLs9N+A3nwL+dUEuLgxGx2K-4Rg@mail.gmail.com>
 <ace1bc6e-f763-1791-2371-1d88c977441f@enterprisedb.com>
 <CAA4eK1Kp8TZ7PqzJBYMhfbQ+62wpYRh_E6eLSPAn=xsCEvOCOg@mail.gmail.com>
 <acf0ba6e-1add-75da-a989-8e8fd82253e0@enterprisedb.com>
 <CAFiTN-tXP32y4bUcaXQsa4_RkkEiQDaP-c0nFrzD5p3aqHX6sg@mail.gmail.com>
 <CAA4eK1+Z+Z4OUs8z1LsxYU4NAKJAy7PatV8x48HBeuN9Gk2b-A@mail.gmail.com>
 <CAFiTN-th7fSa+8AqHp5K081tWwHj2HGbLxdC0=JtJ2bS7pQNqA@mail.gmail.com>
 <CAA4eK1L18BTAw9ziyUyeOj=Dj9oC45w291=sPYm1K=NCHffTug@mail.gmail.com>
 <CAA4eK1Lp5gnVXToE806VOn1m_Z5XQZcLwcUO3-ddGvyajXcrEg@mail.gmail.com>
 <CAH2L28sPm=o09FGPzS4MTfAunyNLJA8HHPGrhyGEBrQhix5eHg@mail.gmail.com>
 <CAA4eK1LOwT2Mog=f0e6y2Nd3FKjmFMRRdtR0GEr9jDBHYKS29w@mail.gmail.com>
 <OS0PR01MB571618736E7E79309A723BBE94E99@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAFiTN-sE0W0WQMvz5+5D+V=cvZ-RD=nTBc8+fDvDWXB=hp9z-A@mail.gmail.com>
 <CAA4eK1JLQqNZypOpN7h3=Vt0JJW4Yb_FsLJS=T8J9J-WXgFMYg@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1JLQqNZypOpN7h3=Vt0JJW4Yb_FsLJS=T8J9J-WXgFMYg@mail.gmail.com>
From: Dilip Kumar <dilipbalaut@gmail.com>
Date: Mon, 9 Aug 2021 18:12:52 +0530
Message-ID: 
 <CAFiTN-vQ0OSmAVd7++HFCrFe2ohnDD5wBbySTeHxDu2YVKOUug@mail.gmail.com>
Subject: Re: row filtering for logical replication
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Greg Nancarrow <gregn4422@gmail.com>,
	Euler Taveira <euler@eulerto.com>, Peter Smith <smithpb2250@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	=?UTF-8?B?w5ZuZGVyIEthbGFjxLE=?= <onderkalaci@gmail.com>,
	japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>,
	David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Amit Langote <amitlangote09@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Rahila Syed <rahilasyed90@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFiTN-vQ0OSmAVd7%2B%2BHFCrFe2ohnDD5wBbySTeHxDu2YVKOUug%40mail.gmail.com>
Precedence: bulk

On Tue, Aug 3, 2021 at 4:25 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Jul 27, 2021 at 9:56 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> > Yeah, that's a big problem, seems like the expression evaluation
> > machinery directly going and detoasting the externally stored data
> > using some random snapshot.  Ideally, in walsender we can never
> > attempt to detoast the data because there is no guarantee that those
> > data are preserved.  Somehow before going to the expression evaluation
> > machinery, I think we will have to deform that tuple and need to do
> > something for the externally stored data otherwise it will be very
> > difficult to control that inside the expression evaluation.
> >
>
> True, I think it would be possible after we fix the issue reported in
> another thread [1] where we will log the key values as part of
> old_tuple_key for toast tuples even if they are not changed. We can
> have a restriction that in the WHERE clause that user can specify only
> Key columns for Updates similar to Deletes. Then, we have the data
> required for filter columns basically if the toasted key values are
> changed, then they will be anyway part of the old and new tuple and if
> they are not changed then they will be part of the old tuple.

Right.

 I have
> not checked the implementation part of it but theoretically, it seems
> possible.

Yeah, It would be possible to because at least after fixing [1] we
would have the required column data.  The only thing I am worried
about is while applying the filter on the new tuple the toasted
unchanged key data will not be a part of the new tuple.  So we can not
directly call the expression evaluation machinary, basically, somehow
we need to deform the new tuple and then replace the data from the old
tuple before passing it to expression evaluation.  Anyways this is an
implementation part so we can look into that while implementing.

 If my understanding is correct then it becomes necessary to
> solve the other bug [1] to solve this part of the problem for this
> patch.

Right.

The other possibility is to disallow columns (datatypes) that
> can lead to toasted data (at least for Updates) which doesn't sound
> like a good idea to me.

Yeah, that will be a big limitation, then we won't be able to allow
expression on any varlena types.

 Do you have any other ideas for this problem?

As of now no other better idea to suggest.

[1] - https://www.postgresql.org/message-id/OS0PR01MB611342D0A92D4F4BF26C0F47FB229%40OS0PR01MB6113.jpnprd01.prod.outlook.com


-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com