MIME-Version: 1.0
References: <CAMsGm5eqKc6J1=Lwn=ZONG=6ZDYWRQ4cgZQLqMuZGB1aVt_JBg@mail.gmail.com>
 <CAFj8pRB4zPJsKR5kESHSXHE-u=g89CuLHuAh0CzojEHBFLv=FQ@mail.gmail.com> <CABUevEwnePrw2kqdyasx5q2eFhbm1u=xpXPU1i+iNa3EOk7mtA@mail.gmail.com>
In-Reply-To: <CABUevEwnePrw2kqdyasx5q2eFhbm1u=xpXPU1i+iNa3EOk7mtA@mail.gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
Date: Wed, 11 Jan 2023 18:30:40 +0100
Message-ID: <CAFj8pRA7rYzNXhx2MJbEsdZEmKvPjjsRC0b0rH81iLpEYwVf+A@mail.gmail.com>
Subject: Re: Remove source code display from \df+?
To: Magnus Hagander <magnus@hagander.net>
Cc: Isaac Morland <isaac.morland@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000022d6ec05f2005e8d"
Archived-At: <https://www.postgresql.org/message-id/CAFj8pRA7rYzNXhx2MJbEsdZEmKvPjjsRC0b0rH81iLpEYwVf%2BA%40mail.gmail.com>
Precedence: bulk

--00000000000022d6ec05f2005e8d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

st 11. 1. 2023 v 18:25 odes=C3=ADlatel Magnus Hagander <magnus@hagander.net=
>
napsal:

>
>
> On Wed, Jan 11, 2023 at 6:19 PM Pavel Stehule <pavel.stehule@gmail.com>
> wrote:
>
>>
>>
>> st 11. 1. 2023 v 17:50 odes=C3=ADlatel Isaac Morland <isaac.morland@gmai=
l.com>
>> napsal:
>>
>>> I find \df+ much less useful than it should be because it tends to be
>>> cluttered up with source code. Now that we have \sf, would it be reason=
able
>>> to remove the source code from the \df+ display? This would make it eas=
ier
>>> to see function permissions and comments. If somebody wants to see the =
full
>>> definition of a function they can always invoke \sf on it.
>>>
>>> If there is consensus on the idea in principle I will write up a patch.
>>>
>>
>> +1
>>
>>
> +1 but maybe with a twist. For any functions in a procedural language lik=
e
> plpgsql, it makes it pretty useless today. But when viewing an internal o=
r
> C language function, it's short enough and still actually useful. Maybe
> some combination where it would keep showing those for such language, but
> would show "use \sf to view source" for procedural languages?
>

yes, it is almost necessary for C functions or functions in external
languages. Maybe it can be specified in pg_language if prosrc is really
source code or some reference.


> --
>  Magnus Hagander
>  Me: https://www.hagander.net/ <http://www.hagander.net/>
>  Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
>

--00000000000022d6ec05f2005e8d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">st 11. 1. 2023 v=C2=A018:25 odes=C3=
=ADlatel Magnus Hagander &lt;<a href=3D"mailto:magnus@hagander.net">magnus@=
hagander.net</a>&gt; napsal:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"=
gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jan 11, 2023 at =
6:19 PM Pavel Stehule &lt;<a href=3D"mailto:pavel.stehule@gmail.com" target=
=3D"_blank">pavel.stehule@gmail.com</a>&gt; wrote:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></=
div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">st=
 11. 1. 2023 v=C2=A017:50 odes=C3=ADlatel Isaac Morland &lt;<a href=3D"mail=
to:isaac.morland@gmail.com" target=3D"_blank">isaac.morland@gmail.com</a>&g=
t; napsal:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div =
dir=3D"ltr">I find \df+ much less useful than it should=C2=A0be because it =
tends to be cluttered up with source code. Now that we have \sf, would it b=
e reasonable to remove the source code from the \df+ display? This would ma=
ke it easier to see function permissions and comments. If somebody wants to=
 see the full definition of a function they can always invoke \sf on it.<di=
v><br></div><div>If there is consensus on the idea in principle I will writ=
e up a patch.</div></div></blockquote><div><br></div><div>+1</div><div><br>=
</div></div></div></blockquote><div><br></div><div>+1 but maybe with a twis=
t. For any functions in a procedural language like plpgsql, it makes it pre=
tty useless today. But when viewing an internal or C language function, it&=
#39;s short enough and still actually useful. Maybe some combination where =
it would keep showing those for such language, but would show &quot;use \sf=
 to view source&quot; for procedural languages?<br></div></div></div></bloc=
kquote><br></div><div class=3D"gmail_quote">yes, it is almost necessary for=
 C functions or functions in external languages. Maybe it can be specified =
in pg_language if prosrc is really source code or some reference.</div><div=
 class=3D"gmail_quote"><br></div><div class=3D"gmail_quote"><br></div><div =
class=3D"gmail_quote"><br></div><div class=3D"gmail_quote"><br><div><br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div =
class=3D"gmail_quote"><div></div><div>=C2=A0</div></div>-- <br><div dir=3D"=
ltr"><div dir=3D"ltr"><div>=C2=A0Magnus Hagander<br>=C2=A0Me: <a href=3D"ht=
tp://www.hagander.net/" target=3D"_blank">https://www.hagander.net/</a><br>=
=C2=A0Work: <a href=3D"http://www.redpill-linpro.com/" target=3D"_blank">ht=
tps://www.redpill-linpro.com/</a></div></div></div></div>
</blockquote></div></div>

--00000000000022d6ec05f2005e8d--