MIME-Version: 1.0
References: <CAKAnmmKVwP=yr8t8p8_QtrBFjyENLZyPxscJh4UrkCeqMQuhrw@mail.gmail.com>
 <1619826.1767732539@sss.pgh.pa.us>
In-Reply-To: <1619826.1767732539@sss.pgh.pa.us>
From: Pavel Stehule <pavel.stehule@gmail.com>
Date: Wed, 7 Jan 2026 05:58:32 +0100
Message-ID: <CAFj8pRDN7dtu3LdMtgmsayJkOKyOOT57oh=JQ-J_rH69V5e6TQ@mail.gmail.com>
Subject: Re: [PATCH] Provide support for trailing commas
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Sabino Mullane <htamfids@gmail.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000012689b0647c527f9"
Archived-At: <https://www.postgresql.org/message-id/CAFj8pRDN7dtu3LdMtgmsayJkOKyOOT57oh%3DJQ-J_rH69V5e6TQ%40mail.gmail.com>
Precedence: bulk

--00000000000012689b0647c527f9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=C3=BAt 6. 1. 2026 v 21:49 odes=C3=ADlatel Tom Lane <tgl@sss.pgh.pa.us> nap=
sal:

> Greg Sabino Mullane <htamfids@gmail.com> writes:
> > Happy New Year! Please find attached a patch to provide comprehensive
> > trailing comma support, where we allow (when possible) a comma that doe=
s
> > NOT come before the next item in a list. To wit:
>
> > SELECT 1,2,3, FROM pg_class, ORDER BY greatest(relpages,1,);
>
> Did we not discuss and reject this very idea in the past?
> A quick search finds [1][2], and there may be more threads.
>
> > This is not as trivial a task as it seems, as those who have dabbled wi=
th
> > our parser (or parsers in general) may suspect.
>
> Indeed.  I think it carries substantial risk of creating large parsing
> problems down the road, when we try to integrate whatever random
> syntax the SQL committee comes up with next.  And frankly, I don't
> agree that it'd be beneficial.
>

+1

Pavel


>
>                         regards, tom lane
>
> [1]
> https://www.postgresql.org/message-id/flat/20140928114246.GA22150%40artax=
.karlin.mff.cuni.cz
> [2]
> https://www.postgresql.org/message-id/flat/0368c60f-abe2-4f5f-972d-7cd1e6=
db2382%40gmail.com
>
>
>

--00000000000012689b0647c527f9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">=C3=BAt 6. 1. 2=
026 v=C2=A021:49 odes=C3=ADlatel Tom Lane &lt;<a href=3D"mailto:tgl@sss.pgh=
.pa.us">tgl@sss.pgh.pa.us</a>&gt; napsal:<br></div><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">Greg Sabino Mullane &lt;<a href=3D"mailto:htamfid=
s@gmail.com" target=3D"_blank">htamfids@gmail.com</a>&gt; writes:<br>
&gt; Happy New Year! Please find attached a patch to provide comprehensive<=
br>
&gt; trailing comma support, where we allow (when possible) a comma that do=
es<br>
&gt; NOT come before the next item in a list. To wit:<br>
<br>
&gt; SELECT 1,2,3, FROM pg_class, ORDER BY greatest(relpages,1,);<br>
<br>
Did we not discuss and reject this very idea in the past?<br>
A quick search finds [1][2], and there may be more threads.<br>
<br>
&gt; This is not as trivial a task as it seems, as those who have dabbled w=
ith<br>
&gt; our parser (or parsers in general) may suspect.<br>
<br>
Indeed.=C2=A0 I think it carries substantial risk of creating large parsing=
<br>
problems down the road, when we try to integrate whatever random<br>
syntax the SQL committee comes up with next.=C2=A0 And frankly, I don&#39;t=
<br>
agree that it&#39;d be beneficial.<br></blockquote><div><br></div><div>+1</=
div><div><br></div><div>Pavel</div><div>=C2=A0</div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex">
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 regards, tom lane<br>
<br>
[1] <a href=3D"https://www.postgresql.org/message-id/flat/20140928114246.GA=
22150%40artax.karlin.mff.cuni.cz" rel=3D"noreferrer" target=3D"_blank">http=
s://www.postgresql.org/message-id/flat/20140928114246.GA22150%40artax.karli=
n.mff.cuni.cz</a><br>
[2] <a href=3D"https://www.postgresql.org/message-id/flat/0368c60f-abe2-4f5=
f-972d-7cd1e6db2382%40gmail.com" rel=3D"noreferrer" target=3D"_blank">https=
://www.postgresql.org/message-id/flat/0368c60f-abe2-4f5f-972d-7cd1e6db2382%=
40gmail.com</a><br>
<br>
<br>
</blockquote></div></div>

--00000000000012689b0647c527f9--