Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfeXt-003nQs-23 for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jan 2026 13:34:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vfeXs-004vhq-2C for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jan 2026 13:34:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfeXs-004vhh-0s for pgsql-hackers@lists.postgresql.org; Tue, 13 Jan 2026 13:34:52 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfeXo-000E3x-1B for pgsql-hackers@postgresql.org; Tue, 13 Jan 2026 13:34:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768311286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tKM1/2aXvGQrLnaScFmuoIhNWRbJSvqo0L/HrIgYunQ=; b=LNsdaSvk4nL3e5+X9ydw/RmgBGSQOQew2cl/lZ2DfGZ6mG+/JnPhP01oNSEGqHnuhZsB7l /nnOfg2mAjZVlmlz0LJq2IlvXlJJmEpT5YUsTkTHpUaTWIo1Wwl/y+ZZKkmDx6K3+85d4N OWr9lE27fVYZUfiXWc7Qyl7t/qI4gr4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-p3TUuzCdOt6uVkqOaCsXLw-1; Tue, 13 Jan 2026 08:34:44 -0500 X-MC-Unique: p3TUuzCdOt6uVkqOaCsXLw-1 X-Mimecast-MFC-AGG-ID: p3TUuzCdOt6uVkqOaCsXLw_1768311283 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-64ba73e83c9so11737395a12.2 for ; Tue, 13 Jan 2026 05:34:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768311283; x=1768916083; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tKM1/2aXvGQrLnaScFmuoIhNWRbJSvqo0L/HrIgYunQ=; b=wMcoNM0dsqz1lBMteRdU0iqaa9n6sTH4pddkLTWtQ8XkG24PH48odwo8mcwtEwm3og 3pPiE+167HGM3IqVxDn00o05SDSRvq9YwVPP2rQtGSZ51hciThSrwOpfRuHJume/RTUI zFw5JvSc36MdKFp5EOSqRqMtZT2xkVN9X7EkCXYKZNMcA5+NHQp4za4s4YPRE0WX/fdJ 9xrpZyFyVT1PF1Zl889S78Jyj2uIXnns+spLkc5V/Of9wBp/uEElU/yeteyjNCUPsaUr SqVGQBIzf8exZsPjuraRtRFz05DOUw10heNTakHrlRBOztKRBHJ5ZVKI2tMF/33xJJsv Chmw== X-Gm-Message-State: AOJu0YztlmqRsUYIesIOfNuw1QFPAUf111ULacd10BRkekdmclYuKfsK kRPmcTEcyDKSQ/+B625xTEbqpAad+cS6tAYRX5B9HMRM2ZcC4MjjTPArK75XwnEdwUpbSO0588M R9avh9L75ccrSvJdY85j8/ykvAMXsvxHaFjROorThgNvjtmUCbAQtp2y2r0T2HHjHogiJV8VioT kOrbAm4FhHY9uOKeUF4cFgVSDezJv486q2vd2uzwFp X-Gm-Gg: AY/fxX4udxeHEd5MT5kaV4LCZIwpmknhShasWwtOMSUE/DdbzSIo635sI6kno6DZYYu EYmNmXpTplg+tskVYKGBMOxxmsrRFcOLhqoYDGuGD6e/vRapadNBT+lIlO/th23crFTPTlumGGG YNd6E9NDBQJt9WTUIUSxbUhjDYCdKyNvKJyJYKE0iozdmtkvXW01swTYckqmhDCgRM3Q== X-Received: by 2002:a05:6402:50cc:b0:649:cb54:b7a9 with SMTP id 4fb4d7f45d1cf-65097e47186mr17950057a12.21.1768311283116; Tue, 13 Jan 2026 05:34:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJtmzBfWWkgU9KE/oOdqOQ0ZA9+9QfdrGs79nq9U3d0NiBAYqIfa4rv/XrRnEba5xUabLTDaOtTX+cwRf/jck= X-Received: by 2002:a05:6402:50cc:b0:649:cb54:b7a9 with SMTP id 4fb4d7f45d1cf-65097e47186mr17950050a12.21.1768311282707; Tue, 13 Jan 2026 05:34:42 -0800 (PST) MIME-Version: 1.0 References: <7bcc0420-d457-4af5-a459-a4e5d929a665@vondra.me> <7gbzkoxrpqvj2sgxof4pqirz7pf6wb5vizak3mxrz2zpvrf3pa@lvnwdsy3em56> In-Reply-To: From: Filip Janus Date: Tue, 13 Jan 2026 14:34:31 +0100 X-Gm-Features: AZwV_Qg8gJcgr4zNBEE1iT58bI0-YWFBdkA9YSgzLIMnIK7IePbvOk3YzzMGv3k Message-ID: Subject: Re: Proposal: Adding compression of temporary files To: lakshmi Cc: pgsql-hackers@postgresql.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HS99RV3PUe31cH4FGI2or6fCytX29b6c4g5nA2Wgl_c_1768311283 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000dbd7790648450d25" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000dbd7790648450d25 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Yes, it needs to be rebased. I am working on it. I will post it here soon. -Filip- =C3=BAt 13. 1. 2026 v 13:51 odes=C3=ADlatel lakshmi napsal: > Hi all, > I tried to replicate the temporary file compression issue by applying the > two patches shared in the thread on current PostgreSQL master. > here is what i observed, > 1) patch 1:0001-Add-transparent-compression-for-temporary-files.patch > when applying the first patch it ultimately fails to apply due to context > mismatches. > > failures i see are in the following files: > src/backend/storage/file/buffile.c > src/backend/utils/misc/guc_tables.c > src/backend/utils/misc/postgresql.conf.sample > > 2) The second > patch 0002-Add-regression-tests-for-temporary-file-compression.patch > ,applies successfully without any issues. > > Does it mean that the implementation patch needs to be rebased or > otherwise adjusted for the current codebase, and if so, what would be the > recommended way to proceed?could you please suggest how I should apply th= e > implementation patch in this case? > > > regards > lakshmi > > On Tue, Jan 13, 2026 at 5:01=E2=80=AFPM Filip Janus w= rote: > >> Rebase after changes introduced in guc_tables.c >> >> -Filip- >> >> >> =C3=BAt 19. 8. 2025 v 17:48 odes=C3=ADlatel Filip Janus napsal: >> >>> Fix overlooked compiler warnings >>> >>> -Filip- >>> >>> >>> po 18. 8. 2025 v 18:51 odes=C3=ADlatel Filip Janus >>> napsal: >>> >>>> I rebased the proposal and fixed the problem causing those problems. >>>> >>>> -Filip- >>>> >>>> >>>> =C3=BAt 17. 6. 2025 v 16:49 odes=C3=ADlatel Andres Freund >>>> napsal: >>>> >>>>> Hi, >>>>> >>>>> On 2025-04-25 23:54:00 +0200, Filip Janus wrote: >>>>> > The latest rebase. >>>>> >>>>> This often seems to fail during tests: >>>>> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5382 >>>>> >>>>> E.g. >>>>> >>>>> https://api.cirrus-ci.com/v1/artifact/task/4667337632120832/testrun/b= uild-32/testrun/recovery/027_stream_regress/log/regress_log_027_stream_regr= ess >>>>> >>>>> =3D=3D=3D dumping >>>>> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/dat= a/regression.diffs >>>>> =3D=3D=3D >>>>> diff -U3 >>>>> /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out >>>>> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/dat= a/results/join_hash_pglz.out >>>>> --- /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out >>>>> 2025-05-26 05:04:40.686524215 +0000 >>>>> +++ >>>>> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/dat= a/results/join_hash_pglz.out >>>>> 2025-05-26 05:15:00.534907680 +0000 >>>>> @@ -594,11 +594,8 @@ >>>>> select count(*) from join_foo >>>>> left join (select b1.id, b1.t from join_bar b1 join join_bar b2 >>>>> using (id)) ss >>>>> on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1; >>>>> - count >>>>> -------- >>>>> - 3 >>>>> -(1 row) >>>>> - >>>>> +ERROR: could not read from temporary file: read only 8180 of 157286= 0 >>>>> bytes >>>>> +CONTEXT: parallel worker >>>>> select final > 1 as multibatch >>>>> from hash_join_batches( >>>>> $$ >>>>> @@ -606,11 +603,7 @@ >>>>> left join (select b1.id, b1.t from join_bar b1 join join_bar b2 >>>>> using (id)) ss >>>>> on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1; >>>>> $$); >>>>> - multibatch >>>>> ------------- >>>>> - t >>>>> -(1 row) >>>>> - >>>>> +ERROR: current transaction is aborted, commands ignored until end o= f >>>>> transaction block >>>>> rollback to settings; >>>>> -- single-batch with rescan, parallel-oblivious >>>>> savepoint settings; >>>>> >>>>> >>>>> Greetings, >>>>> >>>>> Andres >>>>> >>>>> >>>>> --000000000000dbd7790648450d25 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,=C2=A0
Yes, it needs to be rebased. I am= working on it. I will post it here soon.
=C2=A0

=C2=A0 =C2= =A0 -Filip-


=C3=BAt = 13. 1. 2026 v=C2=A013:51 odes=C3=ADlatel lakshmi <lakshmigcdac@gmail.com> napsal:
Hi all,
I tr= ied to replicate the temporary file compression issue by applying the two p= atches shared in the thread on current PostgreSQL master.
here is what i= observed,
1) patch 1:0001-Add-transparent-compression-for-temporary-fil= es.patch
when applying the first patch it ultimately fails to apply due = to context mismatches.

failures i see are in the following files:src/backend/storage/file/buffile.c
src/backend/utils/misc/guc_tables.c
src/backend/utils/misc/postgresql.conf.sample

2) The second patc= h=C2=A00002-Add-regression-tests-for-temporary-file-compression.patch ,appl= ies successfully without any issues.

Does it mean that the impl= ementation patch needs to be rebased or otherwise adjusted for the current = codebase, and if so, what would be the recommended way to proceed?could you= please suggest how I should apply the implementation patch in this case?

regards
lakshmi

On Tue, Jan 13, 2026 at 5:01=E2=80=AFPM F= ilip Janus <fjanu= s@redhat.com> wrote:
Rebase after changes=C2=A0introduced in g= uc_tables.c

=C2=A0 =C2=A0 -Fi= lip-


=
=C3=BAt 19. 8. 2025 v=C2=A017:48 odes= =C3=ADlatel Filip Janus <fjanus@redhat.com> napsal:
Fix overlooked compiler war= nings=C2=A0

=C2=A0 =C2=A0 -Fi= lip-


=
po 18. 8. 2025 v=C2=A018:51 odes=C3= =ADlatel Filip Janus <fjanus@redhat.com> napsal:
I rebased the proposal and fix= ed=C2=A0the problem causing those problems.

=C2=A0 =C2=A0 -Filip-

<= br>
=C3=BAt= 17. 6. 2025 v=C2=A016:49 odes=C3=ADlatel Andres Freund <andres@anarazel.de> napsal:=
Hi,

On 2025-04-25 23:54:00 +0200, Filip Janus wrote:
> The latest rebase.

This often seems to fail during tests:
https://cirrus-ci.com/github/postg= resql-cfbot/postgresql/cf%2F5382

E.g.
https://api.cirrus-ci.com/v1= /artifact/task/4667337632120832/testrun/build-32/testrun/recovery/027_strea= m_regress/log/regress_log_027_stream_regress

=3D=3D=3D dumping /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream= _regress/data/regression.diffs =3D=3D=3D
diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out = /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/resu= lts/join_hash_pglz.out
--- /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out=C2=A0= =C2=A02025-05-26 05:04:40.686524215 +0000
+++ /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/= results/join_hash_pglz.out=C2=A0 =C2=A02025-05-26 05:15:00.534907680 +0000<= br> @@ -594,11 +594,8 @@
=C2=A0select count(*) from join_foo
=C2=A0 =C2=A0left join (select b1.id, b1.t from join_bar b1 join join_bar b2 using (= id)) ss
=C2=A0 =C2=A0on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1;
- count
--------
-=C2=A0 =C2=A0 =C2=A03
-(1 row)
-
+ERROR:=C2=A0 could not read from temporary file: read only 8180 of 1572860= bytes
+CONTEXT:=C2=A0 parallel worker
=C2=A0select final > 1 as multibatch
=C2=A0 =C2=A0from hash_join_batches(
=C2=A0$$
@@ -606,11 +603,7 @@
=C2=A0 =C2=A0 =C2=A0left join (select b1.id, b1.t from join_bar b1 join join_bar b2 = using (id)) ss
=C2=A0 =C2=A0 =C2=A0on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1;
=C2=A0$$);
- multibatch
-------------
- t
-(1 row)
-
+ERROR:=C2=A0 current transaction is aborted, commands ignored until end of= transaction block
=C2=A0rollback to settings;
=C2=A0-- single-batch with rescan, parallel-oblivious
=C2=A0savepoint settings;


Greetings,

Andres


--000000000000dbd7790648450d25--