public inbox for [email protected]
help / color / mirror / Atom feedRe: Change default of jit to off
16+ messages / 9 participants
[nested] [flat]
* Re: Change default of jit to off
@ 2026-02-03 10:29 Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Christoph Berg @ 2026-02-03 10:29 UTC (permalink / raw)
To: Euler Taveira <[email protected]>; Pierre Ducroquet <[email protected]>; +Cc: Jelte Fennema <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Re: Euler Taveira
> > +1 on disabling jit by default. At the FOSDEM Postgres developer meeting
> > consensus was hugely in favor of changing the default. So attached is a
> > trivial patch that does this.
I'm also in favor of disabling it by default. It's mostly hurting
people (or use cases) in OLTP workloads where it's just surprising
that JIT kicks in, while in OLAP workloads, people would usually know
they have a use for JIT and could enable it.
There are several layers of "default" here:
1) the default when compiling without extra options
2) the default when compiling with LLVM
3) the default in the deb/rpm/... packages with just "postgresql" installed
4) the default in the deb/rpm/... packages with the JIT package installed
5) the default that cloud providers set when using these/their own packages
The setting for 1) is off, so you might argue that for all other
cases, someone has made a conscious choice to enable it for the other
options, but for 3/5) and likely also for 4), that decision wasn't
made by the user actually using the database, so they don't have any
influence on it. In these cases, disabling it would remove the
"surprise" moment.
That leaves 2), but I would argue that all the cases should behave the
same. If different installs have different defaults, that's hard to
communicate.
> You can argue that the majority of the workloads are
> not composed by analytic queries. Fine. That's not an excuse to perform poorly
> with a small percentage of these analytic queries.
It's neither an excuse to perform poorly on the OLTP queries that got
JITed when they should not have.
> Since there are some reports exposing these issues and articles discussing it,
> I would suggest improving the documentation stating that there are issues in
> this area and that they will be resolved in the future. (The documentation
> already stated the common issue -- short queries -- in the first paragraph [2].
> Maybe we need to be more incisive.)
Documentation won't help here. This is always biting users by
surprise. Telling them that their non-analytic workload performs
poorly because they didn't read the JIT chapter when it shouldn't be
relevant to them is quite weird.
> Instead, of using the argument that JIT hurts short queries, I would like to
> see other alternative solutions for this JIT issue. The v15 added some columns
> to pg_stat_statements that helps us understand if JIT is hurting your queries.
> I don't have numbers but instead of turning JIT off we should adopt a less
> invasive solution like increasing the thresholds that triggers it --
> jit_*_above_cost (probably using some pg_stat_statements reports). It is not a
> definitive fix, JIT needs improvement and an idea like making JIT more granular
> [3] could restore confidence in it.
I've been pondering this as well, but I think we aren't there yet. It
will still make the compiler jump in in situations where it shouldn't
(maybe the cost estimates are just wildly off, but often the planner
still finds a good OLTP plan). We want predictability here.
> Although I don't have plans to hack on JIT code but
> reports may encourage a few developers to propose changes in this area.
We'd need people to actually work out the cost parameters. :)
Christoph
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
@ 2026-02-03 15:46 ` Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Adrien Nayrat @ 2026-02-03 15:46 UTC (permalink / raw)
To: Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Pierre Ducroquet <[email protected]>; Jelte Fennema <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Hello
On 2/3/26 11:29 AM, Christoph Berg wrote:
> 5) the default that cloud providers set when using these/their own packages
Just to mention, it is disabled on most cloud provider :
* AWS RDS : off (but available)
* Google Cloud SQL : off (not supported)
https://docs.cloud.google.com/sql/docs/postgres/features#unsupported-features-for-postgres
* Microsoft Aure : off
https://learn.microsoft.com/fr-fr/azure/postgresql/server-parameters/param-query-tuning-planner-opti...
* Aiven : off https://aiven.io/docs/products/postgresql/howto/enable-jit
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
@ 2026-02-03 17:03 ` Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Greg Sabino Mullane @ 2026-02-03 17:03 UTC (permalink / raw)
To: Adrien Nayrat <[email protected]>; +Cc: Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Pierre Ducroquet <[email protected]>; Jelte Fennema <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Given that so many places are already disabling it, +1 to disabling by
default - unless someone can come up with a costing tweak so it doesn't
fire when it shouldn't - but right now that seems something only humans can
truly determine.
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
@ 2026-02-03 17:13 ` Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Andres Freund @ 2026-02-03 17:13 UTC (permalink / raw)
To: Greg Sabino Mullane <[email protected]>; +Cc: Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Pierre Ducroquet <[email protected]>; Jelte Fennema <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Hi,
+1 for disabling it by default. Particularly with partitioning having become
much more common since jit compilation was added, combined with LLVM getting a
lot slower over time, that's unfortunately the right call until some
substantial improvements are made.
On 2026-02-03 12:03:51 -0500, Greg Sabino Mullane wrote:
> Given that so many places are already disabling it, +1 to disabling by
> default - unless someone can come up with a costing tweak so it doesn't
> fire when it shouldn't - but right now that seems something only humans can
> truly determine.
I think it needs more than a costing tweak. The most important thing would be
to get caching (there's progress, albeit very slow one, towards that), so the
downside of JIT compilation doesn't hit you over and over.
Relatedly, we often end up with the almost-same expression being jit compiled
many times in partitioned workloads, which is one of the main sources of high
jit compilation times.
We also need to just increase the benefit of JIT compilation further, the code
we generate leaves a *lot* on the table, particularly for more complicated
expressions, where the gain also can be the biggest.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
@ 2026-02-13 14:57 ` Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Jelte Fennema-Nio @ 2026-02-13 14:57 UTC (permalink / raw)
To: Andres Freund <[email protected]>; +Cc: Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Pierre Ducroquet <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On Tue, 3 Feb 2026 at 18:13, Andres Freund <[email protected]> wrote:
> +1 for disabling it by default. Particularly with partitioning having become
> much more common since jit compilation was added, combined with LLVM getting a
> lot slower over time, that's unfortunately the right call until some
> substantial improvements are made.
I'm marking this as ready for committer.
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
@ 2026-03-23 06:33 ` Pierre Ducroquet <[email protected]>
2026-03-24 14:32 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
0 siblings, 2 replies; 16+ messages in thread
From: Pierre Ducroquet @ 2026-03-23 06:33 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Tomas Vondra <[email protected]>; Jelte Fennema-Nio <[email protected]>; Andres Freund <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Le vendredi 20 mars 2026 à 5:25 PM, Tom Lane <[email protected]> a écrit :
> Tomas Vondra <[email protected]> writes:
> > ISTM there's a clear consensus to get this committed for PG19, so
> > barring objections I'll take care of that in the next couple days.
> > Unless someone else wants to ...
>
> +1
>
> > Another option would be to leave that for mid-beta, which is where we
> > tweaked the io_method GUCs last year. But we did that to get some
> > testing for 'worker' (in case we revert to 'sync'), and we don't need
> > that for jit.
>
> Doesn't seem like something to change mid-beta. If it makes anyone
> unhappy, we'd best find out sooner not later.
I've not seen any feedback on my "counter"-proposal: switch jit_tuple_deforming to off by default. Sure, for the perfect llvmjit use cases this will reduce the performance benefits, but it will remove most if not all the problematic queries (for instance queries running on many partitions, adding/moving columns leading to explosions in compilation time...)
Of course if there are other troublesome situations, I would love being proven wrong.
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
@ 2026-03-24 14:32 ` Jelte Fennema-Nio <[email protected]>
1 sibling, 0 replies; 16+ messages in thread
From: Jelte Fennema-Nio @ 2026-03-24 14:32 UTC (permalink / raw)
To: Pierre Ducroquet <[email protected]>; +Cc: Tom Lane <[email protected]>; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On Mon Mar 23, 2026 at 9:50 AM CET, Jelte Fennema-Nio wrote:
> I think Andres' reply also applied to that suggestion. Partitioning
> really messes up jit for expressions too. I was able to pretty easily
> create some bad cases even with jit_tuple_deforming set to off. A
> query involving many partitions, but with relatively few rows per
> partition, jit became ~54x slower when using -O2 (743ms vs 40318ms).
> And even with -O0, jit is still ~3x slower (221ms vs 711ms). Full
> script and results attached.
Resending the above with a compressed attachment, because it was too
large for the mailing list.
Attachments:
[application/sql] jit_benchmark.sql (3.9K, 2-jit_benchmark.sql)
download
[application/gzip] results.out.gz (34.8K, 3-results.out.gz)
download
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
@ 2026-03-24 21:56 ` Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
1 sibling, 1 reply; 16+ messages in thread
From: Andres Freund @ 2026-03-24 21:56 UTC (permalink / raw)
To: Pierre Ducroquet <[email protected]>; +Cc: Tom Lane <[email protected]>; Tomas Vondra <[email protected]>; Jelte Fennema-Nio <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Hi,
On 2026-03-23 06:33:33 +0000, Pierre Ducroquet wrote:
> Le vendredi 20 mars 2026 à 5:25 PM, Tom Lane <[email protected]> a écrit :
>
> > Tomas Vondra <[email protected]> writes:
> > > ISTM there's a clear consensus to get this committed for PG19, so
> > > barring objections I'll take care of that in the next couple days.
> > > Unless someone else wants to ...
> >
> > +1
> >
> > > Another option would be to leave that for mid-beta, which is where we
> > > tweaked the io_method GUCs last year. But we did that to get some
> > > testing for 'worker' (in case we revert to 'sync'), and we don't need
> > > that for jit.
> >
> > Doesn't seem like something to change mid-beta. If it makes anyone
> > unhappy, we'd best find out sooner not later.
>
> I've not seen any feedback on my "counter"-proposal: switch
> jit_tuple_deforming to off by default. Sure, for the perfect llvmjit use
> cases this will reduce the performance benefits, but it will remove most if
> not all the problematic queries (for instance queries running on many
> partitions, adding/moving columns leading to explosions in compilation
> time...) Of course if there are other troublesome situations, I would love
> being proven wrong.
I doubt that that addresses the problem in any meaningful way. In nearly all
the cases I've looked at expression compilation completely dominates the cost,
due to being instantiated for every partition etc. So I'm rather surprised to
see this claim?
We should add the function deduplication pass for O0, to reduce the cost of
tuple deforming when accessing many partitions, but in my measurements that
isn't the critical path right now.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
@ 2026-03-25 22:10 ` Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Tomas Vondra @ 2026-03-25 22:10 UTC (permalink / raw)
To: Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; +Cc: Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On 3/24/26 22:56, Andres Freund wrote:
> Hi,
>
> On 2026-03-23 06:33:33 +0000, Pierre Ducroquet wrote:
>> Le vendredi 20 mars 2026 à 5:25 PM, Tom Lane <[email protected]> a écrit :
>>
>>> Tomas Vondra <[email protected]> writes:
>>>> ISTM there's a clear consensus to get this committed for PG19, so
>>>> barring objections I'll take care of that in the next couple days.
>>>> Unless someone else wants to ...
>>>
>>> +1
>>>
>>>> Another option would be to leave that for mid-beta, which is where we
>>>> tweaked the io_method GUCs last year. But we did that to get some
>>>> testing for 'worker' (in case we revert to 'sync'), and we don't need
>>>> that for jit.
>>>
>>> Doesn't seem like something to change mid-beta. If it makes anyone
>>> unhappy, we'd best find out sooner not later.
>>
>> I've not seen any feedback on my "counter"-proposal: switch
>> jit_tuple_deforming to off by default. Sure, for the perfect llvmjit use
>> cases this will reduce the performance benefits, but it will remove most if
>> not all the problematic queries (for instance queries running on many
>> partitions, adding/moving columns leading to explosions in compilation
>> time...) Of course if there are other troublesome situations, I would love
>> being proven wrong.
>
> I doubt that that addresses the problem in any meaningful way. In nearly all
> the cases I've looked at expression compilation completely dominates the cost,
> due to being instantiated for every partition etc. So I'm rather surprised to
> see this claim?
>
That's my understanding too. I did search in the archives for
performance issues related to JIT, and those are the first two I found:
1)
https://www.postgresql.org/message-id/[email protected]
2)
https://www.postgresql.org/message-id/flat/LEXPR01MB09897821BA2CDDB70225EF7BE79C0%40LEXPR01MB0989.DE...
Both have all the JIT stuff enabled, and the timings are dominated by
Optimization:
* Timing: Generation 15.707 ms, Inlining 4.688 ms, Optimization
652.021 ms, Emission 939.556 ms, Total 1611.973 ms
* Timing: Generation 27.833 ms, Inlining 117.093 ms, Optimization
3917.001 ms, Emission 2027.251 ms, Total 6089.177 ms
Or am I mistaken and it could still be due to deforming? It'd be a bit
silly to disable jit_tuple_deforming=off, only to find it's not enough
and have to disable more stuff for PG20.
Furthermore, jit_tuple_deforming is marked as DEVELOPER_OPTIONS, and is
not in the sample. Wouldn't that be a bit confusing/surprising, if we
disable just that, as it's not in the sample?
regards
--
Tomas Vondra
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
@ 2026-04-02 11:51 ` Tomas Vondra <[email protected]>
2026-04-02 12:50 ` Re: Change default of jit to off Thomas Munro <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Tomas Vondra @ 2026-04-02 11:51 UTC (permalink / raw)
To: Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; +Cc: Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Pushed, after rewording the commit message a little bit, and removing
the sentence in the docs saying
(before PostgreSQL 19 the default was on)
We've changed the defaults for a number of GUCs over the years (and some
of the GUCs were more critical than "jit"), and we have not added
similar comments to those. I haven't found a single GUC with such
comment, actually. So why have it for "jit"?
regards
--
Tomas Vondra
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
@ 2026-04-02 12:50 ` Thomas Munro <[email protected]>
2026-04-02 13:10 ` Re: Change default of jit to off Andrew Dunstan <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Thomas Munro @ 2026-04-02 12:50 UTC (permalink / raw)
To: Tomas Vondra <[email protected]>; +Cc: Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On Fri, Apr 3, 2026 at 12:52 AM Tomas Vondra <[email protected]> wrote:
> Pushed, after rewording the commit message a little bit, and removing
> the sentence in the docs saying
>
> (before PostgreSQL 19 the default was on)
How can we keep it enabled in the build farm?
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 12:50 ` Re: Change default of jit to off Thomas Munro <[email protected]>
@ 2026-04-02 13:10 ` Andrew Dunstan <[email protected]>
2026-04-02 13:46 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-04-02 19:46 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
0 siblings, 2 replies; 16+ messages in thread
From: Andrew Dunstan @ 2026-04-02 13:10 UTC (permalink / raw)
To: Thomas Munro <[email protected]>; Tomas Vondra <[email protected]>; +Cc: Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On 2026-04-02 Th 8:50 AM, Thomas Munro wrote:
> On Fri, Apr 3, 2026 at 12:52 AM Tomas Vondra <[email protected]> wrote:
>> Pushed, after rewording the commit message a little bit, and removing
>> the sentence in the docs saying
>>
>> (before PostgreSQL 19 the default was on)
> How can we keep it enabled in the build farm?
>
>
No easy way to do it globally - I guess we could default it to on in the
next client release. Individual owners can enable it in their buildfarm
configs, in the extra_config section.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 12:50 ` Re: Change default of jit to off Thomas Munro <[email protected]>
2026-04-02 13:10 ` Re: Change default of jit to off Andrew Dunstan <[email protected]>
@ 2026-04-02 13:46 ` Greg Sabino Mullane <[email protected]>
2026-04-02 14:01 ` Re: Change default of jit to off Andrew Dunstan <[email protected]>
1 sibling, 1 reply; 16+ messages in thread
From: Greg Sabino Mullane @ 2026-04-02 13:46 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; +Cc: Thomas Munro <[email protected]>; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
Probably want a new buildfarm flag/icon for it then - maybe a monkey
wrench? :)
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 12:50 ` Re: Change default of jit to off Thomas Munro <[email protected]>
2026-04-02 13:10 ` Re: Change default of jit to off Andrew Dunstan <[email protected]>
2026-04-02 13:46 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
@ 2026-04-02 14:01 ` Andrew Dunstan <[email protected]>
0 siblings, 0 replies; 16+ messages in thread
From: Andrew Dunstan @ 2026-04-02 14:01 UTC (permalink / raw)
To: Greg Sabino Mullane <[email protected]>; +Cc: Thomas Munro <[email protected]>; Tomas Vondra <[email protected]>; Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On 2026-04-02 Th 9:46 AM, Greg Sabino Mullane wrote:
> Probably want a new buildfarm flag/icon for it then - maybe a monkey
> wrench? :)
>
>
>
This things are for configure options, not runtime options, although we
could expand that, I guess. It's a SMOC.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 12:50 ` Re: Change default of jit to off Thomas Munro <[email protected]>
2026-04-02 13:10 ` Re: Change default of jit to off Andrew Dunstan <[email protected]>
@ 2026-04-02 19:46 ` Tomas Vondra <[email protected]>
2026-04-12 22:27 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
1 sibling, 1 reply; 16+ messages in thread
From: Tomas Vondra @ 2026-04-02 19:46 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; Thomas Munro <[email protected]>; +Cc: Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On 4/2/26 15:10, Andrew Dunstan wrote:
>
> On 2026-04-02 Th 8:50 AM, Thomas Munro wrote:
>> On Fri, Apr 3, 2026 at 12:52 AM Tomas Vondra <[email protected]> wrote:
>>> Pushed, after rewording the commit message a little bit, and removing
>>> the sentence in the docs saying
>>>
>>> (before PostgreSQL 19 the default was on)
>> How can we keep it enabled in the build farm?
>>
>>
>
> No easy way to do it globally - I guess we could default it to on in the
> next client release. Individual owners can enable it in their buildfarm
> configs, in the extra_config section.
>
That's a good idea. Maybe we should ping the buildfarm owners (those
that are already running --with-llvm) to add jit=on.
I'll do that on my two clang animals dikkop/jay, and maybe on some of
the gcc ones too. But I'll wait a bit, I don't want to upset them right
before feature freeze.
regards
--
Tomas Vondra
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Change default of jit to off
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Re: Change default of jit to off Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Re: Change default of jit to off Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-02-13 14:57 ` Re: Change default of jit to off Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Re: Change default of jit to off Pierre Ducroquet <[email protected]>
2026-03-24 21:56 ` Re: Change default of jit to off Andres Freund <[email protected]>
2026-03-25 22:10 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
2026-04-02 12:50 ` Re: Change default of jit to off Thomas Munro <[email protected]>
2026-04-02 13:10 ` Re: Change default of jit to off Andrew Dunstan <[email protected]>
2026-04-02 19:46 ` Re: Change default of jit to off Tomas Vondra <[email protected]>
@ 2026-04-12 22:27 ` Tomas Vondra <[email protected]>
0 siblings, 0 replies; 16+ messages in thread
From: Tomas Vondra @ 2026-04-12 22:27 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; Thomas Munro <[email protected]>; +Cc: Andres Freund <[email protected]>; Pierre Ducroquet <[email protected]>; Tom Lane <[email protected]>; Jelte Fennema-Nio <[email protected]>; Greg Sabino Mullane <[email protected]>; Adrien Nayrat <[email protected]>; Christoph Berg <[email protected]>; Euler Taveira <[email protected]>; Álvaro Herrera <[email protected]>; PostgreSQL Hackers <[email protected]>; Andreas Karlsson <[email protected]>; Anthonin Bonnefoy <[email protected]>; pgsql-hackers; Michael Banck <[email protected]>
On 4/2/26 21:46, Tomas Vondra wrote:
>
>
> On 4/2/26 15:10, Andrew Dunstan wrote:
>>
>> On 2026-04-02 Th 8:50 AM, Thomas Munro wrote:
>>> On Fri, Apr 3, 2026 at 12:52 AM Tomas Vondra <[email protected]> wrote:
>>>> Pushed, after rewording the commit message a little bit, and removing
>>>> the sentence in the docs saying
>>>>
>>>> (before PostgreSQL 19 the default was on)
>>> How can we keep it enabled in the build farm?
>>>
>>>
>>
>> No easy way to do it globally - I guess we could default it to on in the
>> next client release. Individual owners can enable it in their buildfarm
>> configs, in the extra_config section.
>>
>
> That's a good idea. Maybe we should ping the buildfarm owners (those
> that are already running --with-llvm) to add jit=on.
>
> I'll do that on my two clang animals dikkop/jay, and maybe on some of
> the gcc ones too. But I'll wait a bit, I don't want to upset them right
> before feature freeze.
>
FWIW I've now done this on my 5 animals - dikkop, turaco, widowbird, jay
and hippopotamus. None of them was even building with LLVM before. On
the last two it was a bit of a struggle, due to having old gcc and LLVM.
regards
--
Tomas Vondra
^ permalink raw reply [nested|flat] 16+ messages in thread
end of thread, other threads:[~2026-04-12 22:27 UTC | newest]
Thread overview: 16+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-03 10:29 Re: Change default of jit to off Christoph Berg <[email protected]>
2026-02-03 15:46 ` Adrien Nayrat <[email protected]>
2026-02-03 17:03 ` Greg Sabino Mullane <[email protected]>
2026-02-03 17:13 ` Andres Freund <[email protected]>
2026-02-13 14:57 ` Jelte Fennema-Nio <[email protected]>
2026-03-23 06:33 ` Pierre Ducroquet <[email protected]>
2026-03-24 14:32 ` Jelte Fennema-Nio <[email protected]>
2026-03-24 21:56 ` Andres Freund <[email protected]>
2026-03-25 22:10 ` Tomas Vondra <[email protected]>
2026-04-02 11:51 ` Tomas Vondra <[email protected]>
2026-04-02 12:50 ` Thomas Munro <[email protected]>
2026-04-02 13:10 ` Andrew Dunstan <[email protected]>
2026-04-02 13:46 ` Greg Sabino Mullane <[email protected]>
2026-04-02 14:01 ` Andrew Dunstan <[email protected]>
2026-04-02 19:46 ` Tomas Vondra <[email protected]>
2026-04-12 22:27 ` Tomas Vondra <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox