Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pScUj-0001hX-0v for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Feb 2023 11:32:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pScUh-0001nO-Ey for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Feb 2023 11:32:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pScUg-0001nF-SF for pgsql-hackers@lists.postgresql.org; Thu, 16 Feb 2023 11:32:07 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pScUa-0005rG-Bd for pgsql-hackers@lists.postgresql.org; Thu, 16 Feb 2023 11:32:05 +0000 Received: by mail-wm1-x334.google.com with SMTP id j29-20020a05600c1c1d00b003dc52fed235so1391328wms.1 for ; Thu, 16 Feb 2023 03:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeltef-nl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kY80WMTW9yS+jdqg30L9+fEsMAhQJxuaLOKS1QjXY2Q=; b=423Kv4RcIb/j2KVDi8JNZIEHnmrR5h/FqlbjzBRWmec9WznfcN4gkMJxmohBWvdxDZ fuWs/yTC+4DCTSjIDgZ5Q4LBDNaBMKYep5+ARPswci2VPmc2uyFGiP3Ov4swaMY+7SXH HvEjFEBEvJ04N3tP5UCmiCsLdRLGoSyarmTbDXROlI3DWgqTofae/iPL4bNQnVbVxJzU s6cSNpQLD01xOA/uHX3n8EbY00XKkIHvynZOqu8/CY3mtT/g6PNgYkFeLekOfSM0uSBC z7+qSM5etw2IqAqXBXgQZUms3TuNQZvMMRjWsnZe0CwNH3V6yQIvdjrtH4Wz7O4QcRhb fRFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kY80WMTW9yS+jdqg30L9+fEsMAhQJxuaLOKS1QjXY2Q=; b=HfA/0uPPf6fYmeDLgzuM/7EUWRYMGV13X5M3g6QRq4JcBUx15rHC/GPDaf+YTLMoBi FKIQMd+POEIbm8eBJ2aiisngG7AuVAxDcQJ9Ctr06HiwQACsFfUsgNnTOnyM1bny5Q+d r2cwV1Rgou23V+k72Zfx9fKCslhr7hu9u1kLRKqe35HMP680+2dAnm2MRFOSJ+LZdx0y 0yAu4wPuB8IjDY8C/l3ZOM68q4yTpmitUoAdH0DJy2EXW7/WAaMrIhKi26LrxCdVM/DH 6Q6Enj6T48ZdfEeJ4xlPbHcJTzOTohGkm240hFC/rhvKpwhUQip5r8Q3/Wh4EFzQJoSo gXxw== X-Gm-Message-State: AO0yUKXW8+xXqSR8osxWrJCaJ5Dxayol+u/mfiorkb3cNndxAwFxGp9L 3+RfLouDLHE46Mhotx0B2d0MHO4T3L2W1jbSvOCpVWTmOxqHwIBQC+gNkA== X-Google-Smtp-Source: AK7set8fPjkqDTnR5OGZs/OvgNiYhgZkI5v3XTs5HkVmDtMhhcmCFql7kl9zeMQ17JxHpRRlTWTLonpRaBFUQl9a0Q8= X-Received: by 2002:a05:600c:3845:b0:3e2:624:e5e0 with SMTP id s5-20020a05600c384500b003e20624e5e0mr111051wmr.60.1676547117927; Thu, 16 Feb 2023 03:31:57 -0800 (PST) MIME-Version: 1.0 References: <23787477-5fe1-a161-6d2a-e459f74c4713@timescale.com> In-Reply-To: <23787477-5fe1-a161-6d2a-e459f74c4713@timescale.com> From: Jelte Fennema Date: Thu, 16 Feb 2023 12:31:46 +0100 Message-ID: Subject: Re: [PATCH] Align GSS and TLS error handling in PQconnectPoll() To: Jacob Champion Cc: PostgreSQL Hackers , Michael Paquier Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Patch looks good to me. Definitely an improvement over the status quo. Looking at the TLS error handling though I see these two lines: && conn->allow_ssl_try /* redundant? */ && !conn->wait_ssl_try) /* redundant? */ Are they actually redundant like the comment suggests? If so, we should probably remove them (in another patch). If not (or if we don't know), should we have these same checks for GSS?