public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jelte Fennema <[email protected]>
To: Sadhuprasad Patro <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Per-table storage parameters for TableAM/IndexAM extensions
Date: Mon, 17 Jan 2022 12:17:16 +0100
Message-ID: <CAGECzQRDj2UrOvg-rJfWdTAPjh0WEjt7xBWV61bGTOH7jONcPw@mail.gmail.com> (raw)
In-Reply-To: <CAFF0-CG4KZHdtYHMsonWiXNzj16gWZpduXAn8yF7pDDub+GQMg@mail.gmail.com>
References: <CAFF0-CG4KZHdtYHMsonWiXNzj16gWZpduXAn8yF7pDDub+GQMg@mail.gmail.com>

Big +1, this is a great addition!

I think it would be very useful if there were some tests for this new
feature. Something similar to the tests for storage parameters for
index AMs in src/test/modules/dummy_index_am.

Apart from that I think the documentation for table storage parameters
needs to be updated in doc/src/sgml/ref/create_table.sgml. It now
needs to indicate that these parameters are different for each table
access method. Similar to this paragraph in the create index storage
parameter section of the docs:

> Each index method has its own set of allowed storage parameters.
> The B-tree, hash, GiST and SP-GiST index methods all accept this
> parameter

Jelte

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Per-table storage parameters for TableAM/IndexAM extensions
  In-Reply-To: <CAGECzQRDj2UrOvg-rJfWdTAPjh0WEjt7xBWV61bGTOH7jONcPw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox