MIME-Version: 1.0
References: <202311081620.s2a7ao5jtlpe@alvherre.pgsql> <b878b8d2-8481-4fde-a374-5ccb9168d4e4@gmail.com>
 <CAO6_Xqo_H3-ykt_Hmip-TKNBVWZbRthLvFu4qTpQSSEgV4dWmA@mail.gmail.com>
 <CAGECzQQqkkvSko4fZUBAmVMd=VmC4nXdyOBO=s_42HzKJ=GaEA@mail.gmail.com>
 <ZZC3ywNby6FtSagL@paquier.xyz> <ZZ475K5dDxDlUl97@paquier.xyz> <ZaTjr6qpw71vS00O@paquier.xyz>
In-Reply-To: <ZaTjr6qpw71vS00O@paquier.xyz>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Mon, 15 Jan 2024 10:01:59 +0100
Message-ID: <CAGECzQRwkYVzAD3S3u2PYt5E16xZKqL0nUYQXZ05tO=pCAdcKA@mail.gmail.com>
Subject: Re: Add PQsendSyncMessage() to libpq
To: Michael Paquier <michael@paquier.xyz>
Cc: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>, 
	Anton Kirilov <antonvkirilov@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAGECzQRwkYVzAD3S3u2PYt5E16xZKqL0nUYQXZ05tO%3DpCAdcKA%40mail.gmail.com>
Precedence: bulk

On Mon, 15 Jan 2024 at 08:50, Michael Paquier <michael@paquier.xyz> wrote:
> Yeah, I'll go with that after a second look.  Attached is what I am
> finishing with, and I have reproduced some numbers with the pgbench
> metacommand mentioned upthread, which is reeeaaally nice.

Code looks good to me. But one small notes on the test.

+     /* second pipeline */
+     if (PQsendQueryParams(conn, "SELECT $1", 1, dummy_param_oids,
+                                     dummy_params, NULL, NULL, 0) != 1)
+           pg_fatal("dispatching first SELECT failed: %s",
PQerrorMessage(conn));

Error message should be "second SELECT" not "first SELECT". Same note
for the error message in the third pipeline, where it still says
"second SELECT".


+     res = PQgetResult(conn);
+     if (res == NULL)
+           pg_fatal("PQgetResult returned null when there's a
pipeline item: %s",
+                        PQerrorMessage(conn));
+
+     if (PQresultStatus(res) != PGRES_TUPLES_OK)
+           pg_fatal("Unexpected result code %s from first pipeline item",
+                        PQresStatus(PQresultStatus(res)));
+     PQclear(res);
+     res = NULL;
+
+     if (PQgetResult(conn) != NULL)
+           pg_fatal("PQgetResult returned something extra after first result");

same issue: s/first/second/g (and s/second/third/g for the existing
part of the test).