MIME-Version: 1.0
References: <202603201311.yhtqmvektawm@alvherre.pgsql>
 <bf49721a-a56f-4bdc-ac48-5d4dc1d01805@dunslane.net>
 <8ec9b67d-939e-4b22-8d56-a5129f92d32d@app.fastmail.com>
 <CAN4CZFNYM5jNA_gLu9miAXg_7c8Z2zf-ePc+0rzidAV3CBs=cw@mail.gmail.com>
 <555cdee4-c024-4872-9d96-82ef4216239c@dunslane.net>
 <SY7PR01MB10921A6E1E08A48F3426FE529B651A@SY7PR01MB10921.ausprd01.prod.outlook.com>
 <CAKFQuwYcppypeGBwa7ZbDAfoUXSv+kLhJuAXsdwBmKrvy8wDFw@mail.gmail.com>
 <a533fb1b-0f2c-4fc9-ab3b-6fb5ddac1800@dunslane.net>
 <a1c4dd3e-6694-4b7b-8432-f3b584735ff3@dunslane.net>
In-Reply-To: <a1c4dd3e-6694-4b7b-8432-f3b584735ff3@dunslane.net>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Sun, 5 Apr 2026 18:35:34 +0200
Message-ID: 
 <CAGECzQRyh9Yf87sMgBaYjaas7yx5R91ga5JjJxAx3W_Uu8BfUA@mail.gmail.com>
Subject: Re: pg_get__*_ddl consolidation
To: Andrew Dunstan <andrew@dunslane.net>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Japin Li <japinli@hotmail.com>,
	Zsolt Parragi <zsolt.parragi@percona.com>, Euler Taveira <euler@eulerto.com>,
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGECzQRyh9Yf87sMgBaYjaas7yx5R91ga5JjJxAx3W_Uu8BfUA%40mail.gmail.com>
Precedence: bulk

On Sun, 5 Apr 2026 at 17:06, Andrew Dunstan <andrew@dunslane.net> wrote:
> Pushed. I have moved the remaining get_*_ddl items to PG20-1

+1 on having  this feature in general. But I'm not sure I understand
why it needs the whole bespoke string-based option parsing in the
first commit. Why not use named arguments for this, i.e. have the
usage syntax be:

SELECT * FROM pg_get_role_ddl('regress_role_ddl_test3', pretty => true);

Instead of the current:

SELECT * FROM pg_get_role_ddl('regress_role_ddl_test3', 'pretty', 'true');