public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jelte Fennema-Nio <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: protocol-level wait-for-LSN
Date: Wed, 30 Oct 2024 10:03:27 +0100
Message-ID: <CAGECzQRzd052SoYKHT1mmeNFFXP2B3wV68WgyEO7qcSAh9XErQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Mon, 28 Oct 2024 at 16:51, Peter Eisentraut <[email protected]> wrote:
> Thoughts?

+                   snprintf(xloc, sizeof(xloc), "%X/%X",
LSN_FORMAT_ARGS(logptr))
+                   pq_sendstring(&buf, xloc);

nit: I feel that sending the LSN as a string seems unnecessarily
wasteful of bytes. I'd rather send it as its binary representation.

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: protocol-level wait-for-LSN
  In-Reply-To: <CAGECzQRzd052SoYKHT1mmeNFFXP2B3wV68WgyEO7qcSAh9XErQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox