MIME-Version: 1.0
References: <202403271534.4eq4o2ofrxsx@alvherre.pgsql>
 <202403271846.yfbljes2v3zq@alvherre.pgsql>
In-Reply-To: <202403271846.yfbljes2v3zq@alvherre.pgsql>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Thu, 28 Mar 2024 10:31:30 +0100
Message-ID: 
 <CAGECzQS0kFOUkZHzgfUTOTzFanOh0SSO2wGEdsGYRfrX7863Vg@mail.gmail.com>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Noah Misch <noah@leadboat.com>,
 Jacob Champion <jacob.champion@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Denis Laxalde <denis.laxalde@dalibo.com>,
	vignesh C <vignesh21@gmail.com>, Thomas Munro <thomas.munro@gmail.com>,
 Greg Stark <stark@mit.edu>,
	"Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
 Jelte Fennema <Jelte.Fennema@microsoft.com>,
	Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>, Justin Pryzby <pryzby@telsasoft.com>,
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@lists.postgresql.org,
	Etsuro Fujita <etsuro.fujita@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGECzQS0kFOUkZHzgfUTOTzFanOh0SSO2wGEdsGYRfrX7863Vg%40mail.gmail.com>
Precedence: bulk

On Wed, 27 Mar 2024 at 19:46, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2024-Mar-27, Alvaro Herrera wrote:
>
> > I changed it so that the error messages are returned as translated
> > phrases, and was bothered by the fact that if errors happen repeatedly,
> > the memory for them might be leaked.  Maybe this is fine depending on
> > the caller's memory context, but since it's only at most one string each
> > time, it's quite easy to just keep track of it so that we can release it
> > on the next.
>
> (Actually this sounds clever but fails pretty obviously if the caller
> does free the string, such as in a memory context reset.  So I guess we
> have to just accept the potential leakage.)

Your changes look good, apart from the prverror stuff indeed. If you
remove the prverror stuff again I think this is ready to commit.