MIME-Version: 1.0
References: <ZHfZxjcR0J9Ws7ze@telsasoft.com> <ZHiUKhhT71X4CjJl@paquier.xyz>
 <ZLgn3Ou4YpgP8Z8l@telsasoft.com> <d1cb16ec-9af1-4657-81f2-865480d2bd6d@eisentraut.org>
 <ZdWa0sSExPfBvAyR@paquier.xyz> <cab23590-19d4-4895-9333-1c25f4194741@eisentraut.org>
 <Zd7qEUKkBVY0d2-4@paquier.xyz> <ZeCZ89xAVFeOmrQC@pryzbyj2023>
 <ZeE14kii-re1CSUk@paquier.xyz> <CAGECzQScYZLUrmxj2hHpkqZTSxmP+m4M5YgbT9Log6cytVfq4w@mail.gmail.com>
 <ZeFkR-BNtOUzzMBU@paquier.xyz>
In-Reply-To: <ZeFkR-BNtOUzzMBU@paquier.xyz>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Fri, 1 Mar 2024 06:25:27 +0100
Message-ID: <CAGECzQS5NNB-ZV_wsg9OwtKshq4PUqoghqGbf8SrMqseBs7fKg@mail.gmail.com>
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Peter Eisentraut <peter@eisentraut.org>, 
	Soumyadeep Chakraborty <soumyadeep2007@gmail.com>, Zhihong Yu <zyu@yugabyte.com>, 
	pgsql-hackers@postgresql.org, Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAGECzQS5NNB-ZV_wsg9OwtKshq4PUqoghqGbf8SrMqseBs7fKg%40mail.gmail.com>
Precedence: bulk

On Fri, 1 Mar 2024 at 06:15, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Mar 01, 2024 at 05:43:25AM +0100, Jelte Fennema-Nio wrote:
> > I think we should set the AM OID explicitly. Because an important
> > thing to consider is: What behaviour makes sense when later
> > default_table_access_method is changed?
> > I think if someone sets it explicitly on the partitioned table, they
> > would want the AM of the partitioned table to stay the same when
> > default_table_access_method is changed. Which requires storing the AM
> > OID afaict.
>
> Oops, I think I misread that.  You just mean to always set relam when
> using an AM in the SET ACCESS METHOD clause.  Apologies for the noise.

Correct, I intended to say that "SET ACCESS METHOD heap" on a
partitioned table should store heap its OID. Because while storing 0
might be simpler, it will result in (imho) wrong behaviour when later
the default_table_access_method is changed. behavior won't result in
the (imho) intended. i.e. it's not simply a small detail in what the
catolog looks like, but there's an actual behavioural change.