MIME-Version: 1.0
References: <DEY0N7FS8NCU.1F7QXGG37MQ09@jeltef.nl>
 <DG9TD0OX13DP.2JAB9LIS2HTLO@jeltef.nl>
 <88dfe280-ba29-4943-95b8-63abc9f3f771@iki.fi>
 <DGVC3GZ0U1NS.3P1XEU5E065XQ@jeltef.nl>
 <9d7ba3ac-d660-483e-8f68-9096a2464e90@iki.fi>
 <DH3G8Z262WNH.DMDDI1DM95OG@jeltef.nl>
 <d102a894-409b-43cd-a164-eaf416077ff4@iki.fi>
 <DH4ZKYOWSPRN.2L0Z3WDBG9FC8@jeltef.nl>
 <b0e6a640-5aed-469f-867a-cc820b046798@iki.fi>
 <DJPAH0WPJV3K.1PYZ8P0QXZVMX@jeltef.nl>
 <de93d338-fc4d-4184-856a-b2c19eca0499@iki.fi>
 <DJS6DTW9NJUB.FKBYKWOWB0WG@jeltef.nl>
 <a4c6998e-d026-4eed-bb90-c9ad121aaed0@iki.fi>
In-Reply-To: <a4c6998e-d026-4eed-bb90-c9ad121aaed0@iki.fi>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Wed, 8 Jul 2026 00:28:42 +0200
Message-ID: 
 <CAGECzQSF214DY91QRNRCSqJhJKy4r83qTcmdX-FdFbh6h26K1g@mail.gmail.com>
Subject: Re: Don't use the deprecated and insecure PQcancel in our frontend
 tools anymore
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Jacob Champion <jacob.champion@enterprisedb.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGECzQSF214DY91QRNRCSqJhJKy4r83qTcmdX-FdFbh6h26K1g%40mail.gmail.com>
Precedence: bulk

On Tue, 7 Jul 2026 at 16:52, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Yeah, I guess that works.. But It's a little unsatisfactory to have to
> poll, where we didn't poll before. I started to go down the rabbit hole,
> here are the options I can think of:

Honestly, I like the fallback to 1-second polling quite a bit better
than any of the options you proposed. The benefit of your options
(afaict) is making sure a very rare 1 second delay in a cancel for
pg_dump/pg_restore cannot happen on most platforms. That seems like a
rather insignificant benefit. But to achieve that the code on Windows
(and depending on the option other platforms) is now different, which
makes testing any future changes to the code much harder for anyone
who doesn't have Windows. I don't think the benefit is worth that
downside in this instance.

I guess my general thoughts on this is that I would like the behaviour
of Windows and Unix to become closer, not further apart (unless there
are significant benefits to doing so).