public inbox for [email protected]
help / color / mirror / Atom feedFrom: Jelte Fennema-Nio <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Jacob Brazeal <[email protected]>
Subject: Re: Commitfest app release on Feb 17 with many improvements
Date: Tue, 4 Feb 2025 23:52:00 +0100
Message-ID: <CAGECzQSQGqph64BigtbUV+ZuUi+wegvSd7uOq-jWcPdwJOaJ-Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAGECzQTbHhaZMY-=Y=OGMU_jik4MqCfsc7rDf6AnT=Aq-B6cZA@mail.gmail.com>
<[email protected]>
On Tue, 4 Feb 2025 at 17:27, Álvaro Herrera <[email protected]> wrote:
> I think this has potential for excessive clutter. I propose that, if
> we're going to have a column with addition/deletions, we have two
> things:
>
> 1. the total number of addition and deletions in the whole patch
> series, for the last patchset version posted. This would be shown in
> the column.
To be clear: the only stats column currently in the staging
environment shows exactly this. Changes 4 and 5 are *not* visible in
columns on the commitfest page, that info is currently only visible on
the patch details page. (For context for others: during the FOSDEM
meeting 4 was a column on the commitfest page, but I reverted that
after the feedback there)
So, I guess clutter wise the current staging is acceptable to you.
> 2. a per-patch breakdown of the number of addition and deletions for the
> last patchset version posted, one line per patch. This would appear
> in a tooltip on the column for the totals, to avoid interface
> clutter.
Statistics for each patch would definitely be nice. Not trivial to add
though, because it would need cfbot to get those statistics for each
patch. I created a github issue for this idea to track it[1]
> > 10. Allow sorting patches by total additions/deletions (added together
> > for total lines changed)
>
> Seems reasonable, though I don't see much of an use-case for this.
My main idea behind this is to allow people to easily find some small
patchsets, for when they have ~30 minutes to review something. Or for
new contributors to find something to review without getting
overwhelmed.
[1]: https://github.com/postgres/pgcommitfest/issues/24
view thread (34+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Commitfest app release on Feb 17 with many improvements
In-Reply-To: <CAGECzQSQGqph64BigtbUV+ZuUi+wegvSd7uOq-jWcPdwJOaJ-Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox