MIME-Version: 1.0
References: <CAKAnmmKVwP=yr8t8p8_QtrBFjyENLZyPxscJh4UrkCeqMQuhrw@mail.gmail.com>
 <aV82LTMd1I3GOdiX@momjian.us> <86BF995D-5959-458C-8F63-DDDB250B058B@anarazel.de>
 <aV_HOurziLsdyhuV@momjian.us>
In-Reply-To: <aV_HOurziLsdyhuV@momjian.us>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Thu, 8 Jan 2026 16:40:35 +0100
Message-ID: <CAGECzQSq879_RDW1DTaTJs9D9n94h4kS7UrAU8e=nS4g4jf9_A@mail.gmail.com>
Subject: Re: [PATCH] Provide support for trailing commas
To: Bruce Momjian <bruce@momjian.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org, 
	Greg Sabino Mullane <htamfids@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAGECzQSq879_RDW1DTaTJs9D9n94h4kS7UrAU8e%3DnS4g4jf9_A%40mail.gmail.com>
Precedence: bulk

On Thu, 8 Jan 2026 at 16:03, Bruce Momjian <bruce@momjian.us> wrote:
> I disagree.  It was clear in this case that it was the concept that was
> not wanted, rather than the implementation cost.

It definitely wasn't clear IMO. See the quote from Tom, that Greg
shared from that thread. Tom at that point said he'd be in favor, IF
it would be done everywhere. Which is exactly what Greg did.

Ofcourse Tom is allowed to change his opinion, but if I'd felt
strongly enough about this then I'd also have implemented this first
based on  the previous thread.

For the record, I'd very much like trailing commas to work. Just not
enough to put the time in to discuss them at length. But I'd
definitely like to not get errors thrown in my face every time I do a
trivial modification of a query, and I'd also like my git diffs not to
touch lines that logically have nothing to do with the change I'm
actually doing.