Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rVfdK-000fLi-OK
	for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Feb 2024 22:34:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rVfdJ-008D5x-NA
	for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Feb 2024 22:34:09 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <me@jeltef.nl>)
	id 1rVfdJ-008D5o-D4
	for pgsql-hackers@lists.postgresql.org; Thu, 01 Feb 2024 22:34:09 +0000
Received: from mail-yb1-f174.google.com ([209.85.219.174])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <me@jeltef.nl>)
	id 1rVfdE-004b9N-00
	for pgsql-hackers@postgresql.org; Thu, 01 Feb 2024 22:34:07 +0000
Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dc6d8f19ab3so1297743276.3
        for <pgsql-hackers@postgresql.org>; Thu, 01 Feb 2024 14:34:00 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1706826840; x=1707431640;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=l9bW4su+fE+ZAr5IRK/12QLwLzOa8hQrjJmPzorngYk=;
        b=ZrXGE6VVPFSm3YOE9/v7THRkJhad3t/smp1HoEgX0gLa0kutD/m4uTV4BI6xqlECKF
         lopRGP1h2BQdZt6kdf0pnnNGVSshJTQTUIIupBIisXgK1nBBfhgE9CilDl27wesPDcAX
         dQcuoNgPHibYVEQtj5V/t7LpF4Bpc7hjzXQ54eaOd0PcopGJuEZeHz0vnMGjhc4dYNsC
         9B+KXVoqRB/DhLhmgjZkhpZyxzmJZDwvuthcypqLWMQdY7HuapdQmKtH87pzfYgls4MS
         R3+vY+/IPWZAOB3s8RvGpyTZDWArjTUh+ySr61rKFgUJLN8LSgbILQoA5r7Vwd/qgLyA
         1sqQ==
X-Gm-Message-State: AOJu0YyaNFcqUB6W10HADCVuEQ4nNMtOonHxmcaMQAYFLVooyGOzy0Kw
	NgxDHi8gUT/NTm4ceO8z3EKDcM8dIWvCuEJvO6pi0SiG00/LRfN5aRNos2j1TrDJXjntYT8G1LV
	PqwywekrPwEy6f0KhzReitcU4yXzLcFQGB9UFdw==
X-Google-Smtp-Source: AGHT+IGD0gTvs/zVPu/bn0hheWhNqL7XtnrH1TtALSnO0MvdmyvoDxTKnCkc7uCWCu750wb1mu6+SALYjmgYVURhec8=
X-Received: by 2002:a05:6902:2506:b0:dc6:ca49:4ce1 with SMTP id
 dt6-20020a056902250600b00dc6ca494ce1mr498784ybb.61.1706826839644; Thu, 01 Feb
 2024 14:33:59 -0800 (PST)
MIME-Version: 1.0
References: <202311081610.xvceobshgs2j@alvherre.pgsql> <2956501.1706817642@sss.pgh.pa.us>
In-Reply-To: <2956501.1706817642@sss.pgh.pa.us>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Thu, 1 Feb 2024 23:33:49 +0100
Message-ID: <CAGECzQTVLsLsgP2dHd53jaZyVnQqUo-Mryo2vtTDO8aQ2j2E0Q@mail.gmail.com>
Subject: Re: Call pqPipelineFlush from PQsendFlushRequest
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Michael Paquier <michael@paquier.xyz>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAGECzQTVLsLsgP2dHd53jaZyVnQqUo-Mryo2vtTDO8aQ2j2E0Q%40mail.gmail.com>
Precedence: bulk

On Thu, 1 Feb 2024 at 21:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>        Note that the request is not itself flushed to the server automatically;
>        use <function>PQflush</function> if necessary.
>
> Doesn't that require some rewording?

I agree that the current wording is slightly incorrect, but I think I
prefer we keep it this way. The fact that we actually DO flush when
some internal buffer is filled up seems more like an implementation
detail, than behavior that people should actually be depending upon.
And even knowing the actual behavior, still the only way to know that
your data is flushed is by calling PQflush (since a user has no way of
checking if we automatically flushed the internal buffer).