Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viDHI-000jzr-2U for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jan 2026 15:04:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1viDHH-001TPG-2u for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jan 2026 15:04:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viDHH-001TP6-1i for pgsql-hackers@lists.postgresql.org; Tue, 20 Jan 2026 15:04:19 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1viDHB-001R8O-1j for pgsql-hackers@postgresql.org; Tue, 20 Jan 2026 15:04:18 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-59b79451206so4992197e87.1 for ; Tue, 20 Jan 2026 07:04:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1768921452; cv=none; d=google.com; s=arc-20240605; b=HvfrlE2F3nrfq8mb9NnLQjHiNXsk0DmOm3XKRQghOZlmvM5uae7G9OlvOglGVA17EO mVftPRHyJfDX5Vy/ywe1G2fInjyO93Gf09Dj0xpRXkgPv53bzNV4ezXtyBTBSD4Mlq/B WVylIczQrKMwyh2rg8Hdg//tNiDWinsgiaf0MpbFfQZ12QgZrcNKgonSm2ZuHN03lg32 /K/J/Jo6AIE3jPeU2U+v64iLx2ZX5erZ56MrFINl5WFqOoZ3rZWv5wqZ+GnyZ9CcYH38 cJA2EJFHnDgjXpIVYh+AfUzMYSzz25UzMj99tes6GJ1VMIAWP9MjEm3Ds7Xl0hVAyllF gNWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=hH13W274osAfaEhp+xvCjVnSZhYvEUROd+dXT3MrLhY=; fh=kjXgOug+huD4GRT+IgE0fzt75x+6DGnCDt+v3ozNP8M=; b=cPALuxz8/AAuLGZHbK0xnhrLRSUY9pCkY1XaPffrOqJgPYOk7UcDTdmCBpvhN2yZBj Hj8GNNTCXMsDnHbJoqXzh+oGXJCw87q0/WAUSPkscpw5qaBvVNTidvyB+ruVrwlJRjhl vLZf9wWBGyGv274hxMrCuXkk+hW6tmAyp2CRW9O4KmSgnks5BjLTk/yCz1/1WAd4hLnJ DN4LHAV2bOuWJSb5GY/28rodW3i7zjNZ3hPm/juVw+MHj4EZKm9iW7nhxrusf+qCVK9a 1TVb185dJyk5rD4snbxm1/NF48rlC95NupuqgNNbS9PDR7PWAhLq+654IOemKnaTqIHo FdNQ==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeltef.nl; s=google; t=1768921452; x=1769526252; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hH13W274osAfaEhp+xvCjVnSZhYvEUROd+dXT3MrLhY=; b=iE+tRYWA6X3s0D6pKx/PZdPP3j6OwyR6Mb16y/WsxWBB9ovZXaLe0LsIMfjeJ7v45+ FPlnyNso13xQ8JzuyRbDX9fcOuF0o6pOrzI0m/EKOBAAGSrcSjHE7co3p7laADVy8YWB P2gpcbVwrRzkNjFm+agBUFVc30JUsx74OoTjoQL1P1GGtsQ+adGjSmd24eAS/Oea8zAA husUYomOA0YZBgshqLKumyS09WKH7dH23SkNibY2qz8dAtaXlINiWQDT/ShdPE1dAW9J 31lqScdEVpJ1U+XUt3YXz/tamzdyt++uEYtUUi6moKlITMbXUfAVL6GTflrdmYRxZSTQ 6/mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768921452; x=1769526252; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hH13W274osAfaEhp+xvCjVnSZhYvEUROd+dXT3MrLhY=; b=SOxbGVEq86mIzT9CVsubdOySQlRDmu1geN8i2QmPtcycb10TDFl8oXo6YhXedAOyTr ghYfaWM4UJh4PJf56Nppc23eWGnUWb/ibYb9E1tVLXou2c6nFVAYltdInmKdrq5D6dLs WXW70NRFPFdywG/L9GNW5VafjCPcNXOvN7HfHkGUK5wbqv7T9ALOntR/zIhValZImyIM sG1mrAM/evPRwm1TKWtRkcwG/Stg0R/cLMfGCZczMBqey080mGlzjYdSLaVo1ry+SC83 8bQWyR5Joyc3ygB1rSn3rih9n7TBDRLgK816o6NWS7iMo2wzlBT6PNIwV1DNndULeGxj fxuw== X-Gm-Message-State: AOJu0YyyecgzBMPKjLUReNsiRe7uMeXiFKJPkn7rgM+GO/SfvVw9e+Du wgbOFynfbMt/UbIHE+g++WzB09qzF09Bbj3lKIM6DkYfhNkmd9nJRHCYiUWbbTXruzcWo5SbXFB rCHjlm1wQj34cF4LDhAO3OvFcPa9vswEjx2SrNyl1+AKA42FkwyRj X-Gm-Gg: AZuq6aKVgFwunBGRqlOrUyyUUUFWBmpr6MHDC/K5SLn+ZZ8t1rv4LBMWjzrcxEeA5fS V37cJNsK3IA5RpomGO7QqJIaA3i0QHjt1i2AczINyT1lCNerI/+ypV+J27EBMa3++cACtT/g2vj GTjyx55S8q2zXOyDIH+IdlWn1qQUHfnmPDwoSCQuWoJ4YPkZqnPAKEoZwlZkUOCjnbAeZWXVpej gcGYFIyiKdJa7cafegxLN65HJSBtx1VGWr8GE5SO1oNGx4vdoCTmrsXDtN5iHzZC1/8oWEMCyoY bm8I X-Received: by 2002:ac2:4c4b:0:b0:59b:7c03:f2df with SMTP id 2adb3069b0e04-59dc9363b9emr754128e87.50.1768921451600; Tue, 20 Jan 2026 07:04:11 -0800 (PST) MIME-Version: 1.0 References: <76a8efcd-925a-4eaf-bdd1-d972cd1a32ff@eisentraut.org> In-Reply-To: <76a8efcd-925a-4eaf-bdd1-d972cd1a32ff@eisentraut.org> From: Jelte Fennema-Nio Date: Tue, 20 Jan 2026 16:03:59 +0100 X-Gm-Features: AZwV_QjeBungl04rc2PH_8Ygki0XOypb3myoE9RwKEUen-J0zI1iSVXD3LpsosU Message-ID: Subject: Re: enable fallthrough warnings on clang To: Peter Eisentraut Cc: pgsql-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 20 Jan 2026 at 12:16, Peter Eisentraut wrote: > So my proposal is that we wrap the appropriate attribute into a > pg_fallthrough macro, and replace the current comments with that. All looks okay to me. The only thing that stood out is that it checks for C++ with __cpp_attributes instead of __cplusplus. Is it really worth using this more specific attribute? Given that we're already requiring C++11 and afaict all C++11 compilers should support the general notion of attributes.