MIME-Version: 1.0
References: <CAGPqQf0KitkNack4F5CFkFi-9Dqvp29Ro=EpcWt=4_hs-Rt+bQ@mail.gmail.com>
 <202502071114.kosxwvgyblj7@alvherre.pgsql>
In-Reply-To: <202502071114.kosxwvgyblj7@alvherre.pgsql>
From: Rushabh Lathia <rushabh.lathia@gmail.com>
Date: Mon, 10 Feb 2025 00:28:45 +0530
Message-ID: <CAGPqQf21cWsCujW8U90VR4wdr+VEB+LMAwkNjYwS112_gS20pA@mail.gmail.com>
Subject: Re: Support NOT VALID / VALIDATE constraint options for named NOT
 NULL constraints
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000019e163062dba2f75"
Archived-At: <https://www.postgresql.org/message-id/CAGPqQf21cWsCujW8U90VR4wdr%2BVEB%2BLMAwkNjYwS112_gS20pA%40mail.gmail.com>
Precedence: bulk

--00000000000019e163062dba2f75
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 7, 2025 at 4:44=E2=80=AFPM Alvaro Herrera <alvherre@alvh.no-ip.=
org>
wrote:

>
> Recursion to child tables is incorrectly trying to locate the constraint
> by name:
>
> create table notnull_tbl1 (a int);
> alter table notnull_tbl1 add constraint foo not null a not valid;
> create table notnull_chld (a int);
> alter table notnull_chld add constraint blah not null a not valid;
> alter table notnull_chld inherit notnull_tbl1 ;
>
> -- this fails but shouldn't:
> alter table notnull_tbl1 validate constraint foo;
> ERROR:  constraint "foo" of relation "notnull_chld" does not exist
>
> The end result here should be that the constraint `blah` in table
> notnull_chld is marked as validated.
>

Yes, I agree.  Here we need a separate Queue for NotNull constraint
validation,
which fetches the respective Non-Validate-Not-Null constraint name from
the child table

I am working on the patch and will post the update patch soon.


>
> --
> =C3=81lvaro Herrera               48=C2=B001'N 7=C2=B057'E  =E2=80=94
> https://www.EnterpriseDB.com/
> Syntax error: function hell() needs an argument.
> Please choose what hell you want to involve.
>


--=20
Rushabh Lathia

--00000000000019e163062dba2f75
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Feb 7, =
2025 at 4:44=E2=80=AFPM Alvaro Herrera &lt;<a href=3D"mailto:alvherre@alvh.=
no-ip.org">alvherre@alvh.no-ip.org</a>&gt; wrote:<br></div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex"><br>
Recursion to child tables is incorrectly trying to locate the constraint<br=
>
by name:<br>
<br>
create table notnull_tbl1 (a int);<br>
alter table notnull_tbl1 add constraint foo not null a not valid;<br>
create table notnull_chld (a int);<br>
alter table notnull_chld add constraint blah not null a not valid;<br>
alter table notnull_chld inherit notnull_tbl1 ;<br>
<br>
-- this fails but shouldn&#39;t:<br>
alter table notnull_tbl1 validate constraint foo;<br>
ERROR:=C2=A0 constraint &quot;foo&quot; of relation &quot;notnull_chld&quot=
; does not exist<br>
<br>
The end result here should be that the constraint `blah` in table<br>
notnull_chld is marked as validated.<br></blockquote><div><br></div><div>Ye=
s, I agree.=C2=A0 Here we need a separate Queue for NotNull constraint vali=
dation,</div><div>which fetches the respective Non-Validate-Not-Null constr=
aint name from</div><div>the child table</div><div><br></div><div>I am work=
ing on the patch and will post the update patch soon.</div><div>=C2=A0</div=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
=C3=81lvaro Herrera=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A04=
8=C2=B001&#39;N 7=C2=B057&#39;E=C2=A0 =E2=80=94=C2=A0 <a href=3D"https://ww=
w.EnterpriseDB.com/" rel=3D"noreferrer" target=3D"_blank">https://www.Enter=
priseDB.com/</a><br>
Syntax error: function hell() needs an argument.<br>
Please choose what hell you want to involve.<br>
</blockquote></div><div><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature">Rushabh Lathia</div></div>

--00000000000019e163062dba2f75--