MIME-Version: 1.0
References: 
 <CAGRkXqS98OebEWjax99_LVAECsxCB8i=BfsdAL34i-5QHfwyOQ@mail.gmail.com>
 <CAA5RZ0vSjCEAuKXhxacnp0ftrYkf9QRcyPK-AvTi_otFVDWphA@mail.gmail.com>
 <CAHGQGwEeGUQtj7TOznM2_O2uV-g6iOa1UBBTBfyugJ-nSoS89Q@mail.gmail.com>
 <CALdSSPi4apueVqgnJEZqpy6O0HSEPUiUzf=vTLPPijsQLob2Eg@mail.gmail.com>
In-Reply-To: 
 <CALdSSPi4apueVqgnJEZqpy6O0HSEPUiUzf=vTLPPijsQLob2Eg@mail.gmail.com>
From: shihao zhong <zhong950419@gmail.com>
Date: Tue, 10 Mar 2026 14:43:19 -0400
Message-ID: 
 <CAGRkXqQ0qBHTcD=UZ7_GTLsgn+W-=1c8suMJ3yWZb2eP4m0fBg@mail.gmail.com>
Subject: Re: Add missing stats_reset column to pg_stat_database_conflicts view
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Sami Imseih <samimseih@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000005a2ef7064cafe587"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGRkXqQ0qBHTcD%3DUZ7_GTLsgn%2BW-%3D1c8suMJ3yWZb2eP4m0fBg%40mail.gmail.com>
Precedence: bulk

--0000000000005a2ef7064cafe587
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

The patch has been rebased, and the documentation and catversion
updates have been added.

> I also noticed that pg_statio_all_sequences does not have a reset
> column. We should fix this one also. What do you think?

Right now the pg_statio_all_tables, pg_statio_all_indexes,
pg_statio_all_sequences, pg_stat_user_functions all do not have
reset_stat supported. I am actively working on tadd a reset_stat
support for these view. For now, let's quickly address the db conflict
first.

On Tue, Mar 10, 2026 at 7:32=E2=80=AFAM Kirill Reshke <reshkekirill@gmail.c=
om> wrote:
>
> On Tue, 10 Mar 2026 at 06:17, Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Tue, Mar 10, 2026 at 8:33=E2=80=AFAM Sami Imseih <samimseih@gmail.co=
m> wrote:
> > >
> > > > The attached patch adds pg_stat_get_db_stat_reset_time() to fix thi=
s
> > > > inconsistency.
> > > >
> > > > Please let me know your thoughts.
> > >
> > > This view was introduced 15 years ago, and surprisingly this is the
> > > first complaint about this. I am also not very surprised.
> > >
> > > I also noticed that pg_statio_all_sequences does not have a reset
> > > column. We should fix this one also. What do you think?
> >
> > +1
> >
> > Also it might be better to update the docs together so that the descrip=
tion of
> > pg_stat_reset_single_table_counters mentions sequences in addition to
> > tables and indexes.
> >
> > Regards,
> >
> > --
> > Fujii Masao
> >
>
> Well, it looks like there are not so many users of this view. Anyway,
> +1 on change.
> This also need catversion bump
>
> --
> Best regards,
> Kirill Reshke

--0000000000005a2ef7064cafe587
Content-Type: application/octet-stream;
	name="pg_stat_database_conflicts_v2.patch"
Content-Disposition: attachment;
	filename="pg_stat_database_conflicts_v2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmkyjkx90>
X-Attachment-Id: f_mmkyjkx90

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3NnbWwv
bW9uaXRvcmluZy5zZ21sCmluZGV4IDY4NzhiMmQuLmU4NTY4YzcgMTAwNjQ0Ci0tLSBhL2RvYy9z
cmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dt
bApAQCAtNDAzMCwyICs0MDMwLDExIEBACiAgICAgIDwvcm93PgorCisgICAgIDxyb3c+CisgICAg
ICA8ZW50cnkgcm9sZT0iY2F0YWxvZ190YWJsZV9lbnRyeSI+PHBhcmEgcm9sZT0iY29sdW1uX2Rl
ZmluaXRpb24iPgorICAgICAgIDxzdHJ1Y3RmaWVsZD5zdGF0c19yZXNldDwvc3RydWN0ZmllbGQ+
IDx0eXBlPnRpbWVzdGFtcCB3aXRoIHRpbWUgem9uZTwvdHlwZT4KKyAgICAgIDwvcGFyYT4KKyAg
ICAgIDxwYXJhPgorICAgICAgIFRpbWUgYXQgd2hpY2ggdGhlc2Ugc3RhdGlzdGljcyB3ZXJlIGxh
c3QgcmVzZXQKKyAgICAgIDwvcGFyYT48L2VudHJ5PgorICAgICA8L3Jvdz4KICAgICA8L3Rib2R5
PgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fdmlld3Muc3FsIGIvc3Jj
L2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fdmlld3Muc3FsCmluZGV4IGE1ZDNlMjMuLjE1NTJhOTIg
MTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbAorKysgYi9z
cmMvYmFja2VuZC9jYXRhbG9nL3N5c3RlbV92aWV3cy5zcWwKQEAgLTExNjUsMyArMTE2NSw0IEBA
CiAgICAgICAgICAgICBwZ19zdGF0X2dldF9kYl9jb25mbGljdF9zdGFydHVwX2RlYWRsb2NrKEQu
b2lkKSBBUyBjb25mbF9kZWFkbG9jaywKLSAgICAgICAgICAgIHBnX3N0YXRfZ2V0X2RiX2NvbmZs
aWN0X2xvZ2ljYWxzbG90KEQub2lkKSBBUyBjb25mbF9hY3RpdmVfbG9naWNhbHNsb3QKKyAgICAg
ICAgICAgIHBnX3N0YXRfZ2V0X2RiX2NvbmZsaWN0X2xvZ2ljYWxzbG90KEQub2lkKSBBUyBjb25m
bF9hY3RpdmVfbG9naWNhbHNsb3QsCisgICAgICAgICAgICBwZ19zdGF0X2dldF9kYl9zdGF0X3Jl
c2V0X3RpbWUoRC5vaWQpIEFTIHN0YXRzX3Jlc2V0CiAgICAgRlJPTSBwZ19kYXRhYmFzZSBEOwpk
aWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvY2F0YWxvZy9jYXR2ZXJzaW9uLmggYi9zcmMvaW5jbHVk
ZS9jYXRhbG9nL2NhdHZlcnNpb24uaAppbmRleCBkZmQ3YjE0Li5hNDU5MzQzIDEwMDY0NAotLS0g
YS9zcmMvaW5jbHVkZS9jYXRhbG9nL2NhdHZlcnNpb24uaAorKysgYi9zcmMvaW5jbHVkZS9jYXRh
bG9nL2NhdHZlcnNpb24uaApAQCAtNTksMyArNTksMyBAQAogLyoJCQkJCQkJeXl5eW1tZGROICov
Ci0jZGVmaW5lIENBVEFMT0dfVkVSU0lPTl9OTwkyMDI2MDMwNjIKKyNkZWZpbmUgQ0FUQUxPR19W
RVJTSU9OX05PCTIwMjYwMzEwMQogCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVj
dGVkL3J1bGVzLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcnVsZXMub3V0CmluZGV4
IDA1MzA3YTUuLjgzMWEyYzkgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQv
cnVsZXMub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcnVsZXMub3V0CkBAIC0x
OTI0LDIgKzE5MjQsMyBAQAotICAgIHBnX3N0YXRfZ2V0X2RiX2NvbmZsaWN0X2xvZ2ljYWxzbG90
KG9pZCkgQVMgY29uZmxfYWN0aXZlX2xvZ2ljYWxzbG90CisgICAgcGdfc3RhdF9nZXRfZGJfY29u
ZmxpY3RfbG9naWNhbHNsb3Qob2lkKSBBUyBjb25mbF9hY3RpdmVfbG9naWNhbHNsb3QsCisgICAg
cGdfc3RhdF9nZXRfZGJfc3RhdF9yZXNldF90aW1lKG9pZCkgQVMgc3RhdHNfcmVzZXQKICAgIEZS
T00gcGdfZGF0YWJhc2UgZDsK
--0000000000005a2ef7064cafe587--