MIME-Version: 1.0
References: 
 <CAGRkXqS98OebEWjax99_LVAECsxCB8i=BfsdAL34i-5QHfwyOQ@mail.gmail.com>
 <CAA5RZ0vSjCEAuKXhxacnp0ftrYkf9QRcyPK-AvTi_otFVDWphA@mail.gmail.com>
 <CAHGQGwEeGUQtj7TOznM2_O2uV-g6iOa1UBBTBfyugJ-nSoS89Q@mail.gmail.com>
 <CALdSSPi4apueVqgnJEZqpy6O0HSEPUiUzf=vTLPPijsQLob2Eg@mail.gmail.com>
 <CAGRkXqQ0qBHTcD=UZ7_GTLsgn+W-=1c8suMJ3yWZb2eP4m0fBg@mail.gmail.com>
 <CAA5RZ0ta3y==2AStFyo-SYyJ2ztd3ZiurN1HQR9gzDTKVtgUDg@mail.gmail.com>
In-Reply-To: 
 <CAA5RZ0ta3y==2AStFyo-SYyJ2ztd3ZiurN1HQR9gzDTKVtgUDg@mail.gmail.com>
From: shihao zhong <zhong950419@gmail.com>
Date: Wed, 11 Mar 2026 10:10:32 -0400
Message-ID: 
 <CAGRkXqRVDuhXNCvQ=j-+5KCu+Gcar_h5OeHTaMaVKF-FLV2YvQ@mail.gmail.com>
Subject: Re: Add missing stats_reset column to pg_stat_database_conflicts view
To: Sami Imseih <samimseih@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
 Fujii Masao <masao.fujii@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000968e62064cc0330d"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGRkXqRVDuhXNCvQ%3Dj-%2B5KCu%2BGcar_h5OeHTaMaVKF-FLV2YvQ%40mail.gmail.com>
Precedence: bulk

--000000000000968e62064cc0330d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 10, 2026 at 3:27=E2=80=AFPM Sami Imseih <samimseih@gmail.com> w=
rote:
>
> Hi,
>
> Please don't top-post. it makes following the thread difficult.
>
> > > I also noticed that pg_statio_all_sequences does not have a reset
> > > column. We should fix this one also. What do you think?
> >
> > Right now the pg_statio_all_tables, pg_statio_all_indexes,
> > pg_statio_all_sequences, pg_stat_user_functions all do not have
> > reset_stat supported. I am actively working on tadd a reset_stat
> > support for these view. For now, let's quickly address the db conflict
> > first.
>
> It looks like stats_reset for pg_stat_user_functions was added in
> b71bae41a0cd and for the others you mention, expected for
> pg_statio_all_sequences, was added in a5b543258aa2.
> These are already targeted for 19, and you can also see
> that in the devel docs [1].
>
> The changes you attached in v2 look good to me, but I think
> we should also add a test in stats.sql as well.
>
> FWIW, I find using "git format-patch" better for the threads. It
> forces you to write a commit message and properly formats
> the patch name [2]? It's the most common way I see patches
> being submitted.
>
> [1] [https://www.postgresql.org/docs/devel/monitoring-stats.html]
> [2] [https://wiki.postgresql.org/wiki/Submitting_a_Patch]
>
> --
> Sami Imseih
> Amazon Web Services (AWS).


Thanks for pointing that out. I've added new tests and used git
format-patch to generate a new patch.

--000000000000968e62064cc0330d
Content-Type: application/octet-stream;
	name="pg_stat_database_conflicts_v3.patch"
Content-Disposition: attachment;
	filename="pg_stat_database_conflicts_v3.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmm48pz50>
X-Attachment-Id: f_mmm48pz50

RnJvbSA1MGRlYjllZDZkNjU3MDY1OTUwNzNlMGM1OTgyZmU1OTQ5MjVjNTNkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBzaGloYW8gemhvbmcgPHpob25nOTUwNDE5QGdtYWwuY29tPgpE
YXRlOiBXZWQsIDExIE1hciAyMDI2IDE0OjA1OjU3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IHN0YXRzX3Jlc2V0IGNvbHVtbiB0byBwZ19zdGF0X2RhdGFiYXNlX2NvbmZsaWN0cyB2aWV3CiBU
aGlzIGNvbW1pdCBhZGRzIHRoZSBzdGF0c19yZXNldCBjb2x1bW4gdG8gcGdfc3RhdF9kYXRhYmFz
ZV9jb25mbGljdHMsCiBhbGxvd2luZyB1c2VycyB0byBzZWUgd2hlbiB0aGUgcmVzZXQgd2FzIGxh
c3QgcGVyZm9ybWVkLiBUaGlzIGJyaW5ncwogY29uc2lzdGVuY3kgd2l0aCBwZ19zdGF0X2RhdGFi
YXNlIGFuZCBvdGhlciBzdGF0aXN0aWNzIHZpZXdzLiBJbmNsdWRlczogLQogc3lzdGVtX3ZpZXdz
LnNxbDogVmlldyBkZWZpbml0aW9uIHVwZGF0ZSAtIG1vbml0b3Jpbmcuc2dtbDogRG9jdW1lbnRh
dGlvbgogdXBkYXRlIC0gY2F0dmVyc2lvbi5oOiBNYW5kYXRvcnkgY2F0YWxvZyB2ZXJzaW9uIGJ1
bXAgLSBSZWdyZXNzaW9uIHRlc3RzOgogVXBkYXRlZCBydWxlcy5vdXQgYW5kIGFkZGVkIHN0YXRz
LnNxbCB0ZXN0IGNhc2UKCi0tLQogZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dtbCAgICAgICAg
IHwgIDggKysrKysrKysKIHNyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbCB8ICAz
ICsrLQogc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ydWxlcy5vdXQgIHwgIDMgKystCiBzcmMv
dGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dCAgfCAxNCArKysrKysrKysrKysrKwogc3Jj
L3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsICAgICAgIHwgIDUgKysrKysKIDUgZmlsZXMgY2hh
bmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mv
c3JjL3NnbWwvbW9uaXRvcmluZy5zZ21sIGIvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dtbApp
bmRleCBjYzAxNDU2NGM5Ny4uNzYzZjY3MzFkZWUgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9t
b25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dtbApAQCAtNDAz
Niw2ICs0MDM2LDE0IEBAIGRlc2NyaXB0aW9uIHwgV2FpdGluZyBmb3IgYSBuZXdseSBpbml0aWFs
aXplZCBXQUwgZmlsZSB0byByZWFjaCBkdXJhYmxlIHN0b3JhZ2UKICAgICAgICBvbiB0aGUgcHJp
bWFyeQogICAgICAgPC9wYXJhPjwvZW50cnk+CiAgICAgIDwvcm93PgorICAgICAgPHJvdz4KKyAg
ICAgICA8ZW50cnkgcm9sZT0iY2F0YWxvZ190YWJsZV9lbnRyeSI+PHBhcmEgcm9sZT0iY29sdW1u
X2RlZmluaXRpb24iPgorICAgICAgICA8c3RydWN0ZmllbGQ+c3RhdHNfcmVzZXQ8L3N0cnVjdGZp
ZWxkPiA8dHlwZT50aW1lc3RhbXAgd2l0aCB0aW1lIHpvbmU8L3R5cGU+CisgICAgICAgPC9wYXJh
PgorICAgICAgIDxwYXJhPgorICAgICAgICBUaW1lIGF0IHdoaWNoIHRoZXNlIHN0YXRpc3RpY3Mg
d2VyZSBsYXN0IHJlc2V0CisgICAgICAgPC9wYXJhPjwvZW50cnk+CisgICAgICA8L3Jvdz4KICAg
ICA8L3Rib2R5PgogICAgPC90Z3JvdXA+CiAgIDwvdGFibGU+CmRpZmYgLS1naXQgYS9zcmMvYmFj
a2VuZC9jYXRhbG9nL3N5c3RlbV92aWV3cy5zcWwgYi9zcmMvYmFja2VuZC9jYXRhbG9nL3N5c3Rl
bV92aWV3cy5zcWwKaW5kZXggMzM5YzAxNmU1MTAuLjMzNjEwMzBkMzRjIDEwMDY0NAotLS0gYS9z
cmMvYmFja2VuZC9jYXRhbG9nL3N5c3RlbV92aWV3cy5zcWwKKysrIGIvc3JjL2JhY2tlbmQvY2F0
YWxvZy9zeXN0ZW1fdmlld3Muc3FsCkBAIC0xMTYzLDcgKzExNjMsOCBAQCBDUkVBVEUgVklFVyBw
Z19zdGF0X2RhdGFiYXNlX2NvbmZsaWN0cyBBUwogICAgICAgICAgICAgcGdfc3RhdF9nZXRfZGJf
Y29uZmxpY3Rfc25hcHNob3QoRC5vaWQpIEFTIGNvbmZsX3NuYXBzaG90LAogICAgICAgICAgICAg
cGdfc3RhdF9nZXRfZGJfY29uZmxpY3RfYnVmZmVycGluKEQub2lkKSBBUyBjb25mbF9idWZmZXJw
aW4sCiAgICAgICAgICAgICBwZ19zdGF0X2dldF9kYl9jb25mbGljdF9zdGFydHVwX2RlYWRsb2Nr
KEQub2lkKSBBUyBjb25mbF9kZWFkbG9jaywKLSAgICAgICAgICAgIHBnX3N0YXRfZ2V0X2RiX2Nv
bmZsaWN0X2xvZ2ljYWxzbG90KEQub2lkKSBBUyBjb25mbF9hY3RpdmVfbG9naWNhbHNsb3QKKwkJ
CXBnX3N0YXRfZ2V0X2RiX2NvbmZsaWN0X2xvZ2ljYWxzbG90KEQub2lkKSBBUyBjb25mbF9hY3Rp
dmVfbG9naWNhbHNsb3QsCisJCQlwZ19zdGF0X2dldF9kYl9zdGF0X3Jlc2V0X3RpbWUoRC5vaWQp
IEFTIHN0YXRzX3Jlc2V0CiAgICAgRlJPTSBwZ19kYXRhYmFzZSBEOwogCiBDUkVBVEUgVklFVyBw
Z19zdGF0X3VzZXJfZnVuY3Rpb25zIEFTCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4
cGVjdGVkL3J1bGVzLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcnVsZXMub3V0Cmlu
ZGV4IGYzNzNhZDcwNGI2Li43MWQ3MjYyMDQ5ZSAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVz
cy9leHBlY3RlZC9ydWxlcy5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ydWxl
cy5vdXQKQEAgLTE5MjEsNyArMTkyMSw4IEBAIHBnX3N0YXRfZGF0YWJhc2VfY29uZmxpY3RzfCBT
RUxFQ1Qgb2lkIEFTIGRhdGlkLAogICAgIHBnX3N0YXRfZ2V0X2RiX2NvbmZsaWN0X3NuYXBzaG90
KG9pZCkgQVMgY29uZmxfc25hcHNob3QsCiAgICAgcGdfc3RhdF9nZXRfZGJfY29uZmxpY3RfYnVm
ZmVycGluKG9pZCkgQVMgY29uZmxfYnVmZmVycGluLAogICAgIHBnX3N0YXRfZ2V0X2RiX2NvbmZs
aWN0X3N0YXJ0dXBfZGVhZGxvY2sob2lkKSBBUyBjb25mbF9kZWFkbG9jaywKLSAgICBwZ19zdGF0
X2dldF9kYl9jb25mbGljdF9sb2dpY2Fsc2xvdChvaWQpIEFTIGNvbmZsX2FjdGl2ZV9sb2dpY2Fs
c2xvdAorICAgIHBnX3N0YXRfZ2V0X2RiX2NvbmZsaWN0X2xvZ2ljYWxzbG90KG9pZCkgQVMgY29u
ZmxfYWN0aXZlX2xvZ2ljYWxzbG90LAorICAgIHBnX3N0YXRfZ2V0X2RiX3N0YXRfcmVzZXRfdGlt
ZShvaWQpIEFTIHN0YXRzX3Jlc2V0CiAgICBGUk9NIHBnX2RhdGFiYXNlIGQ7CiBwZ19zdGF0X2dz
c2FwaXwgU0VMRUNUIHBpZCwKICAgICBnc3NfYXV0aCBBUyBnc3NfYXV0aGVudGljYXRlZCwKZGlm
ZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMub3V0IGIvc3JjL3Rlc3Qv
cmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKaW5kZXggY2QwMGYzNWJmN2EuLjBkNjM0YzNhZjQy
IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dAorKysgYi9z
cmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dApAQCAtMTkxMCw0ICsxOTEwLDE4IEBA
IFNFTEVDVCAqIEZST00gY2hlY2tfZXN0aW1hdGVkX3Jvd3MoJ1NFTEVDVCAqIEZST00gdGFibGVf
ZmlsbGZhY3RvcicpOwogKDEgcm93KQogCiBEUk9QIFRBQkxFIHRhYmxlX2ZpbGxmYWN0b3I7Cist
LSBUZXN0IHRoYXQgdGhlIHN0YXRzX3Jlc2V0IGNvbHVtbiBpbiBwZ19zdGF0X2RhdGFiYXNlX2Nv
bmZsaWN0cyBpcyBjb3JyZWN0bHkgbWFpbnRhaW5lZAorU0VMRUNUIHBnX3N0YXRfcmVzZXQoKTsK
KyBwZ19zdGF0X3Jlc2V0IAorLS0tLS0tLS0tLS0tLS0tCisgCisoMSByb3cpCisKK1NFTEVDVCBz
dGF0c19yZXNldCBJUyBOT1QgTlVMTCBBUyBoYXNfc3RhdHNfcmVzZXQKKyAgRlJPTSBwZ19zdGF0
X2RhdGFiYXNlX2NvbmZsaWN0cyBXSEVSRSBkYXRuYW1lID0gY3VycmVudF9kYXRhYmFzZSgpOwor
IGhhc19zdGF0c19yZXNldCAKKy0tLS0tLS0tLS0tLS0tLS0tCisgdAorKDEgcm93KQorCiAtLSBF
bmQgb2YgU3RhdHMgVGVzdApkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMu
c3FsIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsCmluZGV4IDg3NjhlMGYyN2ZkLi5l
NWZiOTBjZjBjMyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsCisr
KyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbApAQCAtOTQ0LDQgKzk0NCw5IEBAIFNF
TEVDVCAqIEZST00gY2hlY2tfZXN0aW1hdGVkX3Jvd3MoJ1NFTEVDVCAqIEZST00gdGFibGVfZmls
bGZhY3RvcicpOwogCiBEUk9QIFRBQkxFIHRhYmxlX2ZpbGxmYWN0b3I7CiAKKy0tIFRlc3QgdGhh
dCB0aGUgc3RhdHNfcmVzZXQgY29sdW1uIGluIHBnX3N0YXRfZGF0YWJhc2VfY29uZmxpY3RzIGlz
IGNvcnJlY3RseSBtYWludGFpbmVkCitTRUxFQ1QgcGdfc3RhdF9yZXNldCgpOworU0VMRUNUIHN0
YXRzX3Jlc2V0IElTIE5PVCBOVUxMIEFTIGhhc19zdGF0c19yZXNldAorICBGUk9NIHBnX3N0YXRf
ZGF0YWJhc2VfY29uZmxpY3RzIFdIRVJFIGRhdG5hbWUgPSBjdXJyZW50X2RhdGFiYXNlKCk7CisK
IC0tIEVuZCBvZiBTdGF0cyBUZXN0Ci0tIAoyLjUzLjAuNDczLmc0YTc5NThjYTE0LWdvb2cKCg==
--000000000000968e62064cc0330d--