MIME-Version: 1.0
From: shihao zhong <zhong950419@gmail.com>
Date: Mon, 9 Mar 2026 18:11:33 -0400
Message-ID: 
 <CAGRkXqS98OebEWjax99_LVAECsxCB8i=BfsdAL34i-5QHfwyOQ@mail.gmail.com>
Subject: Add missing stats_reset column to pg_stat_database_conflicts view
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000003fd5a3064c9eb0d9"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGRkXqS98OebEWjax99_LVAECsxCB8i%3DBfsdAL34i-5QHfwyOQ%40mail.gmail.com>
Precedence: bulk

--0000000000003fd5a3064c9eb0d9
Content-Type: text/plain; charset="UTF-8"

Hi hackers,

Currently, pg_stat_database and pg_stat_database_conflicts are
decoupled into two separate views. However, there is an inconsistency:
pg_stat_database_conflicts is missing the stats_reset column.

Implementation wise, both views expose data from PgStat_StatDBEntry
and share the same reset lifecycle when pg_stat_reset() is called.

For now, users monitoring recovery conflicts have to get the reset
time from pg_stat_database. I would like these two views to be purely
decoupled to avoid such confusion.

The attached patch adds pg_stat_get_db_stat_reset_time() to fix this
inconsistency.

Please let me know your thoughts.

Thanks,
Shihao

--0000000000003fd5a3064c9eb0d9
Content-Type: application/octet-stream;
	name="pg_stat_database_conflict.patch"
Content-Disposition: attachment; filename="pg_stat_database_conflict.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmjqjduz0>
X-Attachment-Id: f_mmjqjduz0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbCBiL3NyYy9i
YWNrZW5kL2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbAotLS0gYS9zcmMvYmFja2VuZC9jYXRhbG9n
L3N5c3RlbV92aWV3cy5zcWwKKysrIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fdmlld3Mu
c3FsCkBAIC0xMTA5LDcgKzExMDksOCBAQCBDUkVBVEUgVklFVyBwZ19zdGF0X2RhdGFiYXNlX2Nv
bmZsaWN0cyBBUwogICAgICAgICAgICAgcGdfc3RhdF9nZXRfZGJfY29uZmxpY3Rfc25hcHNob3Qo
RC5vaWQpIEFTIGNvbmZsX3NuYXBzaG90LAogICAgICAgICAgICAgcGdfc3RhdF9nZXRfZGJfY29u
ZmxpY3RfYnVmZmVycGluKEQub2lkKSBBUyBjb25mbF9idWZmZXJwaW4sCiAgICAgICAgICAgICBw
Z19zdGF0X2dldF9kYl9jb25mbGljdF9zdGFydHVwX2RlYWRsb2NrKEQub2lkKSBBUyBjb25mbF9k
ZWFkbG9jaywKLSAgICAgICAgICAgIHBnX3N0YXRfZ2V0X2RiX2NvbmZsaWN0X2xvZ2ljYWxzbG90
KEQub2lkKSBBUyBjb25mbF9hY3RpdmVfbG9naWNhbHNsb3QKKyAgICAgICAgICAgIHBnX3N0YXRf
Z2V0X2RiX2NvbmZsaWN0X2xvZ2ljYWxzbG90KEQub2lkKSBBUyBjb25mbF9hY3RpdmVfbG9naWNh
bHNsb3QsCisgICAgICAgICAgICBwZ19zdGF0X2dldF9kYl9zdGF0X3Jlc2V0X3RpbWUoRC5vaWQp
IEFTIHN0YXRzX3Jlc2V0CiAgICAgRlJPTSBwZ19kYXRhYmFzZSBEOwogCiBDUkVBVEUgVklFVyBw
Z19zdGF0X3VzZXJfZnVuY3Rpb25zIEFTCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4
cGVjdGVkL3J1bGVzLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcnVsZXMub3V0Ci0t
LSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcnVsZXMub3V0CisrKyBiL3NyYy90ZXN0L3Jl
Z3Jlc3MvZXhwZWN0ZWQvcnVsZXMub3V0CkBAIC0xOTA0LDcgKzE5MDQsOCBAQCBwZ19zdGF0X2Rh
dGFiYXNlX2NvbmZsaWN0c3wgU0VMRUNUIG9pZCBBUyBkYXRpZCwKICAgICBwZ19zdGF0X2dldF9k
Yl9jb25mbGljdF9zbmFwc2hvdChvaWQpIEFTIGNvbmZsX3NuYXBzaG90LAogICAgIHBnX3N0YXRf
Z2V0X2RiX2NvbmZsaWN0X2J1ZmZlcnBpbihvaWQpIEFTIGNvbmZsX2J1ZmZlcnBpbiwKICAgICBw
Z19zdGF0X2dldF9kYl9jb25mbGljdF9zdGFydHVwX2RlYWRsb2NrKG9pZCkgQVMgY29uZmxfZGVh
ZGxvY2ssCi0gICAgcGdfc3RhdF9nZXRfZGJfY29uZmxpY3RfbG9naWNhbHNsb3Qob2lkKSBBUyBj
b25mbF9hY3RpdmVfbG9naWNhbHNsb3QKKyAgICBwZ19zdGF0X2dldF9kYl9jb25mbGljdF9sb2dp
Y2Fsc2xvdChvaWQpIEFTIGNvbmZsX2FjdGl2ZV9sb2dpY2Fsc2xvdCwKKyAgICBwZ19zdGF0X2dl
dF9kYl9zdGF0X3Jlc2V0X3RpbWUob2lkKSBBUyBzdGF0c19yZXNldAogICAgRlJPTSBwZ19kYXRh
YmFzZSBkOwogcGdfc3RhdF9nc3NhcGl8IFNFTEVDVCBwaWQsCiAgICAgZ3NzX2F1dGggQVMgZ3Nz
X2F1dGhlbnRpY2F0ZWQsCgo=
--0000000000003fd5a3064c9eb0d9--