MIME-Version: 1.0
From: Steve Chavez <steve@supabase.io>
Date: Mon, 23 Mar 2026 17:23:59 -0500
Message-ID: 
 <CAGRrpzYP+3zEk__KZu-a5uWySfwgRFk6eoPXKrA5AdtBTXR=ng@mail.gmail.com>
Subject: [PATCH] refactor ExecCheckPermissionsModified for ACL_SELECT
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000006c6a60064db87e20"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGRrpzYP%2B3zEk__KZu-a5uWySfwgRFk6eoPXKrA5AdtBTXR%3Dng%40mail.gmail.com>
Precedence: bulk

--0000000000006c6a60064db87e20
Content-Type: multipart/alternative; boundary="0000000000006c6a5f064db87e1e"

--0000000000006c6a5f064db87e1e
Content-Type: text/plain; charset="UTF-8"

Hello hackers,

Currently the code on ExecCheckOneRelPerms duplicates the logic in
ExecCheckPermissionsModified.

This change accommodates ExecCheckPermissionsModified to handle ACL_SELECT
and makes ExecCheckOneRelPerms reuse code. It also merges similar comments.

Main benefit is that it reduces LOCs and centralizes column privilege logic.

Best regards,
Steve Chavez

--0000000000006c6a5f064db87e1e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello hackers,<div><br></div><div>Currently the code on Ex=
ecCheckOneRelPerms duplicates the logic in ExecCheckPermissionsModified.<br=
><br>This change accommodates ExecCheckPermissionsModified to handle ACL_SE=
LECT and makes ExecCheckOneRelPerms reuse code. It also merges similar comm=
ents.<br><br>Main benefit is that it reduces LOCs and centralizes column pr=
ivilege logic.<br></div><div><br></div><div>Best regards,</div><div>Steve C=
havez</div></div>

--0000000000006c6a5f064db87e1e--

--0000000000006c6a60064db87e20
Content-Type: text/x-patch; charset="US-ASCII";
	name="0001-refactor-ExecCheckPermissionsModified-for-ACL_SELECT.patch"
Content-Disposition: attachment;
	filename="0001-refactor-ExecCheckPermissionsModified-for-ACL_SELECT.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn3r3yaf0>
X-Attachment-Id: f_mn3r3yaf0

RnJvbSA2MTExZDJlMDI0ODdlNmRlNjcyNmM2YTVmZTI3NDZjZTdmOWQ1NTlmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBzdGV2ZS1jaGF2ZXogPHN0ZXZlY2hhdmV6YXN0QGdtYWlsLmNv
bT4KRGF0ZTogTW9uLCAyMyBNYXIgMjAyNiAxNzowODo0MSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hd
IHJlZmFjdG9yIEV4ZWNDaGVja1Blcm1pc3Npb25zTW9kaWZpZWQgZm9yIEFDTF9TRUxFQ1QKCkN1
cnJlbnRseSB0aGUgY29kZSBvbiBFeGVjQ2hlY2tPbmVSZWxQZXJtcyBkdXBsaWNhdGVzIHRoZSBs
b2dpYwppbiBFeGVjQ2hlY2tQZXJtaXNzaW9uc01vZGlmaWVkLgoKVGhpcyBjaGFuZ2UgYWNjb21t
b2RhdGVzIEV4ZWNDaGVja1Blcm1pc3Npb25zTW9kaWZpZWQgdG8gaGFuZGxlCkFDTF9TRUxFQ1Qg
YW5kIG1ha2VzIEV4ZWNDaGVja09uZVJlbFBlcm1zIHJldXNlIGNvZGUuIEl0IGFsc28gbWVyZ2Vz
CnNpbWlsYXIgY29tbWVudHMuCgpNYWluIGJlbmVmaXQgaXMgdGhhdCBpdCByZWR1Y2VzIExPQ3Mg
YW5kIGNlbnRyYWxpemVzIGNvbHVtbiBwcml2aWxlZ2UKbG9naWMuCi0tLQogc3JjL2JhY2tlbmQv
ZXhlY3V0b3IvZXhlY01haW4uYyB8IDcwICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LQogMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDQ2IGRlbGV0aW9ucygtKQoKZGlm
ZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNNYWluLmMgYi9zcmMvYmFja2VuZC9l
eGVjdXRvci9leGVjTWFpbi5jCmluZGV4IDU4Yjg0OTU1YzJiLi5jMWNjODI1MTE4NiAxMDA2NDQK
LS0tIGEvc3JjL2JhY2tlbmQvZXhlY3V0b3IvZXhlY01haW4uYworKysgYi9zcmMvYmFja2VuZC9l
eGVjdXRvci9leGVjTWFpbi5jCkBAIC02NzYsOCArNjc2LDYgQEAgRXhlY0NoZWNrT25lUmVsUGVy
bXMoUlRFUGVybWlzc2lvbkluZm8gKnBlcm1pbmZvKQogCXJlbWFpbmluZ1Blcm1zID0gcmVxdWly
ZWRQZXJtcyAmIH5yZWxQZXJtczsKIAlpZiAocmVtYWluaW5nUGVybXMgIT0gMCkKIAl7Ci0JCWlu
dAkJCWNvbCA9IC0xOwotCiAJCS8qCiAJCSAqIElmIHdlIGxhY2sgYW55IHBlcm1pc3Npb25zIHRo
YXQgZXhpc3Qgb25seSBhcyByZWxhdGlvbiBwZXJtaXNzaW9ucywKIAkJICogd2UgY2FuIGZhaWwg
c3RyYWlnaHQgYXdheS4KQEAgLTY5Miw0NSArNjkwLDEzIEBAIEV4ZWNDaGVja09uZVJlbFBlcm1z
KFJURVBlcm1pc3Npb25JbmZvICpwZXJtaW5mbykKIAkJICogdG8gcmVwb3J0IGEgY29sdW1uLWxl
dmVsIGVycm9yIGlmIHdlIGhhdmUgc29tZSBidXQgbm90IGFsbCBvZiB0aGUKIAkJICogY29sdW1u
IHByaXZpbGVnZXMuCiAJCSAqLwotCQlpZiAocmVtYWluaW5nUGVybXMgJiBBQ0xfU0VMRUNUKQot
CQl7Ci0JCQkvKgotCQkJICogV2hlbiB0aGUgcXVlcnkgZG9lc24ndCBleHBsaWNpdGx5IHJlZmVy
ZW5jZSBhbnkgY29sdW1ucyAoZm9yCi0JCQkgKiBleGFtcGxlLCBTRUxFQ1QgQ09VTlQoKikgRlJP
TSB0YWJsZSksIGFsbG93IHRoZSBxdWVyeSBpZiB3ZQotCQkJICogaGF2ZSBTRUxFQ1Qgb24gYW55
IGNvbHVtbiBvZiB0aGUgcmVsLCBhcyBwZXIgU1FMIHNwZWMuCi0JCQkgKi8KLQkJCWlmIChibXNf
aXNfZW1wdHkocGVybWluZm8tPnNlbGVjdGVkQ29scykpCi0JCQl7Ci0JCQkJaWYgKHBnX2F0dHJp
YnV0ZV9hY2xjaGVja19hbGwocmVsT2lkLCB1c2VyaWQsIEFDTF9TRUxFQ1QsCi0JCQkJCQkJCQkJ
CSAgQUNMTUFTS19BTlkpICE9IEFDTENIRUNLX09LKQotCQkJCQlyZXR1cm4gZmFsc2U7Ci0JCQl9
Ci0KLQkJCXdoaWxlICgoY29sID0gYm1zX25leHRfbWVtYmVyKHBlcm1pbmZvLT5zZWxlY3RlZENv
bHMsIGNvbCkpID49IDApCi0JCQl7Ci0JCQkJLyogYml0ICNzIGFyZSBvZmZzZXQgYnkgRmlyc3RM
b3dJbnZhbGlkSGVhcEF0dHJpYnV0ZU51bWJlciAqLwotCQkJCUF0dHJOdW1iZXIJYXR0bm8gPSBj
b2wgKyBGaXJzdExvd0ludmFsaWRIZWFwQXR0cmlidXRlTnVtYmVyOwotCi0JCQkJaWYgKGF0dG5v
ID09IEludmFsaWRBdHRyTnVtYmVyKQotCQkJCXsKLQkJCQkJLyogV2hvbGUtcm93IHJlZmVyZW5j
ZSwgbXVzdCBoYXZlIHByaXYgb24gYWxsIGNvbHMgKi8KLQkJCQkJaWYgKHBnX2F0dHJpYnV0ZV9h
Y2xjaGVja19hbGwocmVsT2lkLCB1c2VyaWQsIEFDTF9TRUxFQ1QsCi0JCQkJCQkJCQkJCQkgIEFD
TE1BU0tfQUxMKSAhPSBBQ0xDSEVDS19PSykKLQkJCQkJCXJldHVybiBmYWxzZTsKLQkJCQl9Ci0J
CQkJZWxzZQotCQkJCXsKLQkJCQkJaWYgKHBnX2F0dHJpYnV0ZV9hY2xjaGVjayhyZWxPaWQsIGF0
dG5vLCB1c2VyaWQsCi0JCQkJCQkJCQkJCSAgQUNMX1NFTEVDVCkgIT0gQUNMQ0hFQ0tfT0spCi0J
CQkJCQlyZXR1cm4gZmFsc2U7Ci0JCQkJfQotCQkJfQotCQl9CisJCWlmIChyZW1haW5pbmdQZXJt
cyAmIEFDTF9TRUxFQ1QgJiYKKwkJCSFFeGVjQ2hlY2tQZXJtaXNzaW9uc01vZGlmaWVkKHJlbE9p
ZCwKKwkJCQkJCQkJCQkgIHVzZXJpZCwKKwkJCQkJCQkJCQkgIHBlcm1pbmZvLT5zZWxlY3RlZENv
bHMsCisJCQkJCQkJCQkJICBBQ0xfU0VMRUNUKSkKKwkJCXJldHVybiBmYWxzZTsKCi0JCS8qCi0J
CSAqIEJhc2ljYWxseSB0aGUgc2FtZSBmb3IgdGhlIG1vZCBjb2x1bW5zLCBmb3IgYm90aCBJTlNF
UlQgYW5kIFVQREFURQotCQkgKiBwcml2aWxlZ2UgYXMgc3BlY2lmaWVkIGJ5IHJlbWFpbmluZ1Bl
cm1zLgotCQkgKi8KIAkJaWYgKHJlbWFpbmluZ1Blcm1zICYgQUNMX0lOU0VSVCAmJgogCQkJIUV4
ZWNDaGVja1Blcm1pc3Npb25zTW9kaWZpZWQocmVsT2lkLAogCQkJCQkJCQkJCSAgdXNlcmlkLApA
QCAtNzUwLDcgKzcxNiw3IEBAIEV4ZWNDaGVja09uZVJlbFBlcm1zKFJURVBlcm1pc3Npb25JbmZv
ICpwZXJtaW5mbykKCiAvKgogICogRXhlY0NoZWNrUGVybWlzc2lvbnNNb2RpZmllZAotICoJCUNo
ZWNrIElOU0VSVCBvciBVUERBVEUgYWNjZXNzIHBlcm1pc3Npb25zIGZvciBhIHNpbmdsZSByZWxh
dGlvbiAodGhlc2UKKyAqCQlDaGVjayBTRUxFQ1QsIElOU0VSVCBvciBVUERBVEUgYWNjZXNzIHBl
cm1pc3Npb25zIGZvciBhIHNpbmdsZSByZWxhdGlvbiAodGhlc2UKICAqCQlhcmUgcHJvY2Vzc2Vk
IHVuaWZvcm1seSkuCiAgKi8KIHN0YXRpYyBib29sCkBAIC03NjAsOSArNzI2LDExIEBAIEV4ZWND
aGVja1Blcm1pc3Npb25zTW9kaWZpZWQoT2lkIHJlbE9pZCwgT2lkIHVzZXJpZCwgQml0bWFwc2V0
ICptb2RpZmllZENvbHMsCiAJaW50CQkJY29sID0gLTE7CgogCS8qCi0JICogV2hlbiB0aGUgcXVl
cnkgZG9lc24ndCBleHBsaWNpdGx5IHVwZGF0ZSBhbnkgY29sdW1ucywgYWxsb3cgdGhlIHF1ZXJ5
Ci0JICogaWYgd2UgaGF2ZSBwZXJtaXNzaW9uIG9uIGFueSBjb2x1bW4gb2YgdGhlIHJlbC4gIFRo
aXMgaXMgdG8gaGFuZGxlCi0JICogU0VMRUNUIEZPUiBVUERBVEUgYXMgd2VsbCBhcyBwb3NzaWJs
ZSBjb3JuZXIgY2FzZXMgaW4gVVBEQVRFLgorCSAqIFdoZW4gdGhlIHF1ZXJ5IGRvZXNuJ3QgZXhw
bGljaXRseSByZWZlcmVuY2UgYW55IGNvbHVtbnMgKGZvcgorCSAqIGV4YW1wbGUsIFNFTEVDVCBD
T1VOVCgqKSBGUk9NIHRhYmxlIG9yIElOU0VSVCBERUZBVUxUIFZBTFVFUyksCisgICAqIGFsbG93
IHRoZSBxdWVyeSBpZiB3ZSBoYXZlIHBlcm1pc3Npb24gb24gYW55IGNvbHVtbiBvZiB0aGUgcmVs
LCBhcyBwZXIgU1FMIHNwZWMuCisJICoKKwkgKiBUaGlzIGhhbmRsZXMgU0VMRUNUIEZPUiBVUERB
VEUgYXMgd2VsbCBhcyBwb3NzaWJsZSBjb3JuZXIgY2FzZXMgaW4gVVBEQVRFLgogCSAqLwogCWlm
IChibXNfaXNfZW1wdHkobW9kaWZpZWRDb2xzKSkKIAl7CkBAIC03NzYsMTAgKzc0NCwyMCBAQCBF
eGVjQ2hlY2tQZXJtaXNzaW9uc01vZGlmaWVkKE9pZCByZWxPaWQsIE9pZCB1c2VyaWQsIEJpdG1h
cHNldCAqbW9kaWZpZWRDb2xzLAogCQkvKiBiaXQgI3MgYXJlIG9mZnNldCBieSBGaXJzdExvd0lu
dmFsaWRIZWFwQXR0cmlidXRlTnVtYmVyICovCiAJCUF0dHJOdW1iZXIJYXR0bm8gPSBjb2wgKyBG
aXJzdExvd0ludmFsaWRIZWFwQXR0cmlidXRlTnVtYmVyOwoKKwkJLyogV2hvbGUtcm93IHJlZmVy
ZW5jZSwgbXVzdCBoYXZlIHByaXYgb24gYWxsIGNvbHMgKi8KIAkJaWYgKGF0dG5vID09IEludmFs
aWRBdHRyTnVtYmVyKQogCQl7Ci0JCQkvKiB3aG9sZS1yb3cgcmVmZXJlbmNlIGNhbid0IGhhcHBl
biBoZXJlICovCi0JCQllbG9nKEVSUk9SLCAid2hvbGUtcm93IHVwZGF0ZSBpcyBub3QgaW1wbGVt
ZW50ZWQiKTsKKworCQkJLyogSW4gdGhlIGNhc2Ugb2YgU0VMRUNUICogd2UgaGF2ZSB0byBjaGVj
ayBmb3IgYWxsIGNvbHVtbiBwZXJtaXNzaW9ucyAqLworCQkJaWYgKHJlcXVpcmVkUGVybXMgPT0g
QUNMX1NFTEVDVCkKKwkJCXsKKwkJCQlpZiAocGdfYXR0cmlidXRlX2FjbGNoZWNrX2FsbChyZWxP
aWQsIHVzZXJpZCwgcmVxdWlyZWRQZXJtcywKKwkJCQkJCQkJCQkJICBBQ0xNQVNLX0FMTCkgIT0g
QUNMQ0hFQ0tfT0spCisJCQkJCXJldHVybiBmYWxzZTsKKwkJCX0KKwkJCWVsc2UKKwkJCQkvKiB3
aG9sZS1yb3cgcmVmZXJlbmNlIGNhbid0IGhhcHBlbiBoZXJlICovCisJCQkJZWxvZyhFUlJPUiwg
Indob2xlLXJvdyB1cGRhdGUgaXMgbm90IGltcGxlbWVudGVkIik7CiAJCX0KIAkJZWxzZQogCQl7
Ci0tCjIuNDAuMQoK
--0000000000006c6a60064db87e20--