MIME-Version: 1.0
References: <CACG=ezaWg7_nt-8ey4aKv2w9LcuLthHknwCawmBgEeTnJrJTcw@mail.gmail.com>
 <CACG=ezaMncd0-BcGHBgsSR2eqHfrz9WznHGLKX8biz6zu-azGw@mail.gmail.com>
 <5ecc35f5-1111-47fc-8a02-36d89490a50d@iki.fi> <CACG=ezb9XTvd3ZmS0y8gUunx_wBBdJO7ou+BfCOnnA5jE-11vg@mail.gmail.com>
 <CACG=ezYFNqGjsxF6Vb2CHF6JzKcjhAFauaFm9js0nu_3Ngcdkw@mail.gmail.com>
 <CAGjGUA+dcV7veaCV1H65vCNsbS++nT8=ho772gDvsXUW9H7eXQ@mail.gmail.com>
 <CACG=ezYThNkf8QsDA-aQfEFEkqn2L=_uUL83z0vJstPRasbZqg@mail.gmail.com>
 <24b3deb6-a732-4256-847a-560f4bf39d59@iki.fi> <CACG=ezYtCatcRODS-ZkwhcxuqBKCuhEsZGBruw=dGCLoepF+ZA@mail.gmail.com>
 <ca451a6a-5b0f-433c-8ab9-b28b7f480bd7@iki.fi> <CACG=ezb680eb=JXh1ns=t5eGH3h9y-uTfT4tf3Xc8t2UH2q6tQ@mail.gmail.com>
 <CACG=ezZGQFBb0yepka8hU2BmJ48ujt3xa+aYLNL0BQPx0vqwZg@mail.gmail.com>
 <CACG=ezajc_Pcqmy6fcq-N8+LzCRMzOzJzez2_BgHEu-6RVJtKQ@mail.gmail.com>
 <4535f3aa-3220-4760-b1f5-2bc91f248e03@iki.fi> <CACG=ezbKwypBp=14q9+hMQApus3=1hKxJ9x1+KinUhtT48570Q@mail.gmail.com>
 <2bc58592-9d74-4af0-bdd1-1a88e8683f7c@iki.fi> <CACG=ezZwdvsijzuXE3hex3xHcoz75EQYBXRTsQJVwbo5J5sS3g@mail.gmail.com>
 <CACG=ezbs912S58=uR17b4w8uuWv1=OcCRaTW_OWdFm4+tXZA6w@mail.gmail.com>
In-Reply-To: <CACG=ezbs912S58=uR17b4w8uuWv1=OcCRaTW_OWdFm4+tXZA6w@mail.gmail.com>
From: wenhui qiu <qiuwenhuifx@gmail.com>
Date: Tue, 21 Jan 2025 11:35:33 +0800
Message-ID: <CAGjGUA+BfcWyccNN4=tHsW_E-koRxbg8h8ut6hjvPsHMgmek6w@mail.gmail.com>
Subject: Re: POC: make mxidoff 64 bits
To: Maxim Orlov <orlovmg@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Alexander Korotkov <aekorotkov@gmail.com>, 
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000684b96062c2f1265"
Archived-At: <https://www.postgresql.org/message-id/CAGjGUA%2BBfcWyccNN4%3DtHsW_E-koRxbg8h8ut6hjvPsHMgmek6w%40mail.gmail.com>
Precedence: bulk

--000000000000684b96062c2f1265
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

HI Maxim
> Looks like there is a bit of a pause in the discussion. Here is a small
update. Consider v12.
> No major changes, rebase to the actual master and a squash of multiple
commits to make a
> patch set easy to reviewer.

> AFAICs, we are reached a consensus on a core patch for switching to 64
bits offsets. The
> only concern is about more comprehensive test coverage for pg_upgrade, is
it?
Agree ,When upgrading meets extremes (oldestOffsetKnown=3D=3Dfalse.) Just
follow the solution mentioned by Heikki Linnakangas.

Thanks

On Thu, Jan 16, 2025 at 9:32=E2=80=AFPM Maxim Orlov <orlovmg@gmail.com> wro=
te:

> Looks like there is a bit of a pause in the discussion. Here is a small
> update. Consider v12.
> No major changes, rebase to the actual master and a squash of multiple
> commits to make a
> patch set easy to reviewer.
>
> AFAICs, we are reached a consensus on a core patch for switching to 64
> bits offsets. The
> only concern is about more comprehensive test coverage for pg_upgrade, is
> it?
>
> --
> Best regards,
> Maxim Orlov.
>

--000000000000684b96062c2f1265
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">HI Maxim=C2=A0<div><div>&gt; Looks like there is a bit of =
a pause in the discussion. Here is a small update. Consider v12.</div><div>=
&gt; No major changes, rebase to the actual master and a squash of multiple=
 commits to make a</div><div>&gt; patch set easy to reviewer.<br><br>&gt; A=
FAICs, we are reached a consensus on a core patch for switching to 64 bits =
offsets. The</div><div>&gt; only concern is about more comprehensive test c=
overage for pg_upgrade, is it?</div></div><div>Agree ,When upgrading meets =
extremes (<span style=3D"color:rgb(80,0,80)">oldestOffsetKnown=3D=3Dfalse.)=
=C2=A0</span>Just follow the solution mentioned by Heikki Linnakangas.</div=
><div><br></div><div>Thanks</div></div><br><div class=3D"gmail_quote gmail_=
quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 16, 2025=
 at 9:32=E2=80=AFPM Maxim Orlov &lt;<a href=3D"mailto:orlovmg@gmail.com">or=
lovmg@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:so=
lid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><=
div>Looks like there is a bit of a pause in the discussion. Here is a small=
 update. Consider v12.</div><div>No major changes, rebase to the actual mas=
ter and a squash of multiple commits to make a</div><div>patch set easy to =
reviewer.<br><br>AFAICs, we are reached a consensus on a core patch for swi=
tching to 64 bits offsets. The</div><div>only concern is about more compreh=
ensive test coverage for pg_upgrade, is it?</div><br><span class=3D"gmail_s=
ignature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><=
div dir=3D"ltr"><div>Best regards,<br></div><div>Maxim Orlov.</div></div></=
div></div>
</blockquote></div>

--000000000000684b96062c2f1265--