public inbox for [email protected]
help / color / mirror / Atom feedFrom: wenhui qiu <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Maxim Orlov <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: POC: make mxidoff 64 bits
Date: Tue, 18 Nov 2025 09:47:45 +0800
Message-ID: <CAGjGUA+iGwFS8MDCTSZg7-E_H792N8XWia=Q7tx4mE14T=r6xA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CACG=ezaWg7_nt-8ey4aKv2w9LcuLthHknwCawmBgEeTnJrJTcw@mail.gmail.com>
<CACG=ezZGQFBb0yepka8hU2BmJ48ujt3xa+aYLNL0BQPx0vqwZg@mail.gmail.com>
<CACG=ezajc_Pcqmy6fcq-N8+LzCRMzOzJzez2_BgHEu-6RVJtKQ@mail.gmail.com>
<[email protected]>
<CACG=ezbKwypBp=14q9+hMQApus3=1hKxJ9x1+KinUhtT48570Q@mail.gmail.com>
<[email protected]>
<CACG=ezZwdvsijzuXE3hex3xHcoz75EQYBXRTsQJVwbo5J5sS3g@mail.gmail.com>
<CACG=ezbs912S58=uR17b4w8uuWv1=OcCRaTW_OWdFm4+tXZA6w@mail.gmail.com>
<CAGjGUA+BfcWyccNN4=tHsW_E-koRxbg8h8ut6hjvPsHMgmek6w@mail.gmail.com>
<CACG=ezYbYO_KHWdeDedbDcY0tOS0JfaqBxG3=bG5+DdsDK4MpQ@mail.gmail.com>
<CACG=ezYpZRPwoRCz_h3Qerd3XJNdpTHCpwGbZphNdy26tA4_qQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<CACG=ezYUJSvnuxntkURNWo_1vZ+AtmcQfqd_h6WgDzGaudfw+Q@mail.gmail.com>
<[email protected]>
<[email protected]>
Hi Heikki
> I don't think we need to support that case. I hope there are no clusters
> in that state still in the wild, and you can work around it by upgrading
> to 9.3.5 or above and letting autovacuum run. But I wonder if a
> pre-upgrade check with a better error message would still be worthwhile.
I think we believe it is now highly unlikely to find instances of version
9.3; all users are advised to upgrade to the latest version first.
Thanks
On Tue, Nov 18, 2025 at 12:35 AM Heikki Linnakangas <[email protected]> wrote:
> Here's yet another patch version. I spent the day reviewing this in
> detail and doing little cleanups here and there. I squashed the commits
> and wrote a proper commit message.
>
> One noteworthy refactoring is in pg_upgrade.c, to make it more clear (to
> me at least) how upgrade from version 9.2 and below now works. It was
> actually broken when I tested it. Not sure if I had broken it earlier or
> if it never worked, but in any case it works now.
>
> I also tested upgrading a cluster from an old minor version, < 9.3.5,
> where the control file has a bogus oldestMultiXid==1 value (see commit
> b6a3444fa6). As expected, you get a "could not open file" error:
>
> > Performing Upgrade
> > ------------------
> > Setting locale and encoding for new cluster ok
> > ...
> > Deleting files from new pg_multixact/members ok
> > Deleting files from new pg_multixact/offsets ok
> > Converting pg_multixact files
> > could not open file
> "/home/heikki/pgsql.93stable/data/pg_multixact/offsets/0000": No such file
> or directory
> > Failure, exiting
>
> I don't think we need to support that case. I hope there are no clusters
> in that state still in the wild, and you can work around it by upgrading
> to 9.3.5 or above and letting autovacuum run. But I wonder if a
> pre-upgrade check with a better error message would still be worthwhile.
>
>
> Ashutosh, you were interested in reviewing this earlier. Would you have
> a chance to review this now, before I commit it? Alexander, Alvaro,
> would you have a chance to take a final look too, please?
>
> - Heikki
>
view thread (79+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: POC: make mxidoff 64 bits
In-Reply-To: <CAGjGUA+iGwFS8MDCTSZg7-E_H792N8XWia=Q7tx4mE14T=r6xA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox