MIME-Version: 1.0
References: 
 <CAJ7c6TOQq=R5MmrbkrGYdqTQEaaoEgMq-ZraXPjkdCJ60oJcaQ@mail.gmail.com>
 <dbe56aa6-76df-4824-a621-ffb890dbbfde@yeah.net>
In-Reply-To: <dbe56aa6-76df-4824-a621-ffb890dbbfde@yeah.net>
From: wenhui qiu <qiuwenhuifx@gmail.com>
Date: Mon, 27 Oct 2025 17:50:21 +0800
Message-ID: 
 <CAGjGUAJJCO0cYA297226epqwfj+UutGnYUigng9riApJo+pm=Q@mail.gmail.com>
Subject: Re: [PATCH] Little refactoring of portalcmds.c
Cc: Aleksander Alekseev <aleksander@tigerdata.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000a1c0de064220d481"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGjGUAJJCO0cYA297226epqwfj%2BUutGnYUigng9riApJo%2Bpm%3DQ%40mail.gmail.com>
Precedence: bulk

--000000000000a1c0de064220d481
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Aleksander Alekseev
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
I  agree with your suggestion to refactor the duplicated code into a
function.

Thanks

On Mon, Oct 27, 2025 at 2:03=E2=80=AFPM Quan Zongliang <quanzongliang@yeah.=
net>
wrote:

>
>
> On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> > Hi,
> >
> > The proposed patch places some repetitive code in a helper function.
> > The value of this change is arguably not that high but it makes the
> > code a bit neater IMO.
> >
>
> It also reduces the ease of reading the code.
> Just add a function for a single if statement. I don't think it's
> necessary.
>
> Regards,
> Quan Zongliang
>
>
>
>

--000000000000a1c0de064220d481
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0<span style=3D"white-space:nowrap;color:rgba(0,0,0=
,0.87);font-family:Roboto,RobotoDraft,Helvetica,Arial,sans-serif;font-size:=
18px;background-color:rgb(248,250,253)">Aleksander Alekseev</span><div>&gt;=
 The proposed patch places some repetitive code in a helper function.<br>&g=
t; The value of this change is arguably not that high but it makes the<br>&=
gt; code a bit neater IMO.=C2=A0<br></div><div>I =C2=A0agree with your sugg=
estion to refactor the duplicated code into a function.</div><div><br></div=
><div>Thanks=C2=A0</div></div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Mon, Oct 27, 2025 at 2:03=E2=80=AFPM Quan Zongli=
ang &lt;<a href=3D"mailto:quanzongliang@yeah.net" target=3D"_blank">quanzon=
gliang@yeah.net</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:so=
lid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
<br>
On 10/8/25 10:02 PM, Aleksander Alekseev wrote:<br>
&gt; Hi,<br>
&gt; <br>
&gt; The proposed patch places some repetitive code in a helper function.<b=
r>
&gt; The value of this change is arguably not that high but it makes the<br=
>
&gt; code a bit neater IMO.<br>
&gt; <br>
<br>
It also reduces the ease of reading the code.<br>
Just add a function for a single if statement. I don&#39;t think it&#39;s n=
ecessary.<br>
<br>
Regards,<br>
Quan Zongliang<br>
<br>
<br>
<br>
</blockquote></div>

--000000000000a1c0de064220d481--