public inbox for [email protected]  

help / color / mirror / Atom feed

From: wenhui qiu <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Japin Li <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Remove deprecated role membership options from psql help for CREATE USER/GROUP
Date: Tue, 6 Jan 2026 22:33:23 +0800
Message-ID: <CAGjGUAKxrSHkCwBZtTV6pkNxQDi7cZcSyGZG0a57dgP9TDB2bA@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwGgJuvq3GPF2ReKoX3gX2uNyvtf2XSeyKYFhfQibcuBbg@mail.gmail.com>
References: <MEAPR01MB3031C30E72EF16CFC08C8565B687A@MEAPR01MB3031.ausprd01.prod.outlook.com>
	<CAHGQGwGgJuvq3GPF2ReKoX3gX2uNyvtf2XSeyKYFhfQibcuBbg@mail.gmail.com>

+1，it need to be fix

On Tue, 6 Jan 2026 at 22:27, Fujii Masao <[email protected]> wrote:

> On Tue, Jan 6, 2026 at 7:16 PM Japin Li <[email protected]> wrote:
> >
> >
> > Hi,
> >
> > When I review [1], I found commit 8e78f0a1 deprecated the IN GROUP and
> USER
> > clauses in CREATE ROLE, and also removed IN GROUP and USER from the psql
> \h
> > CREATE ROLE help output.
> >
> > However, the psql help for the legacy synonyms CREATE USER and CREATE
> GROUP
> > still lists the deprecated options:
> >
> > - IN GROUP role_name [, ...]
> > - USER role_name [, ...]
> >
> > postgres=# \h create role
> > Command:     CREATE ROLE
> > Description: define a new database role
> > Syntax:
> > CREATE ROLE name [ [ WITH ] option [ ... ] ]
> >
> > where option can be:
> >
> >       SUPERUSER | NOSUPERUSER
> >     | CREATEDB | NOCREATEDB
> >     | CREATEROLE | NOCREATEROLE
> >     | INHERIT | NOINHERIT
> >     | LOGIN | NOLOGIN
> >     | REPLICATION | NOREPLICATION
> >     | BYPASSRLS | NOBYPASSRLS
> >     | CONNECTION LIMIT connlimit
> >     | [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
> >     | VALID UNTIL 'timestamp'
> >     | IN ROLE role_name [, ...]
> >     | ROLE role_name [, ...]
> >     | ADMIN role_name [, ...]
> >     | SYSID uid
> >
> > URL: https://www.postgresql.org/docs/devel/sql-createrole.html
> >
> > postgres=# \h create user
> > Command:     CREATE USER
> > Description: define a new database role
> > Syntax:
> > CREATE USER name [ [ WITH ] option [ ... ] ]
> >
> > where option can be:
> >
> >       SUPERUSER | NOSUPERUSER
> >     | CREATEDB | NOCREATEDB
> >     | CREATEROLE | NOCREATEROLE
> >     | INHERIT | NOINHERIT
> >     | LOGIN | NOLOGIN
> >     | REPLICATION | NOREPLICATION
> >     | BYPASSRLS | NOBYPASSRLS
> >     | CONNECTION LIMIT connlimit
> >     | [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
> >     | VALID UNTIL 'timestamp'
> >     | IN ROLE role_name [, ...]
> >     | IN GROUP role_name [, ...]
> >     | ROLE role_name [, ...]
> >     | ADMIN role_name [, ...]
> >     | USER role_name [, ...]
> >     | SYSID uid
> >
> > URL: https://www.postgresql.org/docs/devel/sql-createuser.html
> >
> > postgres=# \h create group
> > Command:     CREATE GROUP
> > Description: define a new database role
> > Syntax:
> > CREATE GROUP name [ [ WITH ] option [ ... ] ]
> >
> > where option can be:
> >
> >       SUPERUSER | NOSUPERUSER
> >     | CREATEDB | NOCREATEDB
> >     | CREATEROLE | NOCREATEROLE
> >     | INHERIT | NOINHERIT
> >     | LOGIN | NOLOGIN
> >     | REPLICATION | NOREPLICATION
> >     | BYPASSRLS | NOBYPASSRLS
> >     | CONNECTION LIMIT connlimit
> >     | [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
> >     | VALID UNTIL 'timestamp'
> >     | IN ROLE role_name [, ...]
> >     | IN GROUP role_name [, ...]
> >     | ROLE role_name [, ...]
> >     | ADMIN role_name [, ...]
> >     | USER role_name [, ...]
> >     | SYSID uid
> >
> > URL: https://www.postgresql.org/docs/devel/sql-creategroup.html
> >
> > Since CREATE USER is documented as equivalent to CREATE ROLE WITH LOGIN,
> and
> > CREATE GROUP is equivalent to CREATE ROLE, their help syntax should
> remain
> > consistent with CREATE ROLE.
> >
> > I propose removing the deprecated IN GROUP and USER lines from the help
> text
> > of both CREATE USER and CREATE GROUP. This would be a simple
> documentation
> > cleanup that aligns the psql help with current reality and avoids
> confusing
> > users with obsolete syntax.
>
> +1
> The patch looks good to me.
>
> Regards,
>
> --
> Fujii Masao
>
>
>

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Remove deprecated role membership options from psql help for CREATE USER/GROUP
  In-Reply-To: <CAGjGUAKxrSHkCwBZtTV6pkNxQDi7cZcSyGZG0a57dgP9TDB2bA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox