MIME-Version: 1.0
References: 
 <CAMbWs48JC4OVqE=3gMB6se2WmRNNfMyFyYxm-09vgpm+Vwe8Hg@mail.gmail.com>
 <7f6439c7-e5a7-4d0c-82c9-4087794cd9d0@gmail.com>
 <CAGjGUAKZ-gaT6z=4_BR8J5Xq7c85ckWuZ3_sHUo6oseto6npHA@mail.gmail.com>
 <CAMbWs48RYf3dDS4P+HC43x-KLrN0uF-aU-Mk0Ld5JoWGErOqUg@mail.gmail.com>
In-Reply-To: 
 <CAMbWs48RYf3dDS4P+HC43x-KLrN0uF-aU-Mk0Ld5JoWGErOqUg@mail.gmail.com>
From: wenhui qiu <qiuwenhuifx@gmail.com>
Date: Mon, 20 Apr 2026 08:49:25 +0800
Message-ID: 
 <CAGjGUALwC9uRxqvmQSk9Cg5VR2qewTuKe+=seXmynPP4PwFsDQ@mail.gmail.com>
Subject: Re: Clean up remove_rel_from_query() after self-join elimination
 commit
To: Richard Guo <guofenglinux@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000498544064fd9ac04"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGjGUALwC9uRxqvmQSk9Cg5VR2qewTuKe%2B%3DseXmynPP4PwFsDQ%40mail.gmail.com>
Precedence: bulk

--000000000000498544064fd9ac04
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Richard
> Assert(!is_outer_join || joinrelids !=3D NULL);

> Worth asserting.  If a caller sets sjinfo but passes NULL for
> joinrelids, this would silently over-delete PHVs.
> Assert(!is_self_join || joinrelids =3D=3D NULL);

LGTM with the added assertion. Thanks again for all the heavy lifting
you're doing on the Postgres optimizer

> I prefer to not add this one.  It's not defending any invariant.
Thank you for your explanation ,


Thanks

On Sat, Apr 18, 2026 at 6:17=E2=80=AFPM Richard Guo <guofenglinux@gmail.com=
> wrote:

> On Tue, Apr 7, 2026 at 6:57=E2=80=AFPM wenhui qiu <qiuwenhuifx@gmail.com>=
 wrote:
> > Assert(!is_outer_join || joinrelids !=3D NULL);
>
> Worth asserting.  If a caller sets sjinfo but passes NULL for
> joinrelids, this would silently over-delete PHVs.
>
> > Assert(!is_self_join || joinrelids =3D=3D NULL);
>
> I prefer to not add this one.  It's not defending any invariant.
>
> - Richard
>

--000000000000498544064fd9ac04
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Richard<div>&gt; Assert(!is_outer_join || joinreli=
ds !=3D NULL);<br><br>&gt; Worth asserting.=C2=A0 If a caller sets sjinfo b=
ut passes NULL for<br>&gt; joinrelids, this would silently over-delete PHVs=
.<br></div><div>&gt; Assert(!is_self_join || joinrelids =3D=3D NULL);</div>=
<div><br>LGTM with the added assertion. Thanks again for all the heavy lift=
ing you&#39;re doing on the Postgres optimizer<br></div><div><br>&gt; I pre=
fer to not add this one.=C2=A0 It&#39;s not defending any invariant.<br></d=
iv><div>Thank you for your explanation ,=C2=A0</div><div><br></div><div><br=
></div><div>Thanks</div></div><br><div class=3D"gmail_quote gmail_quote_con=
tainer"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 18, 2026 at 6:17=
=E2=80=AFPM Richard Guo &lt;<a href=3D"mailto:guofenglinux@gmail.com">guofe=
nglinux@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex">On Tue, Apr 7, 2026 at 6:57=E2=80=AFPM wenhui qiu &lt;<a h=
ref=3D"mailto:qiuwenhuifx@gmail.com" target=3D"_blank">qiuwenhuifx@gmail.co=
m</a>&gt; wrote:<br>
&gt; Assert(!is_outer_join || joinrelids !=3D NULL);<br>
<br>
Worth asserting.=C2=A0 If a caller sets sjinfo but passes NULL for<br>
joinrelids, this would silently over-delete PHVs.<br>
<br>
&gt; Assert(!is_self_join || joinrelids =3D=3D NULL);<br>
<br>
I prefer to not add this one.=C2=A0 It&#39;s not defending any invariant.<b=
r>
<br>
- Richard<br>
</blockquote></div>

--000000000000498544064fd9ac04--