MIME-Version: 1.0
References: 
 <CAGnOmWqi1D9ycBgUeOGf6mOCd2Dcf=6sKhbf4sHLs5xAcKVCMQ@mail.gmail.com>
 <CABXr29GbJe7-vbm0Fn=HWx3vQonwFtv_zO1pSc5FZAvjLuUDVA@mail.gmail.com>
 <CABXr29Epj=23eYAWg_mTdiXYQQzJSVN22uk6tK8ei0ts5wXvSQ@mail.gmail.com>
 <CAA5RZ0s16eHrzcDupipAxC++e-p_n_M7Fpg-MG-V59fB=wykLw@mail.gmail.com>
 <ad1rubGPdHxNnDh5@paquier.xyz> <ad5l0sGiJwdkXI-L@paquier.xyz>
 <CAA5RZ0uM7_YPdSahGh1sGeewMb9SzKswyLaZty8aR+a7XpQydQ@mail.gmail.com>
 <aeVSPx7F3ghkZugb@paquier.xyz> <aegozMN-abH3ki-P@paquier.xyz>
 <CAA5RZ0sQfnLyv2Ta-r6y==QwwUr+M0BxVbK0=0_HZZA1ywc3Bw@mail.gmail.com>
In-Reply-To: 
 <CAA5RZ0sQfnLyv2Ta-r6y==QwwUr+M0BxVbK0=0_HZZA1ywc3Bw@mail.gmail.com>
From: Mohamed ALi <moali.pg@gmail.com>
Date: Wed, 29 Apr 2026 14:36:09 -0700
Message-ID: 
 <CAGnOmWpHu25_LpT=zv7KtetQhqV1QEZzFYLd_TDyOLu1Od9fpw@mail.gmail.com>
Subject: Re: [PATCH] Fix: Partitioned parent index remains invalid after child
 indexes are repaired
To: Sami Imseih <samimseih@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Haibo Yan <tristan.yim@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000008b20140650a023ba"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGnOmWpHu25_LpT%3Dzv7KtetQhqV1QEZzFYLd_TDyOLu1Od9fpw%40mail.gmail.com>
Precedence: bulk

--0000000000008b20140650a023ba
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael, Sami, Haibo,

Thank you all for the reviews and for committing the fix (9d3e094f12).
I'm glad to see this backpatched through PostgreSQL 14.

Sami's targeted approach =E2=80=94 only calling validatePartitionedIndex()
when the index is already attached AND the parent is currently
invalid =E2=80=94 is clean and avoids the concerns Haibo raised about
turning the no-op path into a generic validation hook. Good call.


I noticed that the commit did not include a documentation update
for ALTER INDEX ATTACH PARTITION.

There is no mention that re-running the command on an already-attached
index will attempt to validate the parent. Users who hit this bug
would have no way to discover the recovery path from the docs alone =E2=80=
=94
they would need to find the mailing list thread or read the commit
message.

I have attached a small doc-only patch that adds a paragraph to the
ALTER INDEX documentation:

"If the named index is already attached to the altered index, the
command will attempt to validate the parent index if the parent
is currently invalid."

This applies on top of current HEAD (which includes 9d3e094f12).
Since the code change was backpatched to 14, the doc update should
probably be backpatched to the same branches.

Thanks,
Mohamed Ali
AWS RDS


On Wed, Apr 22, 2026 at 3:33=E2=80=AFAM Sami Imseih <samimseih@gmail.com> w=
rote:
>
> > > One thing that I'm tempted to add is more scans to check indisvalid
> > > across these commands, particularly after the individual ATTACH
> > > PARTITION bits on each individual index.
>
> That works.
>
> > > A second thing.  Do you think that it would be worth adding a
> > > partitioned table that has no leaves in some portion of the test?  I
> > > was thinking about a partitioned table called idxpart2 attached to
> > > idxpart in the first part of the test.  I've found this pattern
> > > usually useful for this area of the code when recursing with
> > > validatePartitionedIndex() from a parent.
>
> Good idea.
>
> > Both things have been added to the tests, and applied the result down
> > to v14.  The patch was able to apply cleanly across the board, without
> > conflicts.  That's rare, these days..
>
> Sorry for the late reply, and thanks for getting this committed!
>
> --
> Sami Imseih
> Amazon Web Services (AWS)

--0000000000008b20140650a023ba
Content-Type: application/octet-stream;
	name="v1-0001-doc-ALTER-INDEX-ATTACH-PARTITION-validation.patch"
Content-Disposition: attachment;
	filename="v1-0001-doc-ALTER-INDEX-ATTACH-PARTITION-validation.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mokkqa210>
X-Attachment-Id: f_mokkqa210

RnJvbSAxNjRmMjUxMjJiYzIxNzAyMTg4Mjg2MDZiOTQ2NmI4NzNiMWNlNjdiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNb2hhbWVkIEFMaSA8bW9hbGkucGdAZ21haWwuY29tPgpEYXRl
OiBXZWQsIDI5IEFwciAyMDI2IDEzOjU0OjQwIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gZG9jOiBE
b2N1bWVudCBwYXJlbnQgaW5kZXggdmFsaWRhdGlvbiBpbiBBTFRFUiBJTkRFWCBBVFRBQ0gKIFBB
UlRJVElPTgoKQ29tbWl0IDlkM2UwOTRmMTIgYWRkZWQgdGhlIGFiaWxpdHkgZm9yIEFMVEVSIElO
REVYIC4uLiBBVFRBQ0gKUEFSVElUSU9OIHRvIHZhbGlkYXRlIGEgcGFyZW50IHBhcnRpdGlvbmVk
IGluZGV4IHdoZW4gdGhlIHBhcnRpdGlvbgppbmRleCBpcyBhbHJlYWR5IGF0dGFjaGVkIGJ1dCB0
aGUgcGFyZW50IGlzIHN0aWxsIGludmFsaWQuICBUaGlzCnByb3ZpZGVzIGEgcmVjb3ZlcnkgcGF0
aCB3aGVuIGEgcHJldmlvdXNseSBpbnZhbGlkIHBhcnRpdGlvbiBpbmRleApoYXMgYmVlbiByZXBh
aXJlZCB2aWEgUkVJTkRFWC4KCkhvd2V2ZXIsIHRoZSBkb2N1bWVudGF0aW9uIGZvciBBTFRFUiBJ
TkRFWCBBVFRBQ0ggUEFSVElUSU9OIHdhcyBub3QKdXBkYXRlZCB0byBkZXNjcmliZSB0aGlzIGJl
aGF2aW9yLiAgVXNlcnMgaGF2ZSBubyB3YXkgdG8gZGlzY292ZXIKdGhpcyByZWNvdmVyeSBwYXRo
IGZyb20gdGhlIGRvY3MgYWxvbmUuCgpBZGQgYSBwYXJhZ3JhcGggdG8gdGhlIEFMVEVSIElOREVY
IGRvY3VtZW50YXRpb24gZXhwbGFpbmluZyB0aGF0CnJlLXJ1bm5pbmcgQVRUQUNIIFBBUlRJVElP
TiBvbiBhbiBhbHJlYWR5LWF0dGFjaGVkIGluZGV4IHdpbGwKYXR0ZW1wdCB0byB2YWxpZGF0ZSB0
aGUgcGFyZW50IGlmIGl0IGlzIGN1cnJlbnRseSBpbnZhbGlkLgoKRGlzY3Vzc2lvbjogaHR0cHM6
Ly93d3cucG9zdGdyZXNxbC5vcmcvbWVzc2FnZS1pZC9DQUduT21XcWkxRDl5Y0JnVWVPR2Y2bU9D
ZDJEY2YlM0Q2c0toYmY0c0hMczV4QWNLVkNNUSU0MG1haWwuZ21haWwuY29tCi0tLQogZG9jL3Ny
Yy9zZ21sL3JlZi9hbHRlcl9pbmRleC5zZ21sIHwgOCArKysrKysrKwogMSBmaWxlIGNoYW5nZWQs
IDggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfaW5k
ZXguc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfaW5kZXguc2dtbAppbmRleCAxZDQyZDA1
Li4yYTExOWY1IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL2FsdGVyX2luZGV4LnNnbWwK
KysrIGIvZG9jL3NyYy9zZ21sL3JlZi9hbHRlcl9pbmRleC5zZ21sCkBAIC05Nyw2ICs5NywxNCBA
QCBBTFRFUiBJTkRFWCBBTEwgSU4gVEFCTEVTUEFDRSA8cmVwbGFjZWFibGUgY2xhc3M9InBhcmFt
ZXRlciI+bmFtZTwvcmVwbGFjZWFibGU+CiAgICAgICBpbmRleCBjYW5ub3QgYmUgZHJvcHBlZCBi
eSBpdHNlbGYsIGFuZCB3aWxsIGF1dG9tYXRpY2FsbHkgYmUgZHJvcHBlZAogICAgICAgaWYgaXRz
IHBhcmVudCBpbmRleCBpcyBkcm9wcGVkLgogICAgICA8L3BhcmE+CisgICAgIDxwYXJhPgorICAg
ICAgSWYgdGhlIG5hbWVkIGluZGV4IGlzIGFscmVhZHkgYXR0YWNoZWQgdG8gdGhlIGFsdGVyZWQg
aW5kZXgsIHRoZQorICAgICAgY29tbWFuZCB3aWxsIGF0dGVtcHQgdG8gdmFsaWRhdGUgdGhlIHBh
cmVudCBpbmRleCBpZiB0aGUgcGFyZW50IGlzCisgICAgICBjdXJyZW50bHkgaW52YWxpZC4KKyAg
ICAgPC9wYXJhPgogICAgIDwvbGlzdGl0ZW0+CiAgICA8L3Zhcmxpc3RlbnRyeT4KIAotLSAKMi41
MC4xIChBcHBsZSBHaXQtMTU1KQoK
--0000000000008b20140650a023ba--