MIME-Version: 1.0
References: <CALj2ACWd5apddj6Cd885WwJ6LquYu_G81C4GoR4xSoDV1x-FEA@mail.gmail.com>
In-Reply-To: <CALj2ACWd5apddj6Cd885WwJ6LquYu_G81C4GoR4xSoDV1x-FEA@mail.gmail.com>
From: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Date: Wed, 1 Mar 2023 15:14:36 +0530
Message-ID: <CAGz5QCLd8wm_KxZW=W+=roHnv+yS8pvw2qLP=G=FxDH53aee_g@mail.gmail.com>
Subject: Re: Avoid multiple SetLatch() calls in procsignal_sigusr1_handler()
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAGz5QCLd8wm_KxZW%3DW%2B%3DroHnv%2ByS8pvw2qLP%3DG%3DFxDH53aee_g%40mail.gmail.com>
Precedence: bulk

On Tue, Feb 28, 2023 at 9:01=E2=80=AFPM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> Most of the multiplexed SIGUSR1 handlers are setting latch explicitly
> when the procsignal_sigusr1_handler() can do that for them at the end.
> These multiplexed handlers are currently being used as SIGUSR1
> handlers, not as independent handlers, so no problem if SetLatch() is
> removed from them. A few others do it right by saying /* latch will be
> set by procsignal_sigusr1_handler */. Although, calling SetLatch() in
> quick succession does no harm (it just returns if the latch was
> previously set), it seems unnecessary.
>
+1


--=20
Thanks & Regards,
Kuntal Ghosh