Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBzGv-0087t5-Kl for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Nov 2024 16:34:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tBzGs-00Arwl-EP for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Nov 2024 16:34:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBzGr-00Arwc-S9 for pgsql-hackers@lists.postgresql.org; Fri, 15 Nov 2024 16:34:10 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tBzGp-00238v-C5 for pgsql-hackers@lists.postgresql.org; Fri, 15 Nov 2024 16:34:08 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-37d4fd00574so1169916f8f.0 for ; Fri, 15 Nov 2024 08:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bowt-ie.20230601.gappssmtp.com; s=20230601; t=1731688445; x=1732293245; darn=lists.postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=v5S6x6KsAQNQXi1fNPaS1B/DPc97ztJDfg4KAXMrCSo=; b=w73VL/sXdmK/ES2tPdcV8t0BaIuCS/6ZmynR5rrX5tQ8Fgs0ipZv6wM2YxT1HWFS3H vEY5dRSMB/9h6XhkMRxxoSU1m0EM4JuOD7iAifUVkZ+uo0qT6dBP7+uffwkQOSxkIgew TVAZ7oZyjsYRAYDW2JzYOz8907i0EPQvDn1MsfD7EAh/8YTQctA/0h6CFOvRVu2uhFRX v1/U6667aWw2aXUEtQWUdYPXfSQUPZ9mmW6yi0Q2/LpmdTFpcN/9gsOtIBNI0RgyDjpe 4NKg++Otb7X5OdCY0CFfvAYVPuBCi5KdLfGFd9nabSibWYCxbGeXY8HslRpn8e5jaxfK 8ZLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731688445; x=1732293245; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=v5S6x6KsAQNQXi1fNPaS1B/DPc97ztJDfg4KAXMrCSo=; b=PlIFaEpzcn0fnOrFTain/182xsi6ahK6Dz+8iFb6DVzDl/wr9CPbWG+ypDei3hEwhP 9cCChKTuxpbE6bvMM/VZWSyCFxZKYNSe/cGtUzOqaT1M4hZT5nlM2OJ2D/HwFNSaJcBx y7foLTTHSxnDWNTSCPFbA8i2yuE18os1OLcNCKR8HwNcDaGEGckmJXw6EymBH2wenzA1 TG7/PrTDqS/AzI7r3LGSisw3LvvV2oZQDYqD8ugcN66VVNhsIgPUVapPszMvzWQgvChS EpzINA53LvUz/BoRgXq80ecAfQE3pkja0sgTLcUX1xA528Bm8R7RuSkBw/tzcH6yklMT ZYsw== X-Gm-Message-State: AOJu0YwJLRZKnXseI8lzFcfM8qW33Kw5As7gZF+11amBQxrUHlrtG0+g rCdB1LtHT7YDhxHhmPUdK5RzKeSXnXlad+ZSK9xCMbI1FedVf4QtM9V6qdKIvsg+uVvPzpIzONr IqfaJOX5a/wC7oHk63I1aT/ErHelx2vuWqv9e9pYSKqy66OOYdAQ= X-Google-Smtp-Source: AGHT+IG4ML+vSXb+ElvV+xr3SmDl7pWNg/Fmq3fPbmOzSAqK5n/DV2Xxla1RXJdP8H1xBr5xXXxyMshXxIbvF+OkL3I= X-Received: by 2002:a5d:6c6a:0:b0:374:c157:a84a with SMTP id ffacd0b85a97d-38224f8742bmr2837020f8f.16.1731688444940; Fri, 15 Nov 2024 08:34:04 -0800 (PST) MIME-Version: 1.0 From: Peter Geoghegan Date: Fri, 15 Nov 2024 11:33:37 -0500 Message-ID: Subject: nbtree VACUUM's REDO routine doesn't clear page's VACUUM cycle ID To: PostgreSQL Hackers Content-Type: multipart/mixed; boundary="0000000000009f9b070626f622d4" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000009f9b070626f622d4 Content-Type: text/plain; charset="UTF-8" Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO routine, to reset the target page's opaque->btpo_cycleid to 0. This makes the REDO routine match original execution, which seems like a good idea on consistency grounds. I propose this for the master branch only. -- Peter Geoghegan --0000000000009f9b070626f622d4 Content-Type: application/octet-stream; name="v1-0001-Clear-btpo_cycleid-in-btree_xlog_vacuum.patch" Content-Disposition: attachment; filename="v1-0001-Clear-btpo_cycleid-in-btree_xlog_vacuum.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m3iyht4p0 RnJvbSBkNTBkZjFlMGNjNzIyOThlYmU2NmU4YTgxMWZmNTI1YTZkMDlkMmY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBHZW9naGVnYW4gPHBnQGJvd3QuaWU+CkRhdGU6IEZy aSwgMTUgTm92IDIwMjQgMTE6MjY6NTkgLTA1MDAKU3ViamVjdDogW1BBVENIIHYxXSBDbGVhciBi dHBvX2N5Y2xlaWQgaW4gYnRyZWVfeGxvZ192YWN1dW0KCi0tLQogc3JjL2JhY2tlbmQvYWNjZXNz L25idHJlZS9uYnR4bG9nLmMgfCAxMCArKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vz cy9uYnRyZWUvbmJ0eGxvZy5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL25idHJlZS9uYnR4bG9nLmMK aW5kZXggN2U5MTU4NGYxLi45MDFiNWY3MGIgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2FjY2Vz cy9uYnRyZWUvbmJ0eGxvZy5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy9uYnRyZWUvbmJ0eGxv Zy5jCkBAIC02MzQsMTAgKzYzNCwxMSBAQCBidHJlZV94bG9nX3ZhY3V1bShYTG9nUmVhZGVyU3Rh dGUgKnJlY29yZCkKIAkJCVBhZ2VJbmRleE11bHRpRGVsZXRlKHBhZ2UsIChPZmZzZXROdW1iZXIg KikgcHRyLCB4bHJlYy0+bmRlbGV0ZWQpOwogCiAJCS8qCi0JCSAqIE1hcmsgdGhlIHBhZ2UgYXMg bm90IGNvbnRhaW5pbmcgYW55IExQX0RFQUQgaXRlbXMgLS0tIHNlZSBjb21tZW50cwotCQkgKiBp biBfYnRfZGVsaXRlbXNfdmFjdXVtKCkuCisJCSAqIENsZWFyIHRoZSB2YWN1dW0gY3ljbGUgSUQs IGFuZCBtYXJrIHRoZSBwYWdlIGFzIG5vdCBjb250YWluaW5nIGFueQorCQkgKiBMUF9ERUFEIGl0 ZW1zCiAJCSAqLwogCQlvcGFxdWUgPSBCVFBhZ2VHZXRPcGFxdWUocGFnZSk7CisJCW9wYXF1ZS0+ YnRwb19jeWNsZWlkID0gMDsKIAkJb3BhcXVlLT5idHBvX2ZsYWdzICY9IH5CVFBfSEFTX0dBUkJB R0U7CiAKIAkJUGFnZVNldExTTihwYWdlLCBsc24pOwpAQCAtNjk4LDcgKzY5OSwxMCBAQCBidHJl ZV94bG9nX2RlbGV0ZShYTG9nUmVhZGVyU3RhdGUgKnJlY29yZCkKIAkJaWYgKHhscmVjLT5uZGVs ZXRlZCA+IDApCiAJCQlQYWdlSW5kZXhNdWx0aURlbGV0ZShwYWdlLCAoT2Zmc2V0TnVtYmVyICop IHB0ciwgeGxyZWMtPm5kZWxldGVkKTsKIAotCQkvKiBNYXJrIHRoZSBwYWdlIGFzIG5vdCBjb250 YWluaW5nIGFueSBMUF9ERUFEIGl0ZW1zICovCisJCS8qCisJCSAqIERvICpub3QqIGNsZWFyIHRo ZSB2YWN1dW0gY3ljbGUgSUQsIGJ1dCBkbyBtYXJrIHRoZSBwYWdlIGFzIG5vdAorCQkgKiBjb250 YWluaW5nIGFueSBMUF9ERUFEIGl0ZW1zCisJCSAqLwogCQlvcGFxdWUgPSBCVFBhZ2VHZXRPcGFx dWUocGFnZSk7CiAJCW9wYXF1ZS0+YnRwb19mbGFncyAmPSB+QlRQX0hBU19HQVJCQUdFOwogCi0t IAoyLjQ1LjIKCg== --0000000000009f9b070626f622d4--