MIME-Version: 1.0
References: <bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg>
In-Reply-To: <bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg>
From: Peter Geoghegan <pg@bowt.ie>
Date: Wed, 8 Apr 2026 17:30:21 -0400
Message-ID: 
 <CAH2-Wzk-=_jppioxmiFSo=a5NGNoVkV2AYt_xKU+qPOQiQtLzg@mail.gmail.com>
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAH2-Wzk-%3D_jppioxmiFSo%3Da5NGNoVkV2AYt_xKU%2BqPOQiQtLzg%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 8, 2026 at 5:09=E2=80=AFPM Andres Freund <andres@anarazel.de> w=
rote:
> When reviewing the index prefetching patch I got a bit dismayed at how lo=
ng
> pg_attribute_always_inline is due to the way it triggers pgindent to form=
at
> stuff.

I had to significantly reorder function prototypes to avoid overly
long prototypes that had pg_attribute_always_inline. While perhaps not
strictly necessary, we shouldn't have to work around the fact that
pg_attribute_always_inline is an absurdly verbose symbol name.

> I propose that we remove the _attribute_ part of the name.

+1

--=20
Peter Geoghegan