MIME-Version: 1.0
References: <bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg>
 <56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org>
 <ovpakrvg3mfwyumhkrxjgnwfb75jo534booip7pqrq7cjt4orj@vydvdlbscnx4>
 <CAH2-WznHSUJcV47OhoisvABjN2xjVOYh0_bRagUE6ir5zGJzow@mail.gmail.com>
 <adee40b0-ee0d-40a8-abe7-61784db3ec6c@vondra.me>
In-Reply-To: <adee40b0-ee0d-40a8-abe7-61784db3ec6c@vondra.me>
From: Peter Geoghegan <pg@bowt.ie>
Date: Fri, 12 Jun 2026 12:10:39 -0400
Message-ID: 
 <CAH2-Wzm3ev6uGsf4QddpaZamzsb3ATvanggEHxnhRSkdd52bnA@mail.gmail.com>
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
To: Tomas Vondra <tomas@vondra.me>
Cc: Andres Freund <andres@anarazel.de>,
 Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAH2-Wzm3ev6uGsf4QddpaZamzsb3ATvanggEHxnhRSkdd52bnA%40mail.gmail.com>
Precedence: bulk

On Fri, Jun 12, 2026 at 11:23=E2=80=AFAM Tomas Vondra <tomas@vondra.me> wro=
te:
> I'm not sure about pg_mustinline. It seems weird to me, and I'm not sure
> saving the 3 characters is worth it, pg_always_inline seems better.

I'm not going to make a fuss about it.

> Yeah, we should not do such weird stuff just because of unnecessarily
> long attribute names.

Right. Basically, I don't want to be told that I must completely
change the order of function definitions because I used
pg_[attribute]_always_inline. It's just not reasonable to impose that
requirement on patch authors.

> Question - do we plan to do this in master only, or was the plan to
> backpatch the change? I'm not sure if these labels are used outside the
> core code, that might be an issue for backpatching.

I think that we should bite the bullet and backpatch. I count only 17
instances of pg_attribute_always_inline on the master branch.

Some extensions will no longer build against the backbranches if we go
this way. However, extension authors should find it easy to work
around this on an ad-hoc basis. They're going to have to work around
it sooner or later, so we might as well favor the new spelling.

--=20
Peter Geoghegan