Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w6wBd-004nhL-0j for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Mar 2026 19:52:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w6wBb-00HEFs-28 for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Mar 2026 19:52:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w6wBb-00HEFk-0q for pgsql-hackers@lists.postgresql.org; Sun, 29 Mar 2026 19:52:39 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w6wBY-00000001gt4-3lGn for pgsql-hackers@lists.postgresql.org; Sun, 29 Mar 2026 19:52:38 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-43cf7683a28so394651f8f.2 for ; Sun, 29 Mar 2026 12:52:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774813955; cv=none; d=google.com; s=arc-20240605; b=BaU2M8NUEPKuVlFX4F+uGZ4pZ8T/nGcBVAt/a2/H3xc9A8DsdcHRfRuYXaP+g4/oDK /Vgc0a6yhsSsxwCY1W39XVtJSdwF+12H2ZkmfCw3ZHpFIBB/egINMylFdh0Q0A6dgJsc Mb3WttK2ajYMaqnYPFSn1NcefnWly2mNxn3XUjJPj2yzrk4Ed78QVNMK/x2SAQ4MgGu5 mJrQoPDuHXZ8zbArjWp+ZYtCFcFoYiv76MvZDBL3fz+PV/Qmco9SkkJOs+5Aa1danuzM /MqqkG4T80bOHZZYwXGZTCmn+lOwvongda/qvO8ZvoO978SpYpQ8R4yNabufs19l0PDa DPrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HYlQkXnKnwOUwZOfBH3KXBq3rgkFiwl3tfDO3X90BmU=; fh=soeRyV3UX1YGcd3WStPxcwik0yOFFQTHEfCYcurNCtU=; b=BlIkSnP8POa4DDp+zU5Q6TxpF0zRxTe+GrYhoV2uprYJmLTC031brwkYEbrOVBDJGk 2tMVl6wOC+9XH7kD1NjxaHhejxdpBYLEBL6KwIUzKB4sKgaZyf7OUuDR/0Bf/FM8FOpT dVkdw6E56aytVhfY7epEr5D6XrdnbjrGK23isDdFFAJ/tqIrzLmkXTuZsC2UUc4GfDK6 A41Hr/8BzIQzx/yFr8tdeVAmQJGoWoxj+SoA2SNY27H/dGZZGVe5xXsXoykjVnWSQmDg uxLvdoBjI+Sk7QW+K+q6BLkXdG+eAFIXw0Q+NkRYnbNpVSBuQBRnvb1f4cLBXcEoLj6K z5dQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bowt-ie.20230601.gappssmtp.com; s=20230601; t=1774813955; x=1775418755; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HYlQkXnKnwOUwZOfBH3KXBq3rgkFiwl3tfDO3X90BmU=; b=VRsWl9kPwiOb59wkpp/+LISN28Ix2wY3KKQnliwbpGMMf7RottZ8m27Sp641xBlZDP I+dQ2OdO+RlZ4sp5OljKORWczTMx5ytn+I3KNKrhU+ijctTph1rkBKw2vbka96n5VPbJ eTUq9JjkzT2J8SGyEDlki7Xa83prv/UmSnWc1OA+XbgHE296yCbnjHzNxn7dKXtxQPN6 9HwmrIJDsBsPw1g6odgYpH5XsWOJZb35C3cGz63AvZT1DJ/s3XXlGWqcLvM7I6IkKdyd 5tMKZoBpKUou1TPYo2UPbrV4MHewRpZJbpT3RjBlfZoZYHN6VshmsFpXWundzN40Ivt2 hlUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774813955; x=1775418755; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HYlQkXnKnwOUwZOfBH3KXBq3rgkFiwl3tfDO3X90BmU=; b=mHXokLU73WFv+Uibi23cn2IT7XUmniqgUCAhCwWGderiXagDNj6VeMHZqfgIt/FQaf 1yP5/XOdVagwhFNn7H8yly8Hxr54mRD1/8X+QWmDf2Jc8tSX42hlDngDvW8hBOxXqvSS GUOlfAuR9Kh2CaS+m3z7Z54B/N5ogMFJyZN/yWAOtunakuMUN/9P5WOdY0iIOsg5siAV +lySjMEK0YBdOq5C2ru4aDzfwCWHH2Dn9mBqohkD+XhCvCVio3GXkZ1AqXJtj116vF9M dXgFF4P6xH9VBVpQgza/pOAm0tfLNw6Rzs4Ikn1Bs5x3OikknRfvqjQ3Lp/6lSSgbsvP Fo9A== X-Forwarded-Encrypted: i=1; AJvYcCX95kkrSiWLN8/1n7q0lRkCJ5MOfKAgQa9ybj1yIGxm5PuNkbEESPHdfR1kT5FOGkMFqyG+fGbbWlj2uHaH@lists.postgresql.org X-Gm-Message-State: AOJu0YwnKhZlB2y1PSxC4eldD7GPzJ/ZfHcmtL46/dOeBfn2T2Ez+gom n7qq9sgOaMfB8Bs9L5bkygTfBdaTDgQR4a4eSoP1ipdIeEpScujK3f9JIqlMnUyWH+O5S1y+d2t 02LS6v/wc7GtfbRPNZMm0P1bwoBxWtV32jMUZCHOCjg== X-Gm-Gg: ATEYQzwJxA+5fxX1AhlS2j3P3u3yR5WjX0iHk2G6aL6KVeZZE5hzcxot5W+J5CJunjT RqyGo9w1sjFCHnAaIwZozfrqrpj7Oag95Z6GQ4OtaEMzUsd/qSLb7hssmCB5q93jRbM4WfN1HNA qtBz/pyM7nqwL5Bv0+NNG4xWSkbEqSmxiRuhqE4KHVcqViDx1f8eVAAwJ6QSbF6qPBFiYzDbVMO eSZdKTEo6caR4HSdZd7pqhrh2otCQ0ynolrYCSWhmbDkisrpvpExIpZuzQ1ZVpHAd4MppvN0hos K7hZ0pmFsq1BWYMN6BIKLzJpZebqSW7ofAGsjtQ7zLWu8YNX+LDE4g== X-Received: by 2002:a05:6000:4287:b0:43b:4f86:e996 with SMTP id ffacd0b85a97d-43b9e9e8419mr17157229f8f.29.1774813954947; Sun, 29 Mar 2026 12:52:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Geoghegan Date: Sun, 29 Mar 2026 15:52:08 -0400 X-Gm-Features: AQROBzD21fYLnuNIF_XzYPetnCIljBz9Km7E6pXZqshYDxa2tF5O_F8nECBDC0s Message-ID: Subject: Re: index prefetching To: SATYANARAYANA NARLAPURAM Cc: Andres Freund , Tomas Vondra , Alexandre Felipe , Thomas Munro , Nazir Bilal Yavuz , Robert Haas , Melanie Plageman , PostgreSQL Hackers , Georgios , Konstantin Knizhnik , Dilip Kumar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, Mar 29, 2026 at 2:16=E2=80=AFAM SATYANARAYANA NARLAPURAM wrote: > I am still reviewing / understanding the patch, a couple quick comments b= ased on my review. > > 1. Looks like off-by-one in the for loop in the patch v18-0015-WIP-aio-io= _uring-Use-IO-size-not-IO-queue-to-tri.patch You're right. Andres independently fixed this bug on our working branch just yesterday. > 2. NIT comment: _bt_endpoint return type changed to IndexScanBatch from b= ool in the patch v18-0005-Add-interfaces-that-enable-index-prefetching.patc= h. > But the places it is returning false would be good to replace with NULL.= Though false is treat as 0/NULL and no compiler errors, it improves the re= adability of the code. I agree. This was a simple oversight, not a deliberate choice. It'll be fixed in the next version. Thanks --=20 Peter Geoghegan