Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wSMaV-0038RC-1v for pgsql-hackers@arkaria.postgresql.org; Wed, 27 May 2026 22:18:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wSMZU-009ojx-1w for pgsql-hackers@arkaria.postgresql.org; Wed, 27 May 2026 22:17:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wSMZU-009ojp-0h for pgsql-hackers@lists.postgresql.org; Wed, 27 May 2026 22:17:53 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wSMZT-00000001lA5-0Dl0 for pgsql-hackers@postgresql.org; Wed, 27 May 2026 22:17:52 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-45e8a834cc2so7224239f8f.1 for ; Wed, 27 May 2026 15:17:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779920268; cv=none; d=google.com; s=arc-20240605; b=Ex3phxHZNkBbU+1xFgQq8mu2HC3LHUrEzAwFU0ETkmZzLNHXG6SYC/u2quGRMwW2U0 9Zdvzf7tVka06xZZTjIX3qZCYwundX/WMYRs+2CD35rx14a+Rajck+RbChUOnhnSOfxt uTiGuD9mgUrnFks6Fn+qys+UpVOjoqauzG7K4hl/v1zzRYgbzCdopfiQrLcYtdhvvADz VTWa+3ySOjspmDvJYXi/VhDng6vbIQVvh3dHR9Eay9WczC0yFN5RR/CLS59agCpFNogG hjWANeU/kAObdJoIk4yevZaCbPYbAerWChekZEWBa5MEwuniR8R6A0tnoUUM9GZcDDBt U3ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qUo5nG3hYvOvtdHxMi4c1Q2xS4BAYLCbEdMrURp7jSI=; fh=zYOOnLZhvVYuzo9qzZMVNS1ZY7lcSxgNUaJWU9VuB3Y=; b=AhF0kkG6GwGuXBFnCXNIwRAt6t2+UyBxIOD4Wjd+4wg9+/0USg3pPNvw44y6voGgDw O8Z3v/qlGFo8V9yt9PKrcuigwLccZMhYCrg/IOYPc++6oPNQG48BH5nCYw0ehv8Rse/t X3Ol8VcGHb2r6txTTGQ4bnDu/U+PCGGTEV1mhergMznU41PzlLGdoyV+m6gODl5x1YrO 1NnWZdqdwNxnIO8f12sBvOF01TcLoLE/TCCTOoRt20DsTJOeHLgbRPDjhOKmDPzij+bD JHSIzmWVtU75K9WbOOSiDM8boQSKbHXyn3RJLZZ2RhrTEUteafQXHJEVebQaXkLgTyTE 347A==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bowt-ie.20251104.gappssmtp.com; s=20251104; t=1779920268; x=1780525068; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qUo5nG3hYvOvtdHxMi4c1Q2xS4BAYLCbEdMrURp7jSI=; b=aeoXcaU/cfj5510Fu0gPB9BM1G9JNDZbqvqmt6HSb+S066P2lFZXSnj6SB/+QiHtsf xxYCQujJ4NCYtr94OkTHWBsOY4LQRWaMbiaMrLCxZlQNyApaqa6ejfzjVFDsyWdbN0Lf aXv5jHmz1cEcpnhNxaRncGj/kCBDqLwDItwSahv+YjxrfHJapuNm7f/QtW/y1n9mDcgJ Qjxt+rlDBOvdfUIMibNb4/cIJRGF3L9ltVLymH1sTi8muAZhznoFHwdXwDeCjrvyVXZ7 PCLcHZvu5cJrGNRHMHbMMPNV5qkbKdSppJea80Pk9pepT//cDObZIyHRoTXqxrcbD3so h4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779920268; x=1780525068; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qUo5nG3hYvOvtdHxMi4c1Q2xS4BAYLCbEdMrURp7jSI=; b=QgQKJlVRclsaej9toSHypQgsMMmrvogqI34ksc14nIxe0jqgIWlrRdvk4zKJ1X+I4G zysb++jeBKUiBKQCLSJWawk/ahwMuEql/GydCk5beDzuz+XFTxSr9ZY02ZD1D3Gw6zi/ YnSf+mXfvJA1ZTtyIG5WRHrR5ik5LskNPXU8UrBKoQslruL+ru0ORBOIga6l8VPyjTqR GGuvdiVENRv+6YhnknohPMQNfuGGy062Yl/4ZfOyAX0xBBtliRMwQ8SXTwERU6pKVwaO T6Ngwn5zOI5RnSdvg8U8lphHvie6r+T6LEd+/lVn3HotPFcto86nlKortCw6GCeIJH7r +m1A== X-Forwarded-Encrypted: i=1; AFNElJ96ejR5qD1jn4J9HjuK2J5a3XHQ7eMMq57Lol087ozHBUSYNLAWCkHgdmK0zQr+LVj1P7oBOJhrR1HLKBCm@postgresql.org X-Gm-Message-State: AOJu0YyXNw+ld5buDnJ9/jSd+P3QIfe6L/DeUEIcqdD+oTF+I0Z5XAfe AX16dOKiGWami9aiJePtxmW/8JgG3rrfmxkr/aLdd5686sn8l4AGbC46QBmayUitDXTGHjncHrG BgbPaVX4czjBmbRdpDZjM/Qa18h4Xx3eepxrmBNpSbv8OYSJ+woCjg64lOA== X-Gm-Gg: Acq92OFsDeqDqWa7y+MWdwytW6sZNPE7WKZ/BC9vc9PkFEGZhdwXhFmH7vp4xB7OmzL K+hMgJHlIiKeL0+IQWEUBwHJ/2Vs2+Q5Og3qwwvDpkosAN+KV5bFNxTyXga6XlK9M2JDxKg50pY pdIjpW35fJGeu/Oh6IuYc028HgC5AFhFkURw2P0ZJwl666O5rQLi7bWg3uvsRy8cI8yMadEFuJQ Q3kpDDexBgCuZx3NuabG+UylFEsHuER+xA+pceDDlVIo2zQ/lrm4ny/iBhA6LwPeCi1wN1tn6Ym uIFKM+kw92p3GKXryc1c02pbXNjufBHZRMDmSvRa9DppHSZcmAx2G35IKtoQHnrGJQtccGsIpXM = X-Received: by 2002:a05:6000:4701:b0:44a:525b:2851 with SMTP id ffacd0b85a97d-45eb369c4e3mr40001220f8f.10.1779920267675; Wed, 27 May 2026 15:17:47 -0700 (PDT) MIME-Version: 1.0 References: <56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org> In-Reply-To: From: Peter Geoghegan Date: Wed, 27 May 2026 15:17:20 -0700 X-Gm-Features: AVHnY4KByEW4qhHgvupKDMuP_kt1Porr_B4mxg2KGjG-jc4-yNSDxkSYbn6ncTw Message-ID: Subject: Re: s/pg_attribute_always_inline/pg_always_inline/? To: Andres Freund Cc: Peter Eisentraut , pgsql-hackers@postgresql.org, Tomas Vondra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Apr 9, 2026 at 10:40=E2=80=AFAM Andres Freund = wrote: > Created a CF entry, to reduce the chances of me forgetting about committi= ng > this early in the 20 cycle. We already have a pg_noinline. How about renaming pg_attribute_always_inline to pg_mustinline? That is an alternative that is both consistent with pg_noinline, and even terser than your proposal. I have no intention of holding this patch up with bikeshedding. But I noticed that even your proposed pg_always_inline rename still leaves function prototypes over the column limit with moderately verbose function names. It seems better to avoid that outcome. --=20 Peter Geoghegan