Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wM4i5-002DIt-0o for pgsql-hackers@arkaria.postgresql.org; Sun, 10 May 2026 14:00:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wM4i2-00ExVh-38 for pgsql-hackers@arkaria.postgresql.org; Sun, 10 May 2026 14:00:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wM4i2-00ExVR-1y for pgsql-hackers@lists.postgresql.org; Sun, 10 May 2026 14:00:42 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wM4i0-000000018Xe-1D1F for pgsql-hackers@lists.postgresql.org; Sun, 10 May 2026 14:00:41 +0000 Received: by mail-qk1-x744.google.com with SMTP id af79cd13be357-8eb4de77886so58650285a.1 for ; Sun, 10 May 2026 07:00:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778421639; cv=none; d=google.com; s=arc-20240605; b=RBlyOhhDRkgHW+6OInVjxDi+0wlDv224/EBW+JhdVl7WjHRmzzZ/IrGyBJ6+hcagWH rPJpOF/IH0NkKydozy4L6lGE+oWq12T5DphPEJu18A0Ek1zRPwNCXtYnJgaJPZMXIlkH NqLLQN+qL1QE5p58ADYHzasiJGhRarrdf8uxKx6MAw+QWgQnemcMYo5+9js0e3u4B8ag EgS8wLBItszfJYrpCJjXnZ4CR1tTkovMcPskCowZvnFBtRP47wG8Jqf1kapiXK+nHAlp oy+Wxi9tBom28CYOXL4wfFw8FnyvOh4mvt5+m7fQyiqjyvp+vBXYPp+5P4xbQc0VjhhT OH8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=naMsgg4oZws/JUCpeUzypvzboe6qK6clY2e9bGsDHdU=; fh=aTBWPYEAxtF232iLZZReX3y93+xNwtfs4w/qOS6IAR4=; b=LHKxpglsqOrbjUn1YINdeVu6kNq6eof/lGulky8fy1w2PMdis0JT3XPgWpT96GWk3+ btOV2I/BUao03Bz6stVgxb8BOQwQg76P3iPxHO/qWkJdZCcA2emb9XWCSgXhWvGRQfvC cRdCJtD/bm8Te8NrU85d/zvGpIJUUQwz6eZFEbHyIOKwILNCOi89aBtaL7QE7LFLkRyo sja/VLi4NgPt3mWrx5eTuxpwAcsYzyn2PEaQlg4D30snCFtvgZZZUXJGZTb0eMb0jigu KwGdg2Osg30c/rhzHoqdtxYd8ANMFD3XYi8Z0ZkAQOWH27iKlKXs+Ky6pZMS+dr/RR1Z 6+GQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778421639; x=1779026439; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=naMsgg4oZws/JUCpeUzypvzboe6qK6clY2e9bGsDHdU=; b=bzxXCdDSv+2OmnvCrnQ7drVUpHgk1PACTSKjKdfxP3+XcVa0YieurGbHasTz2mCsMr QzZ5Y6ZdvLu3FpHl4/89TWttPVVDwTSoFYcwd7i6oZWD9HnXfu7uEhOv67/eXK1sR50t jykz1lVIA2MnMLV0N21nj0uOxCajKudRyucJXV+X0z2eu1KAPRhr41dYEKr+znanjhjm JmMeYrKM8HOM33GEwZ3mo3syrr7ZasU+0oaBrxLpA8uUz6XWIfSK1I+KRKojyO/4tQfT rFCPBgVSB/ARNs9mVCkw/RU7SYOJSA7zR4OpLc+6vYAWn79DNDB5EpYeDxcKenl1cj2g qNNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778421639; x=1779026439; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=naMsgg4oZws/JUCpeUzypvzboe6qK6clY2e9bGsDHdU=; b=Yn+Ba4Hxv2eS/NX53+hPVir+dV3QYXY2k8WyCA5ReStIRRNkU8nmVliNexppF6Spme 0HOBoqzS4xkZbnSt5t6U7i6cX/D46+dpSGawvXpST4TzHYTDL0O54Hnl7cyTbKAVt0jz oDMSLKNSSn4qjOXNXuxkCQB7jlbb+0jPJzOmrI9L83wMrSxT+IDcyiDoTwYatKaOP84S Vp+aFJhD/RfUs6Pd60bawV4FcoFSY+sXOt9Gq13+lQCIlbBNV9XjZN5x5I7T8q+b1VLZ 7quj9o3zQW+qHhnB7ZgCvx4K9D/b+6DDIBakrOT05XegiiPvFnJSaXxawxsGCaK4tRgL 1DEw== X-Gm-Message-State: AOJu0YwaKg32kh/n0uGfzToYCM0DkmzlXr9jAO5RJBX8Rx6MO6ctC2Ex MIzYohE3JkRon4T5tbwMg+fCDD2OkaPjIWgTCBzI/JJluzbiZeWypKhlbEQs0KBuHhGE4tMwqnK pPphtkChqEDv1PPIjHJ2oUpEXMWxfuoQ= X-Gm-Gg: Acq92OEwGmEtV/7T/WBe/eMa2oHyHdM1PMVDQNAS5AjKen5jt1wBi0HqUU2z0gnMlGQ A2OS7X+OKA/kZ/nEccYBPTcsMv6TvGgBV9q53ni24hCmCHnfGej17JTJxxIbGBluD0m+UQRwvaV 5uJxfu+VzdI4RU8AKfv/nxqSF7wEPTplRdQZC7G8UAuuMZyiEIF1VbkxJSQxDEfiIQN/uFsVill X3JvOn6k0nHgyDIxEqNvKDJINFhwLKADl4wfNOF4yJUgQ0DYuNX8qbEaDxiwNI1uE67hjK8GL1u kZi61OlIg23PwFtW X-Received: by 2002:a05:6214:19c5:b0:8ac:a205:f118 with SMTP id 6a1803df08f44-8bc462028c9mr225034116d6.8.1778421638842; Sun, 10 May 2026 07:00:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: solaimurugan vellaipandiyan Date: Sun, 10 May 2026 19:29:53 +0530 X-Gm-Features: AVHnY4IAahQBAMZWIXJjDtLpaeahFK-CkAqYcDm6eqWdKET6pvOY6RN-gREbBcE Message-ID: Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments To: Payal Singh Cc: pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Aleksander, I tested v7 of the patch on current HEAD. The patch applied cleanly and multiline comments were reformatted correctly in my testing. I also verified that repeated pgindent runs did not produce additional changes, and git diff --check was clean. While testing some real PostgreSQL source files, I noticed banner-style comments in contrib/seg/seg.c still receive formatting changes like: - This file contains routines ... + * This file contains routines ... This looks similar to the earlier discussion around separator-style comments and possible unnecessary diff churn. Since these header comments already appear visually structured, perhaps preserving them could help reduce additional formatting noise. Apart from that observation, the patch looked good overall in my testing. Regards, solai murugan