Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wMORh-0002rF-0T for pgsql-hackers@arkaria.postgresql.org; Mon, 11 May 2026 11:05:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wMORf-000XiQ-2y for pgsql-hackers@arkaria.postgresql.org; Mon, 11 May 2026 11:05:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wMORf-000Xhr-25 for pgsql-hackers@lists.postgresql.org; Mon, 11 May 2026 11:05:07 +0000 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wMORd-000000001nc-2hO2 for pgsql-hackers@lists.postgresql.org; Mon, 11 May 2026 11:05:06 +0000 Received: by mail-qv1-xf44.google.com with SMTP id 6a1803df08f44-8acaf231d37so1913146d6.1 for ; Mon, 11 May 2026 04:05:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778497505; cv=none; d=google.com; s=arc-20240605; b=jtUqmps2Nq1fK+89RFQSNv2XWydCZLpWmgsK07ERegZDT9pvzkpB0Mp9F442Oucz8K YMACahk5Ybbuk0vyzXIiV7gcq1olPiZNOGUb+a4fMQ0moI/Sk/MK2Nq3Mm1YtZ+0Q5+O a3UUoZdS5HOAHMqJ7SFLH/mMIlZMbXGPq8omZE4aygpSlaHJKe9og4bvA0p11ntfYnlO uaWeuPaPL/GQUQbLy8YRjt09qCA5v3Jo2LTDvAUITEThDlTkTzMu7+rxmCsqjwal+42w ZimRe7CIzwyp9Ozw7xCW1mmDHg3t7a6GwfiaFD7KFlXPlLpV550KnKefHfcBrfS2TJNk tfYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=XMDiykKPEzL+dQSHq+setxM3r1LMbgdl8TXop5Mo2G8=; fh=vvrr344Bb+brA62NkcL7XEhai6Gb2wcmJ3FLOhCcKf8=; b=XJ9d3Q9jMNK6Gvr+IS5pPT4CLeqCqFszBbr7ZUvjq5bqibS7rsR3+/8iQTny8c1GIU AYFzABtlJ4V4zB/q9XMcguL0X15CrNyMYBHcVPc8sAd+9ddopALCPkGwewrCcjsgx6HE Y9hgZCDxmF0OQWl/f2gyij/5jbKUk8Fuf/hp8n+zlH6c6nirBOgM3/WE/1zpXJ+RZqqG JUxG9ebdOQvR4TEtsf4ioYswMzl4jKBn6SzaI20VEekZo9UAx+2eywq7P1uEOSMmndC2 HLaIKbPFu+xUHJE/bdGRyhWhKVzBHU/cg6+AnQrMIbVn+uMoywFWyaBS3ZAcMdTcNW2g /A/A==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778497505; x=1779102305; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XMDiykKPEzL+dQSHq+setxM3r1LMbgdl8TXop5Mo2G8=; b=U6qmxx4XZmkYvc7FWvOXJskg8r3NAtpxo8VzcCCpBSj7i0YJvHju15QVtRksCf72uP QFUsgOEg4vwFO3LP8hVCvWcg3Y5Lo3sXa0KK8/Ddj4Flq8rokVTKf/r6WmeqeE0H0zCR 34HLL0Sozgt81VEIYcdroG/GELW/fEskJCB7OkvGC9EFS04aYcdUBK9AzQtXi0TbWwer 9z8+fwfflDSHf/pitsFHuV7jzwfdJSl6l7+sUt6KQ7+YsOHJKny+jyqelqg9gK8MDqh2 xxMzPuEpRWm+CKH3kF357oHrwEMqWYwat/TLJFoC0/hrMVxiO5VrJghy6yymU39pDXJi pebQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778497505; x=1779102305; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XMDiykKPEzL+dQSHq+setxM3r1LMbgdl8TXop5Mo2G8=; b=Z5yMcaPgp1ULCTmdNs/sTvidWYKHZ4TX9xF6jMLxggMRTDHkXVdGBvqtLcqbbSL2sZ qsWD37JqFtsLNkfNeaJl9kxfidhVycPMYJ77/39/QefLXPmVbhqfQvQoXTEcd8G1zmef LXuG7ZtA9gUFvsUEMf9mM8pySVz1Xlbtr47gyzC+/vX9Vu/8IflscHxW5VYi5K/yQjbR HI5vgvYUKf8YO254D/TMX1VdM7gEz47D+/nqEg1fy2n0liOZB3uobnu7+oM/2vOKWSd9 OtZBi5XEuPPO7Y7BLaM8M81SUW/8xW1TB9E1Y0DuFqFlIktSBeSqDPajVqBVGxuOAyMc 8heA== X-Forwarded-Encrypted: i=1; AFNElJ+HR1ZFt6SLPuMRD+2yVucIIg3hNdc55pp8vqoCAWBxZFx7eJ2jiI51LgbysI6Nv6YAKcB7dl1czBgEmbtc@lists.postgresql.org X-Gm-Message-State: AOJu0YwqB09TBlSa7S2fEOda0UCOihaAvydoD2nt4eQPLYmXcuSWuQjO Vkw18Vt135vLtI7hD4VeyzJqB4XfO8JB8oKQk+7YvR3wt03aljwJ8DfIhSV1yweg4SyY8SQk1wD t4kZVcIx9axc0uHZyefhsTcJJRup6AyU= X-Gm-Gg: Acq92OF5ljykRSd0lNVtU6DJeJQw0TrKB2mNBuaITmGZVKmKWTToCMPa7A5xbVmxeo+ QV5Ba/SltTjnvvfjHI+nZFAyh4Oxnlf4sAYVvkaULhgq+P+L0ODsDF+rOEC1IV9NwkvKcFGHPZh cESN4NYMcpAxXQc9SB3JutfmaNJL4eKY+MOv6taTavqc4Gyl9hPUcMkf2q8Owy8VGXhKbt/91R0 hPoqmGxSWjdJ4yh+ZQ33UJsDm4zBzXaNvHNsEGxuqF39MsLymoVsz+Nti42tytcTmBZkrDJE61j 7e6szx2SqX9AF5m9Vg== X-Received: by 2002:a05:6214:2126:b0:89c:5fbe:cc5b with SMTP id 6a1803df08f44-8bc3ef107e1mr251322076d6.0.1778497505147; Mon, 11 May 2026 04:05:05 -0700 (PDT) MIME-Version: 1.0 References: <1645542.1778456249@sss.pgh.pa.us> <1678069.1778475894@sss.pgh.pa.us> In-Reply-To: <1678069.1778475894@sss.pgh.pa.us> From: solaimurugan vellaipandiyan Date: Mon, 11 May 2026 16:34:20 +0530 X-Gm-Features: AVHnY4INVcz26jyUXt8Yg9g71vsctO6okJAJg_LuhqgF89w2z4hW7dSP2CsirJk Message-ID: Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments To: Tom Lane Cc: John Naylor , Aleksander Alekseev , Payal Singh , pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Tom, I tested the proposed v8 patch on current HEAD. I reran pgindent on files like contrib/seg/seg.c and src/port/inet_aton.c, and the updated formatting looked more consistent overall. I also checked that repeated pgindent runs did not introduce additional changes, and git diff --check was clean. Additionally, the single-line comment case now stays unchanged as expected. Overall, the new normalization behavior looks much cleaner and more uniform in my testing. Regards, Solaimurugan V