MIME-Version: 1.0
References: <F780CEEB-A237-4302-9F55-60E9D8B6533D@gmail.com>
 <CAP53PkwEZ+UMmwA8cbUSUdE6phXi+xWmn5t-YAnvKf0qoBnOvg@mail.gmail.com>
 <D83C0F3F-0CD8-4D1D-B59C-F2AFBB9B2974@gmail.com>
 <CDC22691-F63E-4FD3-865A-2982E3B56DCA@gmail.com>
 <7d4afbdb.5322.19d70df0de4.Coremail.wxp_728@163.com>
In-Reply-To: <7d4afbdb.5322.19d70df0de4.Coremail.wxp_728@163.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Wed, 22 Apr 2026 16:04:16 +0900
Message-ID: 
 <CAHGQGwEM=s5vXPpXoismwRMNCnAmwwMJPnQEQYbPFTJGouV0rQ@mail.gmail.com>
Subject: Re: Re: pg_test_timing: fix unit typo and widen diff type
To: "wang.xiao.peng" <wxp_728@163.com>
Cc: Chao Li <li.evan.chao@gmail.com>, lukas@fittl.com,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>,
	Hannu Krosing <hannuk@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwEM%3Ds5vXPpXoismwRMNCnAmwwMJPnQEQYbPFTJGouV0rQ%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 9, 2026 at 3:13=E2=80=AFPM wang.xiao.peng <wxp_728@163.com> wro=
te:
> Just finished reviewing the v3 patches - looks good to me. The pg_leftmos=
t_one_pos64 fix is spot on, and using INT64_FORMAT for the error message is=
 the right approach.

Since pg_leftmost_one_pos64() can return up to 63, should the size of
histogram[] be changed from 32 to 64? If we want to display the full
histogram[] in the output, max_bit in output() would also need to be set to=
 63.
Alternatively, it may be fine to keep max_bit =3D 31 and show only
the first 32 histogram entries.

Patch 0001 looks good to me.

Regards,

--=20
Fujii Masao