Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDNMf-002twO-1b for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Apr 2026 14:06:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wDNMe-005i2r-2G for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Apr 2026 14:06:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDNMe-005i1w-16 for pgsql-hackers@lists.postgresql.org; Thu, 16 Apr 2026 14:06:40 +0000 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wDNMc-00000001K1C-1TMB for pgsql-hackers@lists.postgresql.org; Thu, 16 Apr 2026 14:06:39 +0000 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-46aa216a5edso4618208b6e.0 for ; Thu, 16 Apr 2026 07:06:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776348397; cv=none; d=google.com; s=arc-20240605; b=ZPrCb3uUyyHFtB1bLiSIZthQlgqQYcqs+ktfp5B44zsl8Vs/bPgIpnVSEITGa1uCpD Vf/EweuEIffmoS4FHME9eVgnsjTKOuBoFYUZQ+2/v7hg2K81J9b0zSpnJTfuRVsb+DH5 LbX/v6ySUphyhggOd9e6ls6SNnYb5dnqI4+uzcgN1BpI05GufzruKGQiiTyfp7gCZ5Nc 1rzT3Rd4bGRGlF+2HkIZ3LMETWlswsYis4TuqXBczLVIasJlQ3o0bByhflLQP/zVIdAL M2+h9nisAxb048yfWpmwowmdDOv1RW9iOfHriMw4d+sbTRCRkOItTW1hc/tNliQOuF3m Zn0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=cvX3fTMJIBJMLDYfbXQe+sjNe75UYu/ZT8STwXAOwfw=; fh=D5EyXJUX8FToB4J41n/L98095mOlhWUeVFKJkghh/ag=; b=jfPNxRohlCnPSHa3Hd4yk/dMN+BEW8DB7CXjQgyNwfCS6DHkuoN09cp3RqZD+zhhsZ 5+A7MTBGV6w1eWy9fKWe8Wr6cMopgq0QGGB9578E5SC2rc6M4tT45pH5kWqU/nksDaU/ CVxVpoCz0d7NBPEVQpQqJMXkUvuktGF7MsG8fuYzhKySzjIqBArZNI2dX3SR868e5alo kKUsvbDuLHdauoM81aRv7V3Odce0UECgXrASxdpju9mNgyqTdSPhB5ahxJXQfXk6Fghn zIzkP1wOOhuQ7EnoCFXtbSkWZu1L8zPJzjZ84vOvsfuhwF/AcsnAi/bMJdFEtHgG74bG eNFw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776348397; x=1776953197; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cvX3fTMJIBJMLDYfbXQe+sjNe75UYu/ZT8STwXAOwfw=; b=T24p2eVMBfiOSZpVMSILtFeh99o21xrgHaaM+ouScpYn6FkWkIBIquBBoX1JNoi8Ga 2kl6uunABU/vMGwGamhCxm73zSsvTQ8fhiKfKUPZm2kUqLg8eZmwIOJ/ViQHUi5qSSQo z6DcDEBTIIJdmY2Z2mzoLoDN/RTzQPX0vNQ6VT6vFEFfY63N0AfZMVlzn05zCZKwoQK3 X4UUQiRQpWZXot8iXhkrf55CoomS4CQVS2Ms9nY0Utis3ARjFV9Ipxdy+Q+7xe+jvvy2 hfO1LGCPxBrzJjVIgWJLT0nwS5Wdh4uF9C/qStBaxuWN2pI4iX7hOdCh0JAMv/N3Oz5A PUyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776348397; x=1776953197; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cvX3fTMJIBJMLDYfbXQe+sjNe75UYu/ZT8STwXAOwfw=; b=qSJL3AYPnD9QNaxElPqTfVi0b5WP4vFhAwVZY7fHETApzUEXnxhwQcRH+RJapU0MW3 ZaFPG2OMhZlzgMazIs8tPXrHB94dxwPHsU8+6RZl0DqJmKfp3zwkfd2H63WiJzPBWQA6 64QGj1pEl4KR2r+a8+GG/0RxUUOS9RKkSITtLGoaFBoPIP/sLQOkEJsdLaKcb+hvBMUe jicOib/cu5KcQBCxIZW5vYTlbhKIB/ny/udMpfwizTYOg5S0JJN235CQBESYI9OpViS6 PXaiBhDP5Q6AkvSuRrg5O7lI/1lqlrqSSW2gPGX5pPNCxzLVzTgi1HjGdUww5EiDHVDv jxAg== X-Forwarded-Encrypted: i=1; AFNElJ/zZuIMYPZfNA4NuN3nvaZCiY4iWE1DhAfmTnjAxDmiXtxV9LHCA4T2uFIhMi3d0p6tRm27AACzBrmNhGP6@lists.postgresql.org X-Gm-Message-State: AOJu0Yyx7NNADCizpJy7QEr10PntqCQV67q3kj+qte+z4V2Z8Z1gYDNX UPCIO42CbBnqCKZwReVs947jRZKRyNxLOBc3CfhheSVClQ0XAAnSAC8itv7xrtK8Z9wrvTUIJlI /mPmZwRTpDcPeES4DGwLMd3dbvb9uy7w= X-Gm-Gg: AeBDievlBXhEv7d3jnHIaXJ/JwM1luC6YYH12l42BR+2COBq+h9Hg7rqF97JvQaekwf Bn/tgdR6VVLfpukvDbIkRkh9kiaOYQykANQvaEj5kGbbeIfx/EK34WDMgAS7gGvy+EUz+F9vKRW mDMXoZz/lp1E80lSesULVp+1ZryyqNqkopTRCIpEGCIMqXNqIY8R3ibs2e1mzwns62imTMzP8tX gzfapiEmnRs0mDurtxekBOrC55FZsZbj/ec0PLK/tpmwFwg9emzfjrRaTWruukv2T0EhNAkqJao XgBsbTQweWmR9GpCHO+FwClBgaE6j2m4SYP9YCLS X-Received: by 2002:a05:6808:8898:b0:479:4696:fac2 with SMTP id 5614622812f47-4794696fae7mr6444752b6e.16.1776348397075; Thu, 16 Apr 2026 07:06:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Fujii Masao Date: Thu, 16 Apr 2026 23:06:25 +0900 X-Gm-Features: AQROBzAgXiKPo3Zczar1PBCvXoOaBj7Td_KOFLMA2NG4lfjeYFXMhuz58KCC8UQ Message-ID: Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid To: Amul Sul Cc: vignesh C , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Apr 16, 2026 at 9:31=E2=80=AFPM Amul Sul wrote: > The outer parentheses do not seem to be needed, as > XLogRecPtrIsInvalid() already includes them. > > Other than that, the v3 patch looks good to me. I've updated the patch based on Amul's suggestion and pushed it. Thanks! Regards, --=20 Fujii Masao