MIME-Version: 1.0
References: <e08cb97f-0364-4002-9cda-3c16b42e4136@uni-muenster.de>
 <DGD24UA7LASG.11H30IV2AFVA2@gmail.com> <CAHGQGwF-uuKkon8Ah9dbMiGKoYmFJyHZnDa_HcWWCXKnh7LJ2Q@mail.gmail.com>
 <50f693ad-faec-4b1b-8de5-88dc90b236b4@uni-muenster.de>
In-Reply-To: <50f693ad-faec-4b1b-8de5-88dc90b236b4@uni-muenster.de>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 13 Feb 2026 13:13:25 +0900
Message-ID: <CAHGQGwEbgCOpdaCRn81XiHbvGZ9Somiww0BE5ULE8_cf4CYA4Q@mail.gmail.com>
Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHGQGwEbgCOpdaCRn81XiHbvGZ9Somiww0BE5ULE8_cf4CYA4Q%40mail.gmail.com>
Precedence: bulk

On Fri, Feb 13, 2026 at 12:34=E2=80=AFAM Jim Jones <jim.jones@uni-muenster.=
de> wrote:
>
>
>
> On 12/02/2026 16:08, Fujii Masao wrote:
> > On Thu, Feb 12, 2026 at 11:36=E2=80=AFPM Matheus Alcantara
> > <matheusssilv97@gmail.com> wrote:
> >> The patch fix the issue and it seems correct to me.
>
> Thanks for the review!
>
> > The documentation [1] states that INCLUDING COMMENTS copies comments fo=
r
> > the copied columns, constraints, and indexes. It does not mention copyi=
ng
> > comments on the table itself. Therefore, not copying table comments wit=
h
> > INCLUDING COMMENTS does not appear to be a bug. That is, the proposed p=
atch
> > seems more like an improvement than a bug fix.
>
> Hmm, it seemed so obvious to me that I didn=E2=80=99t look more closely a=
t the
> documentation :) Although I struggle to see the rationale for not
> copying a table=E2=80=99s comment in a CREATE TABLE LIKE ... INCLUDING CO=
MMENTS
> statement, I have to agree that the documentation is quite clear about
> this limitation, and therefore it cannot really be considered a bug.
> That said, it may well be worth considering for a future release.
>
> What are your thoughts?

At first, I felt it would be more intuitive to copy the table comment as we=
ll.
However, on second thought, since LIKE can reference multiple tables,
copying table-level properties such as comments may not be well-defined.

For example, if two source tables each have a table comment and both are
specified in LIKE, which comment should be applied to the new table?

Regards,

--=20
Fujii Masao