public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: David Steele <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Hüseyin Demir <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: Improve checks for GUC recovery_target_xid
Date: Fri, 6 Mar 2026 00:04:00 +0900
Message-ID: <CAHGQGwEhf9byyjhcDEMAd0kPkTdJsO0-HNTnX6Hqs6puBij3-g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAHGQGwEnakTrosMp3Y=Trya4MTC-h8Lqx3FDU1mOALRQ0rz59Q@mail.gmail.com>
	<[email protected]>
	<CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
	<[email protected]>
	<CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com>
	<[email protected]>

On Thu, Mar 5, 2026 at 10:32 PM David Steele <[email protected]> wrote:
>
> On 3/5/26 19:42, Fujii Masao wrote:
> > On Thu, Mar 5, 2026 at 5:15 PM David Steele <[email protected]> wrote:
> >>
> >> On 3/5/26 12:03, Fujii Masao wrote:
> >>> On Thu, Mar 5, 2026 at 1:21 PM David Steele <[email protected]> wrote:
> >>>> The prior standby is not running because of the invalid config. I
> >>>> figured it was better to start clean but when I update the
> >>>> recovery_target_timeline tests I was planning to use the same standby
> >>>> for all the new tests.
> >>>
> >>> Alternatively, we can use $node_primary, since ALTER SYSTEM SET with
> >>> invalid recovery_target_timeline or recovery_target_xid does not
> >>> affect the primary.
> >>
> >> Well, as it turns out I was using the primary after all because I copied
> >> your example and forgot to update the host. Seems weird to set these
> >> GUCs on the primary but as long as we get the expected errors I don't
> >> suppose it matters.
> >
> > Thanks for updating the patch! I've pushed the patch.
>
> Excellent, thank you!
>
> Attached are the test changes for recovery_target_timeline. I can start
> a new thread and add it to the next CF if you like, but since it is just
> test changes maybe we can fast track it.

Yes, let's discuss and review the patch in this thread.

Thanks for the patch! It looks good to me. Barring any objections, I
will commit it.

Regards,

-- 
Fujii Masao

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Improve checks for GUC recovery_target_xid
  In-Reply-To: <CAHGQGwEhf9byyjhcDEMAd0kPkTdJsO0-HNTnX6Hqs6puBij3-g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox