MIME-Version: 1.0
References: <e84ede22-1b46-0780-64e4-5db4a1e5236f@0x48.dk>
 <3e890874-8204-e1c2-8def-3a02cbad2232@0x48.dk>
 <1658D50F-A8B3-406A-94ED-FA8C7F9DA90B@gmail.com>
In-Reply-To: <1658D50F-A8B3-406A-94ED-FA8C7F9DA90B@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 23 Apr 2026 00:29:29 +0900
Message-ID: 
 <CAHGQGwEn3oEad-wR1XoEbe1R-pB1EOycRKjEj+5Pp38mjgiF+Q@mail.gmail.com>
Subject: Re: Fix memory leak in postmasterMain
To: Chao Li <li.evan.chao@gmail.com>
Cc: Henrik TJ <henrik@0x48.dk>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwEn3oEad-wR1XoEbe1R-pB1EOycRKjEj%2B5Pp38mjgiF%2BQ%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 22, 2026 at 3:46=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:
>
> From my experience, most of the time the postmaster is started with -D. O=
n Linux and macOS, that path can be quite long, PATH_MAX is often 4096 on m=
any Unix-like systems, and I am not sure about Windows. So I think this lea=
k is worth fixing.

We can also free()/pfree() userDoption in postgres.c and bootstrap.c?

Since userDoption typically uses only a small amount of memory, I'm not sur=
e
this patch provides much practical benefit from a memory-leak perspective.
So I don't think it needs to be backpatched to the stable branches.

OTOH, if it helps keep Valgrind quiet for userDoption, I may be ok with
applying it to master.

Regards,

--=20
Fujii Masao