public inbox for [email protected]
help / color / mirror / Atom feedRe: Problem with moderation of messages with patched attached.
2+ messages / 2 participants
[nested] [flat]
* Re: Problem with moderation of messages with patched attached.
@ 2022-03-03 13:47 Aleksander Alekseev <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Aleksander Alekseev @ 2022-03-03 13:47 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Pavel Borisov <[email protected]>; Postgres hackers <[email protected]>
Hi again,
> Any chance we could include the reason in the message? I foresee that
> otherwise such kinds of questions will be asked over and over again.
A link to the list of common reasons should work too.
--
Best regards,
Aleksander Alekseev
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Checkpoint replication slots later
@ 2026-07-10 14:55 Fujii Masao <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Fujii Masao @ 2026-07-10 14:55 UTC (permalink / raw)
To: Hüseyin Demir <[email protected]>; +Cc: [email protected]; Ants Aasma <[email protected]>
On Sun, May 17, 2026 at 1:38 AM Hüseyin Demir <[email protected]> wrote:
>
> Hi Ant,
>
> Good idea.
+1.
CheckPointSnapBuild() and CheckPointLogicalRewriteHeap() call
ReplicationSlotsComputeLogicalRestartLSN(), which seems to use
last_saved_restart_lsn for persistent logical slots. Since
last_saved_restart_lsn is updated by CheckPointReplicationSlots(),
if those functions run before it, their cleanup decisions are still
based on the restart_lsn saved at the previous checkpoint.
So, isn't it better to move them after CheckPointReplicationSlots()
as well, so that logical snapshot and rewrite mapping cleanup can use
the newly saved restart_lsn?
Of course, we'd first need to confirm that doing so is safe, though.
Regards,
--
Fujii Masao
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-10 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 13:47 Re: Problem with moderation of messages with patched attached. Aleksander Alekseev <[email protected]>
2026-07-10 14:55 Re: Checkpoint replication slots later Fujii Masao <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox